New issue
Advanced search Search tips

Issue 767166 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 3
Type: Bug

Blocking:
issue 738275



Sign in to add a comment

VideoRendererAlgorithmTest.CadenceBasedTest fails sometimes (with timeout) in media_unittests on Fuchsia

Project Member Reported by scottmg@chromium.org, Sep 20 2017

Issue description

Cc: -sergeyu@chromium.org
Owner: sergeyu@chromium.org
Status: Assigned (was: Unconfirmed)
Going to disable for now as it keeps failing on the bot. Locally in a debug build it takes about 5.5s for me, so there's quite a large discrepancy relatively to the bot (~50s).
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43352db0eead02bd4d476555d01c36c6e3db93ed

commit 43352db0eead02bd4d476555d01c36c6e3db93ed
Author: Scott Graham <scottmg@chromium.org>
Date: Fri Sep 22 17:21:06 2017

fuchsia: Disable VideoRendererAlgorithmTest.CadenceBasedTest

While it only takes ~5s locally in a debug build, it's taking ~50s on
the fyi waterfall bot, causing failures due to timeout.

Bug:  767166 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I95fde0b34a743a6281f269efd625015baaa0d853
Reviewed-on: https://chromium-review.googlesource.com/678920
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503777}
[modify] https://crrev.com/43352db0eead02bd4d476555d01c36c6e3db93ed/media/filters/video_renderer_algorithm_unittest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7773f9885e09f23775399089e73467803c960451

commit 7773f9885e09f23775399089e73467803c960451
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Fri Dec 15 00:35:06 2017

Parametrize VideoRendererAlgorithmTest.CadenceBasedTest

CadenceBasedTest was running the same tests for 336 combinations of
frame rate and display rate values. Replaced it with a TEST_P-based test,
so it's executed as multiple small tests which don't timeout even in
debug mode.

Bug:  767166 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I7b9c2140cfa515c57360064fa1ebccc607bec0a8
Reviewed-on: https://chromium-review.googlesource.com/828050
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524263}
[modify] https://crrev.com/7773f9885e09f23775399089e73467803c960451/media/filters/video_renderer_algorithm_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment