Payment Request: Can't return from country selection screen without selecting a country |
|||||||||||
Issue descriptionIn the Payment Request UI, in address editors, it is not possible to go back from the country list without selecting a country in the list.
,
Sep 21 2017
,
Sep 21 2017
This bug requires manual review: Less than 22 days to go before AppStore submit on M62 Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d9bd7e17850a3af310b1a3073456b55690c257b5 commit d9bd7e17850a3af310b1a3073456b55690c257b5 Author: edchin <edchin@chromium.org> Date: Thu Sep 21 22:30:22 2017 Revert "[Payment Request] Adds a navigation bar to the country picker." This reverts commit 70e88907ec18a76cca76f39e96612c8b13d9720d. Reason for revert: This fails showcase egtests for SCPaymentsPickerTestCase on iPhone 5/5s iOS 9, 10. Most likely due to smaller form factor needing scrolling to find a view. Original change's description: > [Payment Request] Adds a navigation bar to the country picker. > > Video of the fix in action: > https://drive.google.com/file/d/0B4g_WskzVRJdQUVjLUE2RWRWREE/view?usp=sharing > > Bug: 767154 > Change-Id: I1881976b27ba6aade47d5d06879fb65dcf3d24de > Reviewed-on: https://chromium-review.googlesource.com/674667 > Reviewed-by: edchin <edchin@chromium.org> > Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> > Commit-Queue: Marc-Antoine Courteau <macourteau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#503521} TBR=macourteau@chromium.org,edchin@chromium.org,mahmadi@chromium.org Change-Id: I4c64e34558c3d5fe57d522f452a2286e40b1dd6a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 767154 Reviewed-on: https://chromium-review.googlesource.com/677414 Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#503584} [modify] https://crrev.com/d9bd7e17850a3af310b1a3073456b55690c257b5/ios/chrome/browser/ui/payments/BUILD.gn [modify] https://crrev.com/d9bd7e17850a3af310b1a3073456b55690c257b5/ios/chrome/browser/ui/payments/country_selection_coordinator.mm [modify] https://crrev.com/d9bd7e17850a3af310b1a3073456b55690c257b5/ios/chrome/browser/ui/payments/payment_request_picker_view_controller.h [modify] https://crrev.com/d9bd7e17850a3af310b1a3073456b55690c257b5/ios/chrome/browser/ui/payments/payment_request_picker_view_controller.mm [modify] https://crrev.com/d9bd7e17850a3af310b1a3073456b55690c257b5/ios/showcase/payments/sc_payments_picker_egtest.mm
,
Sep 22 2017
Is this considered fixed and ready for verification now?
,
Sep 22 2017
,
Sep 22 2017
The previous fix was reverted due to build bot failures. New fix coming soon. Will Mark as fix when ready for verification.
,
Sep 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/266e6ebd419359717c8d6aadf9311717765883f7 commit 266e6ebd419359717c8d6aadf9311717765883f7 Author: Marc-Antoine Courteau <macourteau@chromium.org> Date: Fri Sep 22 16:58:43 2017 [Payment Request] Adds a navigation bar to the country picker. Video of the fix in action: https://drive.google.com/file/d/0B4g_WskzVRJdQUVjLUE2RWRWREE/view?usp=sharing This is a second attempt at fixing this issue. The first one was reverted due to failures in ios_showcase_egtests on smaller devices. Those failures were caused by the fact that some elements were off-screen, and EarlGrey was unable to select them. Bug: 767154 Change-Id: I60df99bf12a0a0858c900faa6544bf562667eda8 Reviewed-on: https://chromium-review.googlesource.com/678020 Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Marc-Antoine Courteau <macourteau@chromium.org> Cr-Commit-Position: refs/heads/master@{#503771} [modify] https://crrev.com/266e6ebd419359717c8d6aadf9311717765883f7/ios/chrome/browser/ui/payments/BUILD.gn [modify] https://crrev.com/266e6ebd419359717c8d6aadf9311717765883f7/ios/chrome/browser/ui/payments/country_selection_coordinator.mm [modify] https://crrev.com/266e6ebd419359717c8d6aadf9311717765883f7/ios/chrome/browser/ui/payments/payment_request_picker_view_controller.h [modify] https://crrev.com/266e6ebd419359717c8d6aadf9311717765883f7/ios/chrome/browser/ui/payments/payment_request_picker_view_controller.mm [modify] https://crrev.com/266e6ebd419359717c8d6aadf9311717765883f7/ios/showcase/payments/sc_payments_picker_egtest.mm
,
Sep 22 2017
This should be ready for verification now.
,
Sep 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/496ac1fe788b3622b7508dd643a89fb2c0925906 commit 496ac1fe788b3622b7508dd643a89fb2c0925906 Author: edchin <edchin@chromium.org> Date: Fri Sep 22 22:57:00 2017 Revert "[Payment Request] Adds a navigation bar to the country picker." This reverts commit 266e6ebd419359717c8d6aadf9311717765883f7. Reason for revert: Sorry for another revert! The test is failing on iPhone 5s and iPad retina on iOS 9. SCPaymentsPickerTestCase/testVerifySelection: ../../ios/showcase/payments/sc_payments_picker_egtest.mm:249: error: -[SCPaymentsPickerTestCase testVerifySelection] : Exception: NoMatchingElementException Exception Name: NoMatchingElementException Exception Reason: Cannot find UI element. Exception with Action: { "Action Name" : "Tap", "Element Matcher" : "((((kindOfClass('UIView') || respondsToSelector(accessibilityContainer)) && ancestorThatMatches((respondsToSelector(accessibilityIdentifier) && accessibilityID('kPaymentRequestPickerRowAccessibilityID')))) && ((kindOfClass('UILabel') || kindOfClass('UITextField') || kindOfClass('UITextView')) && hasText('Canada')) && kindOfClass('UILabel') && matcherForSufficientlyVisible(>=0.750000)) && ((kindOfClass('UIView') || respondsToSelector(accessibilityContainer)) && ancestorThatMatches(((respondsToSelector(isAccessibilityElement) && isAccessibilityElement) && accessibilityTraits: UIAccessibilityTraitSelected))))", "Recovery Suggestion" : "Check if the element exists in the UI hierarchy printed below. If it exists, adjust the matcher so that it accurately matches element." } Exception Details: Error Trace: [ { "Description" : "Interaction cannot continue because the desired element was not found.", "Error Domain" : "com.google.earlgrey.ElementInteractionErrorDomain", "Error Code" : "0", "File Name" : "GREYElementInteraction.m", "Function Name" : "-[GREYElementInteraction matchedElementsWithTimeout:error:]", "Line" : "124", "TestCase Class" : "SCPaymentsPickerTestCase", "TestCase Method" : "testVerifySelection" } ] Original change's description: > [Payment Request] Adds a navigation bar to the country picker. > > Video of the fix in action: > https://drive.google.com/file/d/0B4g_WskzVRJdQUVjLUE2RWRWREE/view?usp=sharing > > This is a second attempt at fixing this issue. The first one was reverted due to failures in ios_showcase_egtests on smaller devices. Those failures were caused by the fact that some elements were off-screen, and EarlGrey was unable to select them. > > Bug: 767154 > Change-Id: I60df99bf12a0a0858c900faa6544bf562667eda8 > Reviewed-on: https://chromium-review.googlesource.com/678020 > Reviewed-by: edchin <edchin@chromium.org> > Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> > Commit-Queue: Marc-Antoine Courteau <macourteau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#503771} TBR=macourteau@chromium.org,edchin@chromium.org,mahmadi@chromium.org Change-Id: Iff3bb784ec3b3a572830aefc35ffaabd040e313d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 767154 Reviewed-on: https://chromium-review.googlesource.com/679576 Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#503898} [modify] https://crrev.com/496ac1fe788b3622b7508dd643a89fb2c0925906/ios/chrome/browser/ui/payments/BUILD.gn [modify] https://crrev.com/496ac1fe788b3622b7508dd643a89fb2c0925906/ios/chrome/browser/ui/payments/country_selection_coordinator.mm [modify] https://crrev.com/496ac1fe788b3622b7508dd643a89fb2c0925906/ios/chrome/browser/ui/payments/payment_request_picker_view_controller.h [modify] https://crrev.com/496ac1fe788b3622b7508dd643a89fb2c0925906/ios/chrome/browser/ui/payments/payment_request_picker_view_controller.mm [modify] https://crrev.com/496ac1fe788b3622b7508dd643a89fb2c0925906/ios/showcase/payments/sc_payments_picker_egtest.mm
,
Sep 25 2017
Tested in 63.0.3224.0 Canary, iPhone 6 iOS 10.3.3, iPhone 7 iOS 11, iPad Pro iOS11 Issue is still repro - Can't return from country selection screen without selecting a country
,
Sep 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/510f15126cb04f8d13da79122bbfe33f485956a1 commit 510f15126cb04f8d13da79122bbfe33f485956a1 Author: Marc-Antoine Courteau <macourteau@chromium.org> Date: Tue Sep 26 02:41:17 2017 [Payment Request] Adds a navigation bar to the country picker. Video of the fix in action: https://drive.google.com/file/d/0B4g_WskzVRJdVUtMdjJqVlliQ0U/view?usp=sharing This is a third attempt at fixing this issue. The first one was reverted due to failures in ios_showcase_egtests on smaller devices. Those failures were caused by the fact that some elements were off-screen, and EarlGrey was unable to select them. The second one was also reverted due to failures on iPhone 5s with iOS 9.0. Bug: 767154 Change-Id: Ia5cb29dd719ab58311db9122ef7e41c0771200d2 Reviewed-on: https://chromium-review.googlesource.com/678020 Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Marc-Antoine Courteau <macourteau@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#503771} Reviewed-on: https://chromium-review.googlesource.com/682395 Cr-Commit-Position: refs/heads/master@{#504266} [modify] https://crrev.com/510f15126cb04f8d13da79122bbfe33f485956a1/ios/chrome/browser/ui/payments/BUILD.gn [modify] https://crrev.com/510f15126cb04f8d13da79122bbfe33f485956a1/ios/chrome/browser/ui/payments/address_edit_coordinator.mm [modify] https://crrev.com/510f15126cb04f8d13da79122bbfe33f485956a1/ios/chrome/browser/ui/payments/country_selection_coordinator.h [modify] https://crrev.com/510f15126cb04f8d13da79122bbfe33f485956a1/ios/chrome/browser/ui/payments/country_selection_coordinator.mm [modify] https://crrev.com/510f15126cb04f8d13da79122bbfe33f485956a1/ios/chrome/browser/ui/payments/payment_request_picker_view_controller.h [modify] https://crrev.com/510f15126cb04f8d13da79122bbfe33f485956a1/ios/chrome/browser/ui/payments/payment_request_picker_view_controller.mm [modify] https://crrev.com/510f15126cb04f8d13da79122bbfe33f485956a1/ios/showcase/payments/sc_payments_picker_egtest.mm
,
Sep 27 2017
Verified in 63.0.3225.0 Canary, iPhone 6 plus iOS 10.3.3, iPhone 7 iOS11, iPad Pro iOS11 Navigation bar to the country picker is added.
,
Sep 27 2017
,
Sep 27 2017
,
Sep 27 2017
+cmasso@ Re:Merge-Review-62
,
Sep 27 2017
,
Sep 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/142aff0e9a4bdfffef50f91e862b2025faeccad0 commit 142aff0e9a4bdfffef50f91e862b2025faeccad0 Author: Marc-Antoine Courteau <macourteau@chromium.org> Date: Wed Sep 27 18:38:50 2017 [Payment Request] Adds a navigation bar to the country picker. Video of the fix in action: https://drive.google.com/file/d/0B4g_WskzVRJdQUVjLUE2RWRWREE/view?usp=sharing This is a second attempt at fixing this issue. The first one was reverted due to failures in ios_showcase_egtests on smaller devices. Those failures were caused by the fact that some elements were off-screen, and EarlGrey was unable to select them. Bug: 767154 Change-Id: I60df99bf12a0a0858c900faa6544bf562667eda8 Reviewed-on: https://chromium-review.googlesource.com/678020 Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Marc-Antoine Courteau <macourteau@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#503771}(cherry picked from commit 266e6ebd419359717c8d6aadf9311717765883f7) Reviewed-on: https://chromium-review.googlesource.com/687875 Reviewed-by: Marc-Antoine Courteau <macourteau@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#475} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/142aff0e9a4bdfffef50f91e862b2025faeccad0/ios/chrome/browser/ui/payments/BUILD.gn [modify] https://crrev.com/142aff0e9a4bdfffef50f91e862b2025faeccad0/ios/chrome/browser/ui/payments/country_selection_coordinator.mm [modify] https://crrev.com/142aff0e9a4bdfffef50f91e862b2025faeccad0/ios/chrome/browser/ui/payments/payment_request_picker_view_controller.h [modify] https://crrev.com/142aff0e9a4bdfffef50f91e862b2025faeccad0/ios/chrome/browser/ui/payments/payment_request_picker_view_controller.mm [modify] https://crrev.com/142aff0e9a4bdfffef50f91e862b2025faeccad0/ios/showcase/payments/sc_payments_picker_egtest.mm
,
Sep 28 2017
Verified in 62.03202.39 beta, iPhone 6 plus iOS 10.3.3, iPhone 7 iOS11, iPad Pro iOS11 Navigation bar to the country picker is added. Looks good
,
Sep 28 2017
Issue 762531 has been merged into this issue. |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by bugdroid1@chromium.org
, Sep 21 2017