New issue
Advanced search Search tips

Issue 767147 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

[CRD iOS] Layout problems in iPhone X

Project Member Reported by yuweih@chromium.org, Sep 20 2017

Issue description

The app should respect to the safe area of iPhone X.
 
Simulator Screen Shot - iPhone X - 2017-09-20 at 11.31.55.png
134 KB View Download
Simulator Screen Shot - iPhone X - 2017-09-20 at 11.31.39.png
182 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0eeaef33c44f9b3441de12461cb34c558663f77

commit c0eeaef33c44f9b3441de12461cb34c558663f77
Author: Yuwei Huang <yuweih@chromium.org>
Date: Fri Sep 22 21:51:09 2017

[CRD iOS] Make the app respect to safe area

This CL makes the app respect to the safe area of the phone, i.e.
dealing with iPhone X's unibrow...

This CL:
* Makes host list and setup instructions adjust position for the safe
area.
* Makes host view adjust bounds for safe area.

Screenshots:
https://drive.google.com/a/chromium.org/file/d/0BytzIZKeM8nBRzNvVzNadUxCbEk/view?usp=sharing
https://drive.google.com/a/chromium.org/file/d/0BytzIZKeM8nBLVNJS2VCUS1VVXM/view?usp=sharing

Bug:  767147 
Change-Id: Ifbe689c5e8fa670b4b44788390c2d1f654807133
Reviewed-on: https://chromium-review.googlesource.com/676270
Reviewed-by: Scott Nichols <nicholss@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503868}
[modify] https://crrev.com/c0eeaef33c44f9b3441de12461cb34c558663f77/remoting/ios/app/BUILD.gn
[modify] https://crrev.com/c0eeaef33c44f9b3441de12461cb34c558663f77/remoting/ios/app/app_delegate.mm
[modify] https://crrev.com/c0eeaef33c44f9b3441de12461cb34c558663f77/remoting/ios/app/host_collection_header_view.mm
[modify] https://crrev.com/c0eeaef33c44f9b3441de12461cb34c558663f77/remoting/ios/app/host_collection_view_cell.mm
[modify] https://crrev.com/c0eeaef33c44f9b3441de12461cb34c558663f77/remoting/ios/app/host_setup_header_view.mm
[modify] https://crrev.com/c0eeaef33c44f9b3441de12461cb34c558663f77/remoting/ios/app/host_setup_view_cell.mm
[modify] https://crrev.com/c0eeaef33c44f9b3441de12461cb34c558663f77/remoting/ios/app/host_view_controller.mm
[add] https://crrev.com/c0eeaef33c44f9b3441de12461cb34c558663f77/remoting/ios/app/view_utils.h
[add] https://crrev.com/c0eeaef33c44f9b3441de12461cb34c558663f77/remoting/ios/app/view_utils.mm

Comment 2 by yuweih@chromium.org, Oct 30 2017

Status: Fixed (was: Assigned)
Both MDC and GoogleKit have done some further fixes for safe area. The app should be 100% iPhone X compatible now.

Sign in to add a comment