Button edits |
||||||
Issue descriptionApplies to "Show all" and "Discard" - text size should be 12pt, not 13pt. See text-size.png - corner-radii looks too sharp @1x compared to Harmony buttons. See corner-radii.png - Sentence case strings: "Show all" not "Show All"
,
Sep 20 2017
> - Sentence case strings: "Show all" not "Show All" The Apple HIG specifies title case — I thought we were doing that for Harmony on Mac. Is that still true? (https://developer.apple.com/macos/human-interface-guidelines/buttons/push-buttons/)
,
Sep 21 2017
> The Apple HIG specifies title case — I thought we were doing that for Harmony on Mac. Is that still true? Correct - the button title should be "Show All"
,
Sep 21 2017
Argh. Brain fart. That is still true, sorry about the mix up. @Sydney: disregard the last bullet point in commment 1 >> - Sentence case strings: "Show all" not "Show All"
,
Oct 6 2017
,
Oct 6 2017
,
Oct 6 2017
,
Oct 6 2017
,
Oct 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d536f27755c6593204c488db2f37d7b3a2029e2e commit d536f27755c6593204c488db2f37d7b3a2029e2e Author: Sidney San Martín <sdy@chromium.org> Date: Mon Oct 16 15:36:06 2017 Adjust Cocoa harmony button font size and corner radius. Bug: 767145 Change-Id: I32e943e71f891fdf63122a74af4d403fbe3c402c Reviewed-on: https://chromium-review.googlesource.com/720216 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#509056} [modify] https://crrev.com/d536f27755c6593204c488db2f37d7b3a2029e2e/chrome/browser/ui/cocoa/harmony_button.mm
,
Nov 4 2017
Done in the above CL, let me know if it still doesn't look right. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bettes@chromium.org
, Sep 20 201735.3 KB
35.3 KB View Download
81.2 KB
81.2 KB View Download