New issue
Advanced search Search tips

Issue 767141 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

window["1"] = 1 is a no-op

Reported by brachb...@gmail.com, Sep 20 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.113 Safari/537.36

Steps to reproduce the problem:
In the dev console, enter:

window["1"] = 1;

then

window["1"];

What is the expected behavior?
returns 1

What went wrong?
returns undefined

Did this work before? Yes Not sure, but worked in production Android System Webview until ~ one month ago

Does this work in other browsers? No
 Same behavior in Firefox

Chrome version: 60.0.3112.113  Channel: stable
OS Version: OS X 10.12.6
Flash Version: 

JTBC this is true for any key on the window that's just a string of a number.

our app (https://play.google.com/store/apps/details?id=com.makewonder.blockly&hl=en) relied on this working, and when it broke in the Android System Webview, it totally broke our app.

We're rolling out a fix but wanted to help resolve the underlying issue.

I don't have a strong view on whether you SHOULD be able to do window["1"] = 1, but the fact that you could before and can't now breaks existing apps that rely on it.
 
window numerical key bug repro
264 bytes View Download
Components: Blink>Bindings Blink>DOM
Labels: -Pri-2 hasbisect-per-revision M-63 Needs-Milestone OS-Linux OS-Windows Pri-1
Owner: yukishiino@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Windows 10, Ubuntu 14.04 and Mac 10.12.6 using chrome stable version #61.0.3163.91 and latest canary #63.0.3220.0.

Bisect Information:
=====================
Good build: 60.0.3073.0	 Revision(464873)
Bad Build : 60.0.3074.0	 Revision(465085)

Change Log URL: 
https://chromium.googlesource.com/chromium/src/+log/782c68372ded66d885ebd848bace62d639998dfc..c105f1574d48e229385fbef9293aca66fc087f9b

From the above change log suspecting below change
Review URL: https://codereview.chromium.org/2816743002

yukishiino@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks...!!

Comment 2 by hayato@chromium.org, Sep 21 2017

Components: -Blink>DOM
Labels: -Pri-1 Pri-2
Status: WontFix (was: Assigned)
This is an intentional fix.  Indexed properties on WindowProxy is NOT writable.  We're now following the spec.

Sign in to add a comment