New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 767117 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Size of pdf icon and file icons are different

Project Member Reported by bettes@chromium.org, Sep 20 2017

Issue description

From syd:

"It looks like it's just Chrome's icons that are a different size (in this case, because the PDF is set to open with Chrome). I took a quick look at the ICNS files provided by Chrome and Safari for .html files, and they contain different sizes — who can look into that?"
 
Screen Shot 2017-09-20 at 11.03.26 AM.png
26.5 KB View Download

Comment 1 by bettes@chromium.org, Sep 20 2017

Status: Available (was: Untriaged)
If this is just an asset swap, let me know

Comment 2 by bettes@chromium.org, Sep 23 2017

Blockedon: -767116
No component set - is this a bug with the download shelf?

Comment 4 by sdy@chromium.org, Sep 27 2017

Cc: helenepark@chromium.org sdy@chromium.org bettes@chromium.org
Components: UI>Browser>Downloads Design
Labels: -Pri-3 M-63 OS-Mac Pri-2
thestig@: Yes, changed.

bettes@/helenepark@: Like we discussed, I suspect that this is because Chrome provides a different set of icon sizes from other Mac apps.

If I open this file in Preview:

    /Applications/TextEdit.app/Contents/Resources/rtf.icns

…and then Get Info on it, I can see that it contains assets at these sizes:

    512x512@2x
    512x512@1x
    256x256@2x
    256x256@1x
    128x128@2x
    128x128@1x
    64x64@2x
    64x64@1x
    32x32@2x
    32x32@1x
    16x16@2x
    16x16@1x

If I open an icon from Chrome:

    /Applications/Google\ Chrome.app/Contents/Resources/document.icns

…it has these sizes:

    512x512@1x
    256x256@1x
    128x128@1x
    32x32@1x
    16x16@1x

Notably, there are no 2x sizes and no 64x64 size. I'm not sure how we make icons normally, but we mainly just need PNGs of the right sizes.

It might also be a good idea to do this for the app icon.

Comment 5 by sdy@chromium.org, Sep 27 2017

Er, to answer bettes@' question more directly, yes, this is just an asset swap.
Project Member

Comment 6 by sheriffbot@chromium.org, Sep 28

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Available (was: Untriaged)

Sign in to add a comment