Issue metadata
Sign in to add a comment
|
Page Info "Site Settings" button is misaligned on Cocoa when a site has no permissions |
||||||||||||||||||||||||
Issue descriptionChrome 63.0.3221.0 macOS 10.12.6 What steps will reproduce the problem? (1) Open Page Info on a site with no permissions. What is the expected result? Nice spacing. What happens instead? SMALLER PAGE INFO!!!111 😃 Smoosh (see screenshot). 😔 patricialor@, could you take this on?
,
Sep 21 2017
Issue 767320 has been merged into this issue.
,
Sep 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e186d66e32393d838416bf8f0d873cb276ffecdc commit e186d66e32393d838416bf8f0d873cb276ffecdc Author: Patricia Lor <patricialor@chromium.org> Date: Fri Sep 22 03:54:41 2017 Mac/Desktop Page Info: Fix spacing when no permissions to show. The Page Info bubble on macOS currently only adds padding after the cookies UI if there are any permissions to be shown. This was fine because Page Info would show a set list of permissions always. r503089 updated Page Info to only show non-factory-default permissions, which meant there was no padding added on sites without non-default permissions. Fix by adding the padding always. Bug: 767115 Change-Id: Ia3e6451c8631c9b26c84ff7aa3c79ec330303a33 Reviewed-on: https://chromium-review.googlesource.com/676543 Reviewed-by: Lucas Garron <lgarron@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#503653} [modify] https://crrev.com/e186d66e32393d838416bf8f0d873cb276ffecdc/chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.mm
,
Sep 22 2017
,
Sep 26 2017
Verified this issue on Mac OS 10.12.6 using chrome latest dev #63.0.3223.8, Observed that nice spacing for site settings button. Hence adding TE-Verified label. Please find the screen shot for reference. Thanks! |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by lgar...@chromium.org
, Sep 20 2017