New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 767095 link

Starred by 1 user
Status: Fixed
Owner:
gambard@chromium.org
Closed: Sep 2017
Cc:
█ cma...@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

NTPTestCase is failing

Project Member Reported by liaoyuke@chromium.org, Sep 20 2017 
There are two separate issues:

1. NTPTestCase has been flaky for the past few weeks, and the pattern is that it always fails on the first test run, but succeeds when retry.

https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ipad10-simulator/builds/7599
https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ipad10-simulator-x64/builds/7555
https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ipad9-simulator/builds/13872

2. This change: https://chromium-review.googlesource.com/671019, made NTPTestCase failing constantly on iOS 11 iPad Air.

https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ipad11-simulator-x64/builds/782
https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ipad11-simulator-x64/builds/781

So, I'm disabling them on all iOS versions.

I debugged a little bit, and made sure it's not a synchronization issue because I tried to add delays everywhere, but there is no way I can see the promotions.

Gauthier, please take a look and re-enable these tests.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4626d1f61c22b10a508448de6fb5f2355bc78d78

commit 4626d1f61c22b10a508448de6fb5f2355bc78d78
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Wed Sep 20 18:07:01 2017

Disable a few tests in NTPHomeTestCase

These tests are flaky on all iOS versions and are failing constantly
on iOS 11.

TBR=gambard@chromium.org

Bug:  767095 
Change-Id: Iba5d82a2dce53382c1b54dc7c3f6b9f738c4356b
Reviewed-on: https://chromium-review.googlesource.com/675766
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503197}
[modify] https://crrev.com/4626d1f61c22b10a508448de6fb5f2355bc78d78/ios/chrome/browser/ui/content_suggestions/ntp_home_egtest.mm
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6751a051ab95b6e7a5ae9e6de3ac7d87af71bb3a

commit 6751a051ab95b6e7a5ae9e6de3ac7d87af71bb3a
Author: Gauthier Ambard <gambard@chromium.org>
Date: Thu Sep 21 09:27:08 2017

Reenable NTPTestCase

The test were failing because the NTP was displaying the Bookmarks
panel. This CL fixes it by making sure we are on the Home panel.

Bug:  767095 
Change-Id: Iec7d84172edc7879382410626f1fce1dbbc3079d
Reviewed-on: https://chromium-review.googlesource.com/676851
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503398}
[modify] https://crrev.com/6751a051ab95b6e7a5ae9e6de3ac7d87af71bb3a/ios/chrome/browser/ui/content_suggestions/content_suggestions_egtest.mm
[modify] https://crrev.com/6751a051ab95b6e7a5ae9e6de3ac7d87af71bb3a/ios/chrome/browser/ui/content_suggestions/ntp_home_egtest.mm

Comment 3 by gambard@chromium.org, Sep 21 2017

Status: Fixed (was: Assigned)

Comment 4 by dpranke@chromium.org, Jan 24 2018

Components: Tests>Disabled
Labels: Test-Disabled
►

Sign in to add a comment