Fix WebStateObserver::DidStartLoading/DidStopLoading callbacks |
|||||||||
Issue descriptionProblem: DidStartLoading is called when request is registered, not when loading has actually started. Also these callbacks are called for same document navigations. Solution: DidStartLoading should be replaced with DidRegisterLoadRequest, which will allow to preserve the current login for PageLoad counts. DidStartLoading/DidStopLoading callbacks should reflect WKWebView.loading changes, and used only for network activity indicator.
,
Nov 7 2017
Also DidStartLoading/DidStopLoading should not be called for same-document navigations.
,
Nov 8 2017
,
Nov 9 2017
,
Nov 29 2017
,
Dec 1 2017
Document a bit more context from discussion with creis@ and clamy@ regarding dropping DidStartLoading/DidStopLoading for same-document navigations: The reason [WebContentObserver's] DidStart/StopLoading was called for same-document navigations is mostly historical: we did not have the DidStart/FinishNavigation callbacks early on. However, nowadays they should be the preferred way of being notified about navigation events. DidStart/StopLoading should be used to notify about the throbber and the loading progress, and it makes no sense to start the throbber on a same-document navigation (especially since the the DidStartLoading will be followed immediately by a DidStopLoading).
,
Jul 20
,
Oct 17
,
Oct 26
,
Oct 26
,
Oct 26
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by eugene...@chromium.org
, Sep 20 2017