New issue
Advanced search Search tips

Issue 767088 link

Starred by 2 users
Status: Fixed
Owner:
smbar...@chromium.org
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

libbrillo: add ability to redirect input for Process

Project Member Reported by smbar...@chromium.org, Sep 20 2017 
We should be able to redirect input for libbrillo Processes in addition to output.

Context: crosvm sets stdin to raw mode for its serial console. This is annoying when we're trying to run crosvm in headless mode, and it inherits stdin from vm_launcher.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/external/libbrillo/+/84b910fe90e91ef14e6ddec7c7f0a869e1ae5ec6

commit 84b910fe90e91ef14e6ddec7c7f0a869e1ae5ec6
Author: Stephen Barber <smbarber@chromium.org>
Date: Sat Sep 23 00:55:28 2017

libbrillo: allow redirecting process input

Add a RedirectInput method to Process that allows redirecting
stdin to read from a file.

BUG= chromium:767088 
TEST=unittests

Change-Id: Id3d440048792a9c89e1ffb3b59ba26f888191678
Reviewed-on: https://chromium-review.googlesource.com/673355
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/84b910fe90e91ef14e6ddec7c7f0a869e1ae5ec6/brillo/process_mock.h
[modify] https://crrev.com/84b910fe90e91ef14e6ddec7c7f0a869e1ae5ec6/brillo/process_unittest.cc
[modify] https://crrev.com/84b910fe90e91ef14e6ddec7c7f0a869e1ae5ec6/brillo/process.h
[modify] https://crrev.com/84b910fe90e91ef14e6ddec7c7f0a869e1ae5ec6/brillo/process.cc

Comment 2 by smbar...@chromium.org, Sep 23 2017

Status: Fixed (was: Started)

Comment 3 by vapier@chromium.org, May 9 2018

Components: OS>Systems>Containers
►

Sign in to add a comment