New issue
Advanced search Search tips

Issue 767087 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 602859
issue 766783



Sign in to add a comment

mash: Expand mojo struct traits for gesture events.

Project Member Reported by msw@chromium.org, Sep 20 2017

Issue description

mash: Add mojo struct traits for gesture events.

Currently, ui::mojom::EventType only supports key and pointer events.
This is blocking  Issue 766783  and may be a prerequisite for  Issue 571688 .
(Ash passes gesture events to Chrome for shelf item selection via touch)
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6715a07436e4d17126c3d5d3c9775d53d025a8ba

commit 6715a07436e4d17126c3d5d3c9775d53d025a8ba
Author: Mike Wasserman <msw@chromium.org>
Date: Thu Sep 21 18:20:25 2017

mash: Support shelf item selection via ET_GESTURE_TAP.

Add basic Mojo struct traits support & test for tap gestures.
(this is the minimum needed for tapping on shelf items)

Warn and bail on sending unsupported event types.
(otherwise it's tough to track these problems down)

Bug:  766783 , 767087
Test: Chrome OS shelf items launch via touch w/ about:flags Enable shelf model synchronization"
Change-Id: I2aa813be94ce321897838c2e62de5d3097ac04ca
Reviewed-on: https://chromium-review.googlesource.com/675581
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503514}
[modify] https://crrev.com/6715a07436e4d17126c3d5d3c9775d53d025a8ba/ui/events/mojo/event.mojom
[modify] https://crrev.com/6715a07436e4d17126c3d5d3c9775d53d025a8ba/ui/events/mojo/event_constants.mojom
[modify] https://crrev.com/6715a07436e4d17126c3d5d3c9775d53d025a8ba/ui/events/mojo/event_struct_traits.cc
[modify] https://crrev.com/6715a07436e4d17126c3d5d3c9775d53d025a8ba/ui/events/mojo/event_struct_traits.h
[modify] https://crrev.com/6715a07436e4d17126c3d5d3c9775d53d025a8ba/ui/events/mojo/struct_traits_unittest.cc

Comment 2 by msw@chromium.org, Sep 21 2017

Cc: rjkroege@chromium.org msw@chromium.org
Owner: ----
Status: Available (was: Started)
Summary: mash: Expand mojo struct traits for gesture events. (was: mash: Add mojo struct traits for gesture events.)
My use case is satisfied with ET_GESTURE_TAP; re-targeting for other gesture events.

Comment 3 by msw@chromium.org, Feb 22 2018

Blocking: 602859
Components: -Internals>MUS Internals>Services>WindowService
Components: -MUS
Components: -Internals>Services>WindowService Internals>Services>Ash
Labels: -Proj-Mustash-Mash
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9fcc0de1c33c4634e68b3e2a76560e4dc35f56f0

commit 9fcc0de1c33c4634e68b3e2a76560e4dc35f56f0
Author: Kevin McNee <mcnee@chromium.org>
Date: Mon Jan 07 21:35:36 2019

Serialize touchpad pinch ui::Events

We extend the mojo struct traits for ui gesture events enough to allow
for touchpad pinch events to be serialized.

Bug: 767087, 916946
Change-Id: Ic572704a78da71c262e8e892c3023c2f5b29779d
Reviewed-on: https://chromium-review.googlesource.com/c/1394996
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620480}
[modify] https://crrev.com/9fcc0de1c33c4634e68b3e2a76560e4dc35f56f0/ui/events/mojo/event.mojom
[modify] https://crrev.com/9fcc0de1c33c4634e68b3e2a76560e4dc35f56f0/ui/events/mojo/event.typemap
[modify] https://crrev.com/9fcc0de1c33c4634e68b3e2a76560e4dc35f56f0/ui/events/mojo/event_constants.mojom
[modify] https://crrev.com/9fcc0de1c33c4634e68b3e2a76560e4dc35f56f0/ui/events/mojo/event_struct_traits.cc
[modify] https://crrev.com/9fcc0de1c33c4634e68b3e2a76560e4dc35f56f0/ui/events/mojo/event_struct_traits.h
[modify] https://crrev.com/9fcc0de1c33c4634e68b3e2a76560e4dc35f56f0/ui/events/mojo/struct_traits_unittest.cc

Sign in to add a comment