New issue
Advanced search Search tips

Issue 767083 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

factory: Remove Goofy Presenter

Project Member Reported by hungte@chromium.org, Sep 20 2017

Issue description

It is more difficult to maintain Chrome running properly for starting Goofy in monolithic and presenter mode. Also, the station based test is the right future (with modular goofy) that it's probably time to abandon the Goofy Presenter design.
 
Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/435c6ff70d31c515abff0114fbe2e3987cf58d27

commit 435c6ff70d31c515abff0114fbe2e3987cf58d27
Author: Hung-Te Lin <hungte@chromium.org>
Date: Thu Sep 21 18:54:23 2017

init: Flatten 'goofy.d' role directories.

After presenter is removed, there's no need to create role specific
folders in `goofy.d`, and flattening the folder will make it easier to
maintain.

Also changed the 'device_id' folder to a more meaningful name -
`device_id_changed`.

[Migration notes]
On ToT, no boards are putting files in device/jailbreak so it's OK to
move the folder. Few boards put scripts in device/device_id but the new
device_id_changed folder already contains all scripts that board
overlays has provided, so it's fine to not running scripts in old path.

BUG= chromium:767083 
TEST=make test

Change-Id: Ief437e9b12b908d18a0511b575e1be0ba7c81d65
Reviewed-on: https://chromium-review.googlesource.com/675624
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[rename] https://crrev.com/435c6ff70d31c515abff0114fbe2e3987cf58d27/init/goofy.d/setup_chrome.sh
[delete] https://crrev.com/fc162e6afa03986143757e426873e5efc8941d78/init/goofy.d/device/device_id/README.md
[modify] https://crrev.com/435c6ff70d31c515abff0114fbe2e3987cf58d27/init/startup
[rename] https://crrev.com/435c6ff70d31c515abff0114fbe2e3987cf58d27/init/goofy.d/select_default_test_list.sh
[add] https://crrev.com/435c6ff70d31c515abff0114fbe2e3987cf58d27/init/goofy.d/device_id_changed/README.md
[rename] https://crrev.com/435c6ff70d31c515abff0114fbe2e3987cf58d27/init/goofy.d/chrome_dev.conf
[rename] https://crrev.com/435c6ff70d31c515abff0114fbe2e3987cf58d27/init/goofy.d/ghost.sh
[rename] https://crrev.com/435c6ff70d31c515abff0114fbe2e3987cf58d27/init/goofy.d/crbug_410233_tpm.sh
[rename] https://crrev.com/435c6ff70d31c515abff0114fbe2e3987cf58d27/init/goofy.d/jailbreak/minijail0
[rename] https://crrev.com/435c6ff70d31c515abff0114fbe2e3987cf58d27/init/goofy.d/device_id_changed/reset_test_results.sh
[rename] https://crrev.com/435c6ff70d31c515abff0114fbe2e3987cf58d27/init/goofy.d/device_id_changed/cr50-cache.sh
[rename] https://crrev.com/435c6ff70d31c515abff0114fbe2e3987cf58d27/init/common.d/sshkeys_filemode.sh
[rename] https://crrev.com/435c6ff70d31c515abff0114fbe2e3987cf58d27/init/goofy.d/device_id.sh
[rename] https://crrev.com/435c6ff70d31c515abff0114fbe2e3987cf58d27/init/goofy.d/jailbreak.sh

Comment 3 by hungte@chromium.org, Sep 21 2017

Owner: hungte@chromium.org
Status: Fixed (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/baed37b3d765223a3bdcc89f69415054a6027a17

commit baed37b3d765223a3bdcc89f69415054a6027a17
Author: Shen-En Shih <petershih@chromium.org>
Date: Wed Oct 18 10:30:05 2017

init: More clean up on goofy roles

After presenter mode is deprecated, no role specific init rules. This
is a followed-up to CL:675624 for more clean up.

BUG= chromium:767083 
TEST=make test

Change-Id: I36959de9ff5a8fa644b6565864b4edb0f434f93b
Reviewed-on: https://chromium-review.googlesource.com/724762
Commit-Ready: Shen-En Shih <petershih@chromium.org>
Tested-by: Shen-En Shih <petershih@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/baed37b3d765223a3bdcc89f69415054a6027a17/init/startup

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/5cc66a421d215672fce8aec1f5cd975024d875fd

commit 5cc66a421d215672fce8aec1f5cd975024d875fd
Author: Shen-En Shih <petershih@chromium.org>
Date: Wed Oct 18 13:15:06 2017

init: Remove ports for presenter mode

These ports are not used anymore after presenter mode is deprecated.

BUG= chromium:767083 
TEST=make test

Change-Id: I11d84cdadf0c6fc41b86657ff35b2ddd501c03a8
Reviewed-on: https://chromium-review.googlesource.com/725024
Commit-Ready: Shen-En Shih <petershih@chromium.org>
Tested-by: Shen-En Shih <petershih@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/5cc66a421d215672fce8aec1f5cd975024d875fd/init/iptables.d/goofy_ports.sh

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/a452d4dcd325790407702158c980ad04f2c621b3

commit a452d4dcd325790407702158c980ad04f2c621b3
Author: Hung-Te Lin <hungte@chromium.org>
Date: Mon Oct 30 15:23:32 2017

goofy: Merge goofy_base and goofy.

The presenter has been removed so there's no need to keep goofy_base.

BUG= chromium:767083 
TEST=make test

Change-Id: I940bd17abbcdd7091e6e579f4f23c6c092217118
Reviewed-on: https://chromium-review.googlesource.com/737891
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Pi-Hsun Shih <pihsun@chromium.org>

[modify] https://crrev.com/a452d4dcd325790407702158c980ad04f2c621b3/py/goofy/goofy.py
[delete] https://crrev.com/1fb8b5324c30b201107d55324de282896732ce15/py/goofy/goofy_base.py
[delete] https://crrev.com/1fb8b5324c30b201107d55324de282896732ce15/py/goofy/goofy_base_unittest.py

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 9 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment