xref: bug 650926

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/600948dc9fa810fb3f41964a903d54299ea011b2

commit 600948dc9fa810fb3f41964a903d54299ea011b2
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Sep 20 18:06:17 2017

fuchsia: Disable new ProcessTest tests until fixed

Bug:  767082 
Change-Id: Ic607d3b2cc2b90dfd2b095a0a76eff9bc2121a68
TBR: wez@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/675566
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503196}
[modify] https://crrev.com/600948dc9fa810fb3f41964a903d54299ea011b2/testing/buildbot/filters/fuchsia.base_unittests.filter

Scott, thanks for let me know.

After my change, Process::WaitForExtiWithTimeout() should support,
1. waiting for current process. It should immediately return false.
  - This is straightforward, changing (https://cs.chromium.org/chromium/src/base/process/process_fuchsia.cc?rcl=cc8362b453ba41cd03f289e17e022eb6353e6946&l=156) from DCHECK() to if-return should be sufficient.
2. timeout can be 0.
  - process_fuchsia.cc seems handling this scenario well.

process_fuchsia.cc failed to handle the nullptr |exit_code|.
https://cs.chromium.org/chromium/src/base/process/process_fuchsia.cc?rcl=cc8362b453ba41cd03f289e17e022eb6353e6946&l=177
But |exit_code| should be optional (https://cs.chromium.org/chromium/src/base/process/process.h?rcl=d38e915a308edf4584fd89329c34110d38b5d1e1&l=135).
The fix should also be straightforward.

But I have no idea how to test the changes on fuchsia. Please let me know if you would prefer me to fix it.

Thanks for the pointers, posted https://chromium-review.googlesource.com/c/chromium/src/+/678098 to fix on Fuchsia.

For the record in case you ever want to build for Fuchsia it's fairly straightforward (especially if you already have a Linux build set up): https://chromium.googlesource.com/chromium/src/+/master/docs/fuchsia_build_instructions.md

Thank you for the information, I thought we need a fuchsia environment to execute all the tests.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62ddfd4155c834c257471d0586f30faf8dabab2c

commit 62ddfd4155c834c257471d0586f30faf8dabab2c
Author: Scott Graham <scottmg@chromium.org>
Date: Fri Sep 22 22:42:39 2017

fuchsia: Make new ProcessTest tests work

Bug:  767082 
Change-Id: Ie65dcb11212294e85c561d0788ece25ec776dcc7
Reviewed-on: https://chromium-review.googlesource.com/678098
Reviewed-by: Zijie He <zijiehe@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503888}
[modify] https://crrev.com/62ddfd4155c834c257471d0586f30faf8dabab2c/base/process/process_fuchsia.cc
[modify] https://crrev.com/62ddfd4155c834c257471d0586f30faf8dabab2c/testing/buildbot/filters/fuchsia.base_unittests.filter