New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 767041 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Selected bookmarks gets unselected on swiping the bookmarks up or down.

Project Member Reported by pmadalla@chromium.org, Sep 20 2017

Issue description

App Version: 63.0.3219.0 canary
iOS Version:11.0
Device : iPhone 7+
URL: Chrome Settings -- Bookmarks

Precondition :
1.Go to chrome://flags --> Bookmark New Generation iOS : Enabled
2.Have few folders or bookmarks saved with long name.

Steps to reproduce:
1. Launch chrome 
2. Tap on Bookmarks icon > Tap on Mobile bookmarks.
3. Tap on Select at the bottom.
4. Select few bookmarks.
5. Use Swipe to move the bookmarks position. 

Observed results:
Selected bookmarks gets unselected 

Expected results:
Selected bookmarks should not be unselected.

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: NA
Bug reproducible on Dolphin/Safari/Firefox: NA
Bug reproducible on current stable build (App Version, iOS Version): NA,New UI Change in M61
Bug reproducible on the current beta channel build (App Version, iOS Version): NA,New UI Change in M62

Link to video :
https://drive.google.com/a/google.com/file/d/0B--UpU2GW2EpeGhyTXA4VjQ2RkU/view?usp=sharing

 
Cc: ramyasharma@chromium.org
Labels: -Pri-2 ReleaseBlock-Stable M-63 Pri-1
Owner: martiw@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by gracec@chromium.org, Sep 22 2017

Cc: gracec@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9af439c6acb4bc23e99968f0b43269c47f48c54

commit b9af439c6acb4bc23e99968f0b43269c47f48c54
Author: Marti Wong <martiw@chromium.org>
Date: Tue Oct 10 01:14:16 2017

Restore row selection after reordering of row(s) (New iOS bookmark ui)

Prevent the row selection from being cleared up after reordering of
bookmark(s) in selection mode.

Bug:  767041 
Change-Id: Ie0c3ede0d2009ff1006598047e5931cbaabf4293
Reviewed-on: https://chromium-review.googlesource.com/706750
Commit-Queue: Marti Wong <martiw@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507562}
[modify] https://crrev.com/b9af439c6acb4bc23e99968f0b43269c47f48c54/ios/chrome/browser/ui/bookmarks/bookmark_table_view.mm
[modify] https://crrev.com/b9af439c6acb4bc23e99968f0b43269c47f48c54/ios/chrome/browser/ui/bookmarks/bookmarks_new_generation_egtest.mm

Comment 5 by martiw@chromium.org, Oct 10 2017

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified in:

App Version: 63.0.3239.58
Devices: iPhone 7, iPhone 8 Plus, iPad Mini
iOS Versions: 10.3.3, 11.2 beta 3

Issue is fixed. Bookmarks selected for reordering remains in selection  mode.

Sign in to add a comment