New issue
Advanced search Search tips

Issue 767035 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task

Blocking:
issue 725019



Sign in to add a comment

Create tests ensuring that apps using proguard or package renaming tools don't break the WebView Support Library.

Project Member Reported by gsennton@chromium.org, Sep 20 2017

Issue description

Renaming of classes in the support library might affect the way we are communicating between the support library and the glue layer - we could easily happen to rely on the name of some support library class.

So we should create some tests to ensure this doesn't happen.

Note: we should probably also ensure we aren't broken if the classes in the WebView APK are renamed.
 
We should ensure we can produce a prototype that isn't broken by a test like this
Blocking: 765118
We should ensure that using proguard for the WebView APK doesn't break our support library either, though we would run into this issue anyway as soon as we try to use a release-version of WebView with the support library.
Blocking: -765118
This bug is just for adding tests - we know how we want to deal with Proguard (namely having specific proguard configurations ensuring we keep the names of specific support library interfaces, so these interfaces are the same in the glue-layer as in the support library).
The best way of testing this is probably
1. Take a proguarded WebView APK (e.g. a release-built WebView) and install it on a device.
2. Proguard the WebViewCompat tests in the support library, and run the proguarded tests on a device with the proguarded WebView APK

Ensure there are no crashes.
Owner: ntfschr@chromium.org
Status: WontFix (was: Available)
Closing in favor of http://b/74181771

Sign in to add a comment