New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 767030 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

New bookmarks UI bottom toolbar is not respecting the safe area on iPhone X

Project Member Reported by gambard@chromium.org, Sep 20 2017

Issue description

iPhone X only

What steps will reproduce the problem?
(1) Enable the new suggestions UI in chrome://flags
(2) Open the bookmarks 

What is the expected result?
The bottom toolbar should respect the safe area.

What happens instead?
The bottom toolbar is not respecting the safe area.
 
Simulator Screen Shot - iPhone X - 2017-09-20 at 15.55.47.png
91.0 KB View Download

Comment 1 by pkl@chromium.org, Sep 20 2017

Labels: M-63
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/475f70e34a4815f1630501f2ee4e57e6a8060272

commit 475f70e34a4815f1630501f2ee4e57e6a8060272
Author: Gauthier Ambard <gambard@chromium.org>
Date: Thu Sep 21 09:24:55 2017

Fix Bookmarks bottom toolbar for iPhone X

The bottom toolbar of the bookmarks should respect the safe area.

New behavior:
https://drive.google.com/open?id=0B21N-0pPGAuJbzB3VUNQeXJPcEE
https://drive.google.com/open?id=0B21N-0pPGAuJdWVpcEZWZ1ZJWHc

Bug:  767030 
Change-Id: I4d12848a0ac1f15af7b80612689d795edab367e1
Reviewed-on: https://chromium-review.googlesource.com/675113
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Marti Wong <martiw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503397}
[modify] https://crrev.com/475f70e34a4815f1630501f2ee4e57e6a8060272/ios/chrome/browser/ui/bookmarks/bars/bookmark_context_bar.mm
[modify] https://crrev.com/475f70e34a4815f1630501f2ee4e57e6a8060272/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified in:

App Version: 63.0.3239.53
Device : iPhone X (Simulator)

Issue is fixed. New Bookmarks toolbar is displayed inside safe area.

Sign in to add a comment