New issue
Advanced search Search tips

Issue 767028 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Add "Adding..." toast to new webapk install flow

Project Member Reported by yfried...@chromium.org, Sep 20 2017

Issue description

Per UI-review: https://groups.google.com/a/google.com/forum/?utm_medium=email&utm_source=footer#!msg/chrome-webapks-team/ARzDh_j-ohM/PIw-uzNfBgAJ

Lets' re-use IDS_NOTIFICATION_WEBAPK_INSTALL_IN_PROGRESS to toast once install is initiated.
 

Comment 1 by hanxi@chromium.org, Sep 20 2017

Status: Started (was: Assigned)
toast.mp4
3.8 MB View Download
toast.png
84.5 KB View Download
lgtm
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9c04cd6833e6949a5a5dac709825e05ba36bd19

commit a9c04cd6833e6949a5a5dac709825e05ba36bd19
Author: Xi Han <hanxi@google.com>
Date: Wed Sep 20 16:13:37 2017

Add "Adding..." toast to new webapk install flow.

Bug:  767028 
Change-Id: I2fb57e728c8808019a464c632fead3058a914a49
Reviewed-on: https://chromium-review.googlesource.com/674710
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503171}
[modify] https://crrev.com/a9c04cd6833e6949a5a5dac709825e05ba36bd19/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
[modify] https://crrev.com/a9c04cd6833e6949a5a5dac709825e05ba36bd19/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstallService.java

Labels: Merge-Request-62
Merge rationale: Small UI change (strings already exist) from implementation review
Project Member

Comment 5 by sheriffbot@chromium.org, Sep 20 2017

Labels: -Merge-Request-62 Merge-Review-62 Hotlist-Merge-Review
This bug requires manual review: M62 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-62 Merge-Approved-62
Merge approved for M62 branch 3202.
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 20 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6591afa8b2e50a113563476d1082deba52f3c9d6

commit 6591afa8b2e50a113563476d1082deba52f3c9d6
Author: Xi Han <hanxi@google.com>
Date: Wed Sep 20 18:09:10 2017

Add "Adding..." toast to new webapk install flow.

Bug:  767028 
Change-Id: I2fb57e728c8808019a464c632fead3058a914a49
Reviewed-on: https://chromium-review.googlesource.com/674710
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Xi Han <hanxi@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#503171}(cherry picked from commit a9c04cd6833e6949a5a5dac709825e05ba36bd19)
Reviewed-on: https://chromium-review.googlesource.com/675883
Reviewed-by: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#356}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/6591afa8b2e50a113563476d1082deba52f3c9d6/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
[modify] https://crrev.com/6591afa8b2e50a113563476d1082deba52f3c9d6/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstallService.java

Comment 8 by hanxi@chromium.org, Sep 20 2017

Status: Fixed (was: Started)
Toast message is appearing on installing webapk on latest M63-63.0.3223.7

Comment 10 by hanxi@chromium.org, Sep 26 2017

Thanks for verifying!
Status: Verified (was: Fixed)
Toast message is also appearing on installing webapk on latest M62-62.0.3202.38.

Sign in to add a comment