https://wicg.github.io/shape-detection-api/#face-detection-api using UWP Windows.Media.FaceAnalysis [1] [1] https://docs.microsoft.com/en-us/uwp/api/Windows.Media.FaceAnalysis.FaceDetector
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6dcef657eb061f2eb198f078fbb4246422af191b commit 6dcef657eb061f2eb198f078fbb4246422af191b Author: junweifu <junwei.fu@intel.com> Date: Tue Oct 17 06:21:16 2017 Move common functions to winrt util Shape Detection will use WRL to access Windows Runtime components, wrapped GetActivationFactory, CreateIBufferFromData and GetPointerToBufferData function also need to be used in CL[1], so move these common functions to winrt util. [1] https://chromium-review.googlesource.com/c/chromium/src/+/708336 BUG= 767021 Change-Id: I054e273dc14fea648d1fed444d189ecd5e4292ca Reviewed-on: https://chromium-review.googlesource.com/715656 Commit-Queue: Junwei Fu <junwei.fu@intel.com> Reviewed-by: Scott Graham <scottmg@chromium.org> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#509301} [modify] https://crrev.com/6dcef657eb061f2eb198f078fbb4246422af191b/base/win/core_winrt_util.cc [modify] https://crrev.com/6dcef657eb061f2eb198f078fbb4246422af191b/base/win/core_winrt_util.h [modify] https://crrev.com/6dcef657eb061f2eb198f078fbb4246422af191b/base/win/core_winrt_util_unittest.cc [modify] https://crrev.com/6dcef657eb061f2eb198f078fbb4246422af191b/media/midi/midi_manager_winrt.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/71716930f260e22871135e8657f85f7e383e6dc8 commit 71716930f260e22871135e8657f85f7e383e6dc8 Author: junweifu <junwei.fu@intel.com> Date: Mon Oct 30 02:42:11 2017 ShapeDetection: Start with the minimum Win implementation Load com base functions dynamically at runtime with core_winrt_util. Request face detection failed if it's not supported. Add unittest and make sure work in win10 bots with using win10_chromium_x64_rel_ng in PRESUBMIT.py . Link Face Detection demo[2] here. Split original large CL[1] up in smaller subpatches including this CL. [1] https://chromium-review.googlesource.com/c/chromium/src/+/708336 [2] https://codepen.io/miguelao/pen/PmJWro BUG= 767021 Cq-Include-Trybots: master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ice003ac398379b60e0668c14a7cec75195be0441 Reviewed-on: https://chromium-review.googlesource.com/724745 Commit-Queue: Junwei Fu <junwei.fu@intel.com> Reviewed-by: Miguel Casas <mcasas@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#512433} [modify] https://crrev.com/71716930f260e22871135e8657f85f7e383e6dc8/services/shape_detection/BUILD.gn [modify] https://crrev.com/71716930f260e22871135e8657f85f7e383e6dc8/services/shape_detection/PRESUBMIT.py [add] https://crrev.com/71716930f260e22871135e8657f85f7e383e6dc8/services/shape_detection/face_detection_impl_win.cc [add] https://crrev.com/71716930f260e22871135e8657f85f7e383e6dc8/services/shape_detection/face_detection_impl_win.h [add] https://crrev.com/71716930f260e22871135e8657f85f7e383e6dc8/services/shape_detection/face_detection_impl_win_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7c153bd16db1cffae948a57315df053531a530a commit b7c153bd16db1cffae948a57315df053531a530a Author: junweifu <junwei.fu@intel.com> Date: Fri Nov 03 06:37:09 2017 Move Storage functions to new file winrt_storage_util Windows::Streams::Storage is definitely outside of Core WinRT, core_winrt_util.h is intended for Core WinRT Functions, so move to separate file. BUG= 767021 Change-Id: If42203f7e3a55f1f4d35e955662e682ac37eeceb Reviewed-on: https://chromium-review.googlesource.com/729306 Reviewed-by: Robert Liao <robliao@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Greg Thompson <grt@chromium.org> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Junwei Fu <junwei.fu@intel.com> Cr-Commit-Position: refs/heads/master@{#513713} [modify] https://crrev.com/b7c153bd16db1cffae948a57315df053531a530a/base/BUILD.gn [modify] https://crrev.com/b7c153bd16db1cffae948a57315df053531a530a/base/win/core_winrt_util.cc [modify] https://crrev.com/b7c153bd16db1cffae948a57315df053531a530a/base/win/core_winrt_util.h [modify] https://crrev.com/b7c153bd16db1cffae948a57315df053531a530a/base/win/core_winrt_util_unittest.cc [add] https://crrev.com/b7c153bd16db1cffae948a57315df053531a530a/base/win/winrt_storage_util.cc [add] https://crrev.com/b7c153bd16db1cffae948a57315df053531a530a/base/win/winrt_storage_util.h [add] https://crrev.com/b7c153bd16db1cffae948a57315df053531a530a/base/win/winrt_storage_util_unittest.cc [modify] https://crrev.com/b7c153bd16db1cffae948a57315df053531a530a/media/midi/midi_manager_winrt.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf01c41855bccc2412ffce8e28e37c421905b1b9 commit bf01c41855bccc2412ffce8e28e37c421905b1b9 Author: junweifu <junwei.fu@intel.com> Date: Tue Nov 21 03:32:21 2017 ShapeDetection: Create Face Detector Async on windows 10 Create Face Detector with Face Detector factory that is async. Add a template class represents an asynchronous operation which returns a result upon completion. Expose PauseIncomingMethodCallProcessing method from StrongBinding to prevent FaceDetectionProviderWin from being destroyed before the AsyncOperation completes. Add unittest to test the result of creating face detector. Split original large CL[1] up in smaller subpatches including this CL. Link Face Detection demo[2] here. [1] https://chromium-review.googlesource.com/c/chromium/src/+/708336 [2] https://codepen.io/miguelao/pen/PmJWro BUG= 767021 Cq-Include-Trybots: master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: Id5b19115f10d7c96da191d7421a626741b075266 Reviewed-on: https://chromium-review.googlesource.com/750006 Commit-Queue: Junwei Fu <junwei.fu@intel.com> Reviewed-by: Yuzhu Shen <yzshen@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#518089} [modify] https://crrev.com/bf01c41855bccc2412ffce8e28e37c421905b1b9/mojo/public/cpp/bindings/strong_binding.h [modify] https://crrev.com/bf01c41855bccc2412ffce8e28e37c421905b1b9/services/shape_detection/BUILD.gn [add] https://crrev.com/bf01c41855bccc2412ffce8e28e37c421905b1b9/services/shape_detection/detection_utils_win.h [modify] https://crrev.com/bf01c41855bccc2412ffce8e28e37c421905b1b9/services/shape_detection/face_detection_impl_win.cc [modify] https://crrev.com/bf01c41855bccc2412ffce8e28e37c421905b1b9/services/shape_detection/face_detection_impl_win.h [modify] https://crrev.com/bf01c41855bccc2412ffce8e28e37c421905b1b9/services/shape_detection/face_detection_impl_win_unittest.cc [add] https://crrev.com/bf01c41855bccc2412ffce8e28e37c421905b1b9/services/shape_detection/face_detection_provider_win.cc [add] https://crrev.com/bf01c41855bccc2412ffce8e28e37c421905b1b9/services/shape_detection/face_detection_provider_win.h [modify] https://crrev.com/bf01c41855bccc2412ffce8e28e37c421905b1b9/services/shape_detection/shape_detection_service.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/398adf6b070d1d7150763fe85ce3b06a557f97ba commit 398adf6b070d1d7150763fe85ce3b06a557f97ba Author: junweifu <junwei.fu@intel.com> Date: Wed Dec 13 05:16:29 2017 ShapeDetection: Detect faces asynchronously on windows 10 Create Windows bitmap from detected SkBitmap that is Rgba8/Bgra8 color type, then convert the pixel format SoftwareBitmap to Gray8/Nv12 that is supported in current version. Detect faces asynchronously with the created Windows bitmap, and pause incoming method call to prevent the Detect function from being called before the AsyncOperation completes. Add unittest to test the result of detecting faces. Split original large CL[1] up in smaller subpatches including this CL. Link Face Detection demo[2] here. [1] https://chromium-review.googlesource.com/c/chromium/src/+/708336 [2] https://codepen.io/miguelao/pen/PmJWro BUG= 767021 Cq-Include-Trybots: master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: If2f93ede374bdebc6921cee4b0c9a09df879b693 Reviewed-on: https://chromium-review.googlesource.com/787790 Reviewed-by: Miguel Casas <mcasas@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Greg Thompson <grt@chromium.org> Commit-Queue: Junwei Fu <junwei.fu@intel.com> Cr-Commit-Position: refs/heads/master@{#523694} [modify] https://crrev.com/398adf6b070d1d7150763fe85ce3b06a557f97ba/services/shape_detection/BUILD.gn [add] https://crrev.com/398adf6b070d1d7150763fe85ce3b06a557f97ba/services/shape_detection/detection_utils_win.cc [modify] https://crrev.com/398adf6b070d1d7150763fe85ce3b06a557f97ba/services/shape_detection/detection_utils_win.h [modify] https://crrev.com/398adf6b070d1d7150763fe85ce3b06a557f97ba/services/shape_detection/face_detection_impl_win.cc [modify] https://crrev.com/398adf6b070d1d7150763fe85ce3b06a557f97ba/services/shape_detection/face_detection_impl_win.h [modify] https://crrev.com/398adf6b070d1d7150763fe85ce3b06a557f97ba/services/shape_detection/face_detection_impl_win_unittest.cc [modify] https://crrev.com/398adf6b070d1d7150763fe85ce3b06a557f97ba/services/shape_detection/face_detection_provider_win.cc [modify] https://crrev.com/398adf6b070d1d7150763fe85ce3b06a557f97ba/services/shape_detection/face_detection_provider_win.h
junwei.fu@, is this issue Fixed?
Yes, i will close it.
Comment 1 by mcasas@chromium.org
, Sep 20 2017