New issue
Advanced search Search tips

Issue 767008 link

Starred by 2 users
Status: Fixed
Owner: ----
Closed: Feb 2018
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Feature



Sign in to add a comment

Don't remove the previous controller if it was the same one

Reported by sabbaku...@yandex-team.ru, Sep 20 2017 
UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.125 YaBrowser/17.7.1.802 (beta) Yowser/2.5 Safari/537.36

Steps to reproduce the problem:
When the users open a site with login and password inputs that they've already visited before and click on the login field, a box with the saved logins appears. If the user then tries to type the login, it's possible that the AutofillPopupControllerImpl gets removed and created again.

What is the expected behavior?

What went wrong?
AutofillPopupControllerImpl probably should be reused for the same elements.

Did this work before? N/A 

Chrome version: 61.0.3163.91  Channel: n/a
OS Version: 
Flash Version:
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7125968aa191c6af94182bf367dcf56f27fb06d3

commit 7125968aa191c6af94182bf367dcf56f27fb06d3
Author: Sergey Abbakumov <sabbakumov@yandex-team.ru>
Date: Thu Sep 21 18:57:10 2017

Reuse AutofillPopupController if it's the same one

AutofillPopupController probably should not be removed and created again if we
are pretty sure it was called for the same element.

Bug:  767008 
Change-Id: I559ff60c884466f51d52b04ad18e72fe3a7e1d2d
Reviewed-on: https://chromium-review.googlesource.com/674928
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503522}
[modify] https://crrev.com/7125968aa191c6af94182bf367dcf56f27fb06d3/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
[modify] https://crrev.com/7125968aa191c6af94182bf367dcf56f27fb06d3/chrome/browser/ui/autofill/autofill_popup_controller_impl.h
[modify] https://crrev.com/7125968aa191c6af94182bf367dcf56f27fb06d3/chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc

Comment 2 by susanjuniab@chromium.org, Sep 25 2017

Labels: M-63 Needs-Triage-M61
Status: Untriaged (was: Unconfirmed)
Marking this as 'Untriaged' as this is a feature request.

Thanks...

Comment 3 by dtapu...@chromium.org, Feb 11 2018

Status: Fixed (was: Untriaged)
►

Sign in to add a comment