New issue
Advanced search Search tips

Issue 767004 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 716053



Sign in to add a comment

[Dice] Syncing to secondary account triggers reordering on Chrome restart

Project Member Reported by droger@chromium.org, Sep 20 2017

Issue description

As per privacy recommendations, the main Gaia account should not be changed while Chrome is running, and should be changed on the next Chrome restart, so that the syncing account becomes the first Gaia account.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6420b4e2244ce85ecf43a3155eec5b35081135e

commit d6420b4e2244ce85ecf43a3155eec5b35081135e
Author: David Roger <droger@chromium.org>
Date: Tue Sep 26 11:43:13 2017

[Signin] When using Dice, AccountReconcilor reorders accounts on restart

Bug:  767004 
Change-Id: I809d651345d4c5ae376c2967c58a11c5c1dd94b4
Reviewed-on: https://chromium-review.googlesource.com/674870
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504341}
[modify] https://crrev.com/d6420b4e2244ce85ecf43a3155eec5b35081135e/chrome/browser/signin/account_reconcilor_unittest.cc
[modify] https://crrev.com/d6420b4e2244ce85ecf43a3155eec5b35081135e/components/signin/core/browser/account_reconcilor.cc
[modify] https://crrev.com/d6420b4e2244ce85ecf43a3155eec5b35081135e/components/signin/core/browser/account_reconcilor.h

Comment 2 by droger@chromium.org, Sep 28 2017

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f49320523dbb952f2b195533b033030aa86811b

commit 4f49320523dbb952f2b195533b033030aa86811b
Author: David Roger <droger@chromium.org>
Date: Fri Sep 29 15:47:40 2017

[Signin] Add unittest for AccountReconcilor revoking tokens

Bug:  767004 
Change-Id: I23298bfcc294f2aeca35bba572246d0bdbf97b70
Reviewed-on: https://chromium-review.googlesource.com/684895
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505378}
[modify] https://crrev.com/4f49320523dbb952f2b195533b033030aa86811b/chrome/browser/signin/account_reconcilor_unittest.cc

Sign in to add a comment