[Missing Test]: Regression: Print Preview overlay does not appear on Google Slides |
|||
Issue descriptionAutomated tests for the below commit have been missing.Would it be possible to add test coverage to avoid regressions in future? CL: ---- https://chromium.googlesource.com/chromium/src.git/+/3a9c415ac75740facaf590ab918d9eae5d6b2301 Ref Bug: --------- https://bugs.chromium.org/p/chromium/issues/detail?id=763812 Thank you...!!
,
Sep 25 2017
I will add a test soon but right now I am busy with some other Pri-1s. That being said I don't think this bug should be a release-block since it is about adding a test which did not exist before. I am removing the label but if you think this has to be a release block and needs to be prioritized please undo and add the label back.
,
Sep 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/98ee1b0984ac7ac9b4f4513a0f54e6d7785d7418 commit 98ee1b0984ac7ac9b4f4513a0f54e6d7785d7418 Author: EhsanK <ekaramad@chromium.org> Date: Tue Sep 26 20:34:34 2017 Add test for a recent regression in PDF Viewer on slides pages Adding a test for https://crrev.com/502847. Bug: 766982 , 763812 Change-Id: I23bd8d27cb2b83ee527f12a9103f82e8eac0b115 Reviewed-on: https://chromium-review.googlesource.com/682597 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#504473} [modify] https://crrev.com/98ee1b0984ac7ac9b4f4513a0f54e6d7785d7418/chrome/browser/pdf/pdf_extension_test.cc [add] https://crrev.com/98ee1b0984ac7ac9b4f4513a0f54e6d7785d7418/chrome/test/data/pdf/post_message_zero_sized_embed.html
,
Nov 1 2017
Closing the bug following comment #3. |
|||
►
Sign in to add a comment |
|||
Comment 1 by ajha@chromium.org
, Sep 25 2017