New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 766975 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
OoO until Feb 4th
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Fetch: Stop checking Request.integrity's value in no-cors mode

Project Member Reported by raphael....@intel.com, Sep 20 2017

Issue description

We need to update our Fetch implementation to a recent spec change that removed the "If request ’s integrity metadata is not the empty string, then throw a TypeError" bit from Request's constructor algorithm.

Upstream bug report: https://github.com/whatwg/fetch/issues/583
Upstream spec change: https://github.com/whatwg/fetch/pull/584
WPT change: https://github.com/w3c/web-platform-tests/pull/7385
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d97c3a8550e35ce8af356fa6e3e8a0553a61140

commit 7d97c3a8550e35ce8af356fa6e3e8a0553a61140
Author: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Date: Thu Sep 21 10:44:54 2017

Fetch: Do not check |integrity| in no-cors mode when constructing a Request

Adapt to https://github.com/whatwg/fetch/pull/584, which removed the check
for |integrity|'s value when constructing a Request in no-cors mode.

Per https://github.com/whatwg/fetch/issues/583: "the issue is that it's
pretty common to do <script integrity="hash"> in your document. This creates
a no-cors request by default. If their service worker script passes through
with fetch(evt.request) then they will get a TypeError."

Note that the external tests added in
https://github.com/w3c/web-platform-tests/commit/96adf8a1a0cdeb70280f0a0e1ef840602c0ce8b0
are still flaky.

Bug:  766975 ,  766983 
Change-Id: I1a787ee39ed94db49ba18f8675edc7dc3019ed26
Reviewed-on: https://chromium-review.googlesource.com/674694
Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503412}
[modify] https://crrev.com/7d97c3a8550e35ce8af356fa6e3e8a0553a61140/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/request.js
[modify] https://crrev.com/7d97c3a8550e35ce8af356fa6e3e8a0553a61140/third_party/WebKit/Source/modules/fetch/Request.cpp

Labels: M-63
Status: Fixed (was: Started)
Done. Note that  bug 766983  reports some of the WPT tests upstream seem to be flaky.

Sign in to add a comment