New issue
Advanced search Search tips

Issue 766974 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 739147
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Bad-cast to blink::WebView from invalid vptr;test_runner::TestRunnerForSpecificView::Reset;test_runner::WebViewTestProxyBase::Reset

Project Member Reported by ClusterFuzz, Sep 20 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6486899601702912

Fuzzer: inferno_layout_test_unmodified
Job Type: linux_ubsan_vptr_content_shell_drt
Platform Id: linux

Crash Type: Bad-cast
Crash Address: 0x3207eacb0580
Crash State:
  Bad-cast to blink::WebView from invalid vptr
  test_runner::TestRunnerForSpecificView::Reset
  test_runner::WebViewTestProxyBase::Reset
  
Sanitizer: undefined (UBSAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_content_shell_drt&range=503010:503025

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6486899601702912

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Sep 20 2017

Labels: M-63
Project Member

Comment 2 by sheriffbot@chromium.org, Sep 20 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Sep 20 2017

Labels: Pri-1

Comment 4 by palmer@chromium.org, Sep 20 2017

Components: Test
Owner: lukasza@chromium.org
Status: Assigned (was: Untriaged)
I'm not sure if this is a bug in the test runner itself, or if test runner is triggering a bug that would be reachable from production. There seem to be a lot of test runner bugs in the security triage queue lately.
Cc: palmer@chromium.org mbarbe...@chromium.org
Labels: -Security_Impact-Head -ReleaseBlock-Stable Security_Impact-None ReleaseBlock-NA
This is a dupe of  issue 739147  (and 3 other identical bugs [1]).  I've spent some time looking at  issue 739147  and couldn't repro and couldn't figure out next steps...

At any rate - as I've said in  https://crbug.com/748428#c8  - this is not a product code issue.

[1] https://bugs.chromium.org/p/chromium/issues/list?can=1&cursor=chromium%3A740389&q=%22Bad-cast%20to%20blink%3A%3AWebView%20from%20invalid%20vptr%22

Comment 6 by palmer@chromium.org, Sep 21 2017

Cc: -mbarbe...@chromium.org lukasza@chromium.org
Labels: -Type-Bug-Security -Security_Impact-None -Security_Severity-High Type-Bug
Owner: mbarbe...@chromium.org
#5: Thank you! I kind of figured that'd be the case.

mbarbella: Can we get ClusterFuzz to ignore or filter out test_runner things? Does that make sense as a request, is it possible, et c.?
I'm open to suggestions, but having test runner stuff near the top of the stack doesn't necessarily guarantee that the underlying issue will be in test code. That said, it's a pretty good signal, and I'm about to enable automatic component assignment which would have added Test>Layout in this case. Does that seem reasonable for this type of issue, or is there still more that we'd like to have?

Comment 8 by palmer@chromium.org, Sep 22 2017

#7: Yeah, that sounds good.
Project Member

Comment 9 by ClusterFuzz, Oct 1 2017

Labels: Test-Predator-AutoComponents
Automatically applying components based on information from OWNERS files. If this seems incorrect, please apply the Test-Predator-Wrong-Components label.
Labels: -Test-Predator-AutoComponents
Status: Fixed (was: Assigned)
Automatic component assignment is enabled and should be working properly now (the issue that caused the buggy update in c#9 is fixed).
Project Member

Comment 12 by sheriffbot@chromium.org, Oct 4 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 13 by ClusterFuzz, Oct 10 2017

Labels: Needs-Feedback
ClusterFuzz testcase 6486899601702912 is still reproducing on tip-of-tree build (trunk).

Please re-test your fix against this testcase and if the fix was incorrect or incomplete, please re-open the bug. Otherwise, ignore this notification and add ClusterFuzz-Wrong label.
Mergedinto: 739147
Status: Duplicate (was: Fixed)
Probably should have duped this rather than mark it as fixed
Project Member

Comment 15 by sheriffbot@chromium.org, Jan 10 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment