Touch bar goes unresponsive after opening a new tab page |
|||||||||||
Issue descriptionChrome Version: 62.0.3202.29 OS: Mac OS 10.12.6 (MacBook Pro with touch bar) What steps will reproduce the problem? (1) Open chrome NTP and visit few webpages (2) Press back/forward button in the touch bar, able to navigate the pages (3) Open a New Tab Page (4) Go back to the previous tab and press back/forward button in touch bar What is the expected result? Unable to navigate to the pages What happens instead? Touch button goes disabled and unable to go forward or backward Note: This issue is not seen on chrome latest canary #63.0.3220.0, but able to reproduce on the same version of equivalent dev. Thanks!
,
Sep 21 2017
,
Sep 21 2017
,
Sep 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25b62769075de8360167935077b5cafac7935863 commit 25b62769075de8360167935077b5cafac7935863 Author: spqchan <spqchan@chromium.org> Date: Fri Sep 22 03:40:58 2017 [Mac] Invalidate the Touch Bar for Tab Changes When the active tab changes, the page might not be get reloaded. As such, we'll have to invalidate the touch bar when that happens. Bug: 766969 Change-Id: I6cd9288966d7cd618a38709eb5e2dadcebb1a3c2 Reviewed-on: https://chromium-review.googlesource.com/677481 Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#503631} [modify] https://crrev.com/25b62769075de8360167935077b5cafac7935863/chrome/browser/ui/cocoa/browser_window_controller.mm
,
Sep 26 2017
Verified this issue on Mac OS 10.13 using chrome latest dev #63.0.3223.8, able to navigate to forward and backward webpages using touch bar even after opening a new tab page. Hence adding TE-Verified label. Thanks!
,
Sep 26 2017
This is very low risk and is safe to merged. It has been tested.
,
Sep 26 2017
This bug requires manual review: M62 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 26 2017
Thanks - approving for merge to M62. Branch:3202
,
Sep 26 2017
,
Sep 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c7c48eba865b69713e1c85bfeb281594d82d8e4 commit 1c7c48eba865b69713e1c85bfeb281594d82d8e4 Author: spqchan <spqchan@chromium.org> Date: Tue Sep 26 17:40:40 2017 [Mac] Invalidate the Touch Bar for Tab Changes When the active tab changes, the page might not be get reloaded. As such, we'll have to invalidate the touch bar when that happens. (cherry picked from commit 25b62769075de8360167935077b5cafac7935863) Bug: 766969 Change-Id: I6cd9288966d7cd618a38709eb5e2dadcebb1a3c2 Reviewed-on: https://chromium-review.googlesource.com/677481 Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#503631} Reviewed-on: https://chromium-review.googlesource.com/685455 Reviewed-by: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#449} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/1c7c48eba865b69713e1c85bfeb281594d82d8e4/chrome/browser/ui/cocoa/browser_window_controller.mm
,
Sep 26 2017
,
Sep 27 2017
Verified this issue on Mac OS 10.13 using chrome latest beta #62.0.3202.38 and observed the fix is working as intended as per the above fix. Hence adding TE-Verified label for M-62. Thanks! |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by lgrey@chromium.org
, Sep 20 2017