New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 766959 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

"Location" is ambigous in German

Project Member Reported by dullweber@chromium.org, Sep 20 2017

Issue description

Location can either mean a physical location of a person, e.g. GPS coordinates or a location on a file system e.g. /foo/bar/file.txt. In German, the first is translated as "Standort", the second as "Speicherort".

To disambiguate, all "Location" strings should have a meaning attribute. (e.g. meaning="Geolocation" or meaning="File location").

Affected strings:
https://cs.chromium.org/search/?q=%5E%5Cs*location%5Cs*$+f:grd&sq=package:chromium&type=cs
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e56bcfa1d3d852362be9041a16b7768bbb583e4e

commit e56bcfa1d3d852362be9041a16b7768bbb583e4e
Author: Christian Dullweber <dullweber@chromium.org>
Date: Thu Sep 21 09:49:26 2017

Disambiguate "Location" strings

"Location" can either be a physical location of a person, e.g. GPS coordinates, 
or a location on a file system e.g. /foo/bar/file.txt. In German, the first is 
translated as "Standort", the second as "Speicherort".
To disambiguate, all "Location" strings should have a meaning attribute.

Bug:  766959 
Change-Id: Iac61d5dbf2e2d3ce8507639aca0d0202b07058c3
Reviewed-on: https://chromium-review.googlesource.com/674686
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Lucas Garron <lgarron@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503404}
[modify] https://crrev.com/e56bcfa1d3d852362be9041a16b7768bbb583e4e/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/e56bcfa1d3d852362be9041a16b7768bbb583e4e/chrome/app/generated_resources.grd
[modify] https://crrev.com/e56bcfa1d3d852362be9041a16b7768bbb583e4e/chrome/app/settings_strings.grdp
[modify] https://crrev.com/e56bcfa1d3d852362be9041a16b7768bbb583e4e/components/page_info_strings.grdp

Owner: mencinares@google.com
Hi,

This is not on linguistic side anymore. Do you suggest to change the context? There are similar bug ID quite related with this issue. Please see below list: 

chromium bug ID: 767349
chromium bug ID: 730039 with b/65377002

Please confirm.

Regards!
Status: Fixed (was: Started)
yes, this issue is fixed.
Cc: dullweber@chromium.org
I still have a question: The fix has been landed in M63. M61 and M62 are also affected by the incorrect translation of the location permission. 
The fix needs these messages to be translated:
https://tc.corp.google.com/btviewer/messagedetail?project=ChromeClient&msgId=6077218111594579611
https://tc.corp.google.com/btviewer/messagedetail?project=ChromeClient&msgId=6077218111594579611

Will the translations be done in time for M62 stable, so that the fix could be merged to M62?
Hi,

You can post that queries through the b/65377002, though I am not quite sure if it is still a linguistic case.

Regards!

Sign in to add a comment