MacViewsBrowser uses the toolkit-views certificate selector, but the native OS certificate viewer |
||||||||||||||||||||||||||
Issue descriptionChrome Version : 63.0.3219.0 OS Version: OS X 10.12.6 Non-test repro: Navigate to https://server.cryptomix.com/secure it should use the native dialog for both. To summon the dialog, run browser_tests --gtest_filter=BrowserUiTest.Invoke --ui=CertificateSelectorDialogTest.InvokeUi_default --test-launcher-interactive (note to "fix" this Issue, that test will probably need to be disabled, since BrowserUiTest has no way to detect native windows).
,
Sep 21 2017
neat :) Note https://chromium-review.googlesource.com/c/chromium/src/+/661721 just landed which gives a way to invoke this dialog in mac_views_browser via a browser_test, so you don't need to ping some website for a certificate request.
,
Sep 21 2017
Thank you for the heads up...
,
Mar 26 2018
MacViews triage: tagging for M69, but leaving unassigned for now.
,
Mar 27 2018
,
Apr 17 2018
,
May 31 2018
,
Jun 15 2018
MacViews triage: over to robliao@
,
Jul 12
,
Jul 12
,
Jul 20
robliao@ - ping :) this is pretty busted for some use cases of the selector especially. We should use the native selector.
,
Jul 20
Marking this P1.
,
Jul 20
"RBS" as this is P1 blocking MacViews launch.
,
Jul 23
,
Jul 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7fbbd5f29e26ea66c2a154bbcc97707574dac518 commit 7fbbd5f29e26ea66c2a154bbcc97707574dac518 Author: Robert Liao <robliao@chromium.org> Date: Mon Jul 23 17:46:55 2018 Use the Native Certificate Viewer on MacOS even on MacViews BUG= 766926 Change-Id: I6d0302763687bbb4fe30682684ad85a2ac79f782 Reviewed-on: https://chromium-review.googlesource.com/1145674 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#577201} [modify] https://crrev.com/7fbbd5f29e26ea66c2a154bbcc97707574dac518/chrome/browser/ui/views/ssl_client_certificate_selector.cc
,
Jul 23
Pls request a merge to M69 for CL listed at #16 once change is baked/verified in canary and safe to merge. Thank you.
,
Jul 24
,
Jul 24
Approving merge to M69 branch 3497 based on comment #20. Please merge. Thank you.
,
Jul 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d64a4697775ffcc7d4524bef5da775e7f3c11f7 commit 5d64a4697775ffcc7d4524bef5da775e7f3c11f7 Author: Robert Liao <robliao@chromium.org> Date: Tue Jul 24 20:48:06 2018 Use the Native Certificate Viewer on MacOS even on MacViews BUG= 766926 Change-Id: I6d0302763687bbb4fe30682684ad85a2ac79f782 Reviewed-on: https://chromium-review.googlesource.com/1145674 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#577201}(cherry picked from commit 7fbbd5f29e26ea66c2a154bbcc97707574dac518) Reviewed-on: https://chromium-review.googlesource.com/1148610 Reviewed-by: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#51} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/5d64a4697775ffcc7d4524bef5da775e7f3c11f7/chrome/browser/ui/views/ssl_client_certificate_selector.cc
,
Jul 24
Can this be marked as fixed if nothing else is pending?
,
Jul 24
Nope. This is done! Marking fixed.
,
Jul 25
Unable to reproduce the issue on Mac 10.12.6 and 10.13.5 using chrome 63.0.3219.0 and latest 70.0.3501.0. Steps: ----- 1. Launched chrome on by using terminal " --gtest_filter=BrowserUiTest.Invoke --ui=CertificateSelectorDialogTest.InvokeUi_default --test-launcher-interactive " 2. Enabled Cocoa flag from chrome://flags As we have not seen certificate selector robliao@chromium.org: It would be really helpful if a sample URL is provided, so that we can verifying the fix. Thanks...!
,
Jul 25
,
Jul 25
,
Jul 31
Clearing Needs-Feedback per #27. |
||||||||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||||||||
Comment 1 by claudiom...@gmail.com
, Sep 20 2017