New issue
Advanced search Search tips

Issue 766917 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Chrome should depend on breakpad/breakpad, not breakpad/breakpad/src

Project Member Reported by mark@chromium.org, Sep 20 2017

Issue description

There are two repositories for Breakpad:

https://chromium.googlesource.com/breakpad/breakpad/ - read/write. Commits go here.

https://chromium.googlesource.com/breakpad/breakpad/src/ - read-only view of “src” in the above managed by gsubtreed. Chromium gets things from here.

The reason for this is that historically, when Breakpad lived in Subversion, the root of the repository (in trunk) was what became breakpad/breakpad in Git, but Chrome checked out the “src” subdirectory. Git didn’t make it easy to check out just a subpath of a repository, so the read-only mirror of just “src” was created to allow Chrome to continue getting the same set of files it was seeing before, avoiding having to rewrite a bunch of paths in Chrome.

This is no good. People have a copy of Breakpad in their Chrome checkout and assume that they can develop patches in it. They do, and they send the patches for review, and they are (or should be) unlandable, because their patches are against the read-only mirror.

In bug 766164, one of those patches slipped by and wound up breaking the read-only mirror so that it stopped syncing. (The ACL and the mirror have been fixed.)

Chrome should get its copy of Breakpad from the authoritative read-write source, breakpad/breakpad. The read-only mirror of src should be deprecated. We’ll need to keep it around (indefinitely) so that old buildspecs and branchspecs don’t break, but provided that we just make sure that the old hashes stay live, we can stop gsubtreed and we can empty it out at master and leave a README pointing to the real copy of Breakpad.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b41612edd88c44f77a686d85f0a8d7cc42ba56e

commit 5b41612edd88c44f77a686d85f0a8d7cc42ba56e
Author: Mark Mentovai <mark@chromium.org>
Date: Sat Sep 23 01:32:26 2017

Use the authoritative upstream source for Breakpad, move to third_party

Breakpad was being synced from a read-only mirror of a subdirectory
rather than the authoritative upstream source. This encouraged Chrome
developers to send patches against the read-only mirror. Those patches
couldn’t be committed and needed to be duplicated in the correct
repository. Once, a patch against the read-only mirror accidentally was
committed, and it broke mirroring.

This odd setup existed from the time of the git migration. Prior to
that, Breakpad was hosted in Subversion, and Chrome incidentally pulled
Breakpad’s src subdirectory rather than the entire trunk directory.
Because it wasn‘t easy to do the same thing with git, the read-only
mirror of src was created to avoid having to change lots of paths in
Chrome. But now I’m changing the paths.

This also moves Breakpad from the top-level breakpad directory in Chrome
to third_party/breakpad. It should have been there all along, but
Breakpad was one of the earliest dependencies added to Chrome, and at
that time, there was no firm policy on where to put Google-originated
external code.

Bug:  766917 
TBR: pinkerton@chromium.org
Change-Id: I860a3e92b0327898ba73b8678af258a9020eeaaf
Reviewed-on: https://chromium-review.googlesource.com/677280
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503925}
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/.gitignore
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/.gn
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/BUILD.gn
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/DEPS
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/PRESUBMIT.py
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/base/debug/stack_trace_win.cc
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/base/process/launch_mac.cc
[delete] https://crrev.com/a2aa7d8ff137c99baa8d250089cad974550ea0eb/breakpad/BUILD.gn
[delete] https://crrev.com/a2aa7d8ff137c99baa8d250089cad974550ea0eb/breakpad/README.chromium
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/chrome/BUILD.gn
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/chrome/app/DEPS
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/chrome/app/chrome_binaries.vsprops
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/chrome/app/chrome_exe.vsprops
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/chrome/test/BUILD.gn
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/chrome_elf/DEPS
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/chromecast/app/BUILD.gn
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/chromecast/app/android/DEPS
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/chromecast/app/android/crash_handler.cc
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/chromecast/crash/BUILD.gn
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/chromecast/crash/DEPS
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/chromecast/crash/cast_crashdump_uploader.cc
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/chromecast/crash/cast_crashdump_uploader_unittest.cc
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/components/crash/content/DEPS
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/components/crash/content/app/BUILD.gn
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/components/crash/content/app/breakpad_linux.cc
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/components/crash/content/app/breakpad_linux_impl.h
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/components/crash/content/app/breakpad_mac.mm
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/components/crash/content/app/breakpad_win.cc
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/components/crash/content/app/crash_keys_win.cc
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/components/crash/content/app/crash_keys_win_unittest.cc
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/components/crash/content/app/crash_reporter_client.h
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/components/crash/content/browser/BUILD.gn
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/components/crash/content/browser/crash_handler_host_linux.cc
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/components/crash/content/tools/BUILD.gn
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/components/crash/content/tools/crash_service.cc
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/components/nacl/broker/BUILD.gn
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/components/upload_list/crash_upload_list.h
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/content/shell/BUILD.gn
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/docs/linux_crash_dumping.md
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/ios/chrome/app/DEPS
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/ios/chrome/app/application_delegate/BUILD.gn
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/ios/chrome/app/application_delegate/metrics_mediator_unittest.mm
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/ios/chrome/browser/DEPS
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/ios/chrome/browser/crash_report/BUILD.gn
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/ios/chrome/browser/crash_report/breakpad_helper.mm
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/ios/chrome/browser/crash_report/breakpad_helper_unittest.mm
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/ios/chrome/browser/crash_report/crash_report_background_uploader.mm
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/ios/chrome/browser/ui/safe_mode/BUILD.gn
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/ios/chrome/browser/ui/safe_mode/safe_mode_view_controller_unittest.mm
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/ios/chrome/test/DEPS
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/ios/chrome/test/app/BUILD.gn
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/ios/chrome/test/app/chrome_test_util.mm
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/ios/chrome/test/ocmock/BUILD.gn
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/ios/chrome/test/ocmock/OCMockObject+BreakpadControllerTesting.mm
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/ios/clean/chrome/app/DEPS
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/ios/clean/chrome/app/steps/BUILD.gn
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/ios/clean/chrome/app/steps/breakpad_initializer.mm
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/native_client_sdk/src/BUILD.gn
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/remoting/base/BUILD.gn
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/remoting/base/DEPS
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/remoting/base/breakpad_mac.mm
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/remoting/base/breakpad_win.cc
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/remoting/base/breakpad_win_unittest.cc
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/remoting/scripts/mac/dump_product_syms
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/third_party/.gitignore
[add] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/third_party/breakpad/BUILD.gn
[add] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/third_party/breakpad/DEPS
[rename] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/third_party/breakpad/LICENSE
[rename] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/third_party/breakpad/OWNERS
[add] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/third_party/breakpad/README.chromium
[rename] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/third_party/breakpad/linux/breakpad_googletest_includes.h
[rename] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/third_party/breakpad/linux/generate-test-dump.cc
[rename] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/third_party/breakpad/minidump_fuzzer.cc
[rename] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/third_party/breakpad/minidump_fuzzer.dict
[rename] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/third_party/breakpad/symupload.exe
[rename] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/third_party/breakpad/using_breakpad.vsprops
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/tools/checklicenses/checklicenses.py
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/tools/msan/blacklist.txt
[modify] https://crrev.com/5b41612edd88c44f77a686d85f0a8d7cc42ba56e/tools/perf/chrome_telemetry_build/BUILD.gn

Comment 2 by mark@chromium.org, Sep 23 2017

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 25 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/166d64b6f46106133db16f9aae9c18a4cdd4997a

commit 166d64b6f46106133db16f9aae9c18a4cdd4997a
Author: Sylvain Defresne <sdefresne@google.com>
Date: Mon Sep 25 09:35:28 2017

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7

commit 0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7
Author: Peter Conn <peconn@chromium.org>
Date: Mon Sep 25 09:58:57 2017

Revert "Use the authoritative upstream source for Breakpad, move to third_party"

This reverts commit 5b41612edd88c44f77a686d85f0a8d7cc42ba56e.

Reason for revert: https://crbug.com/768262

Original change's description:
> Use the authoritative upstream source for Breakpad, move to third_party
> 
> Breakpad was being synced from a read-only mirror of a subdirectory
> rather than the authoritative upstream source. This encouraged Chrome
> developers to send patches against the read-only mirror. Those patches
> couldn’t be committed and needed to be duplicated in the correct
> repository. Once, a patch against the read-only mirror accidentally was
> committed, and it broke mirroring.
> 
> This odd setup existed from the time of the git migration. Prior to
> that, Breakpad was hosted in Subversion, and Chrome incidentally pulled
> Breakpad’s src subdirectory rather than the entire trunk directory.
> Because it wasn‘t easy to do the same thing with git, the read-only
> mirror of src was created to avoid having to change lots of paths in
> Chrome. But now I’m changing the paths.
> 
> This also moves Breakpad from the top-level breakpad directory in Chrome
> to third_party/breakpad. It should have been there all along, but
> Breakpad was one of the earliest dependencies added to Chrome, and at
> that time, there was no firm policy on where to put Google-originated
> external code.
> 
> Bug:  766917 
> TBR: pinkerton@chromium.org
> Change-Id: I860a3e92b0327898ba73b8678af258a9020eeaaf
> Reviewed-on: https://chromium-review.googlesource.com/677280
> Commit-Queue: Mark Mentovai <mark@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#503925}

TBR=thestig@chromium.org,pinkerton@chromium.org,mark@chromium.org
NOTREECHECKS=true
NOTRY=true

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  766917 
Change-Id: Ie1590163f53cc7180506101aacf6cf39964e1457
Reviewed-on: https://chromium-review.googlesource.com/681014
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504018}
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/.gitignore
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/.gn
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/BUILD.gn
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/DEPS
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/PRESUBMIT.py
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/base/debug/stack_trace_win.cc
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/base/process/launch_mac.cc
[add] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/breakpad/BUILD.gn
[rename] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/breakpad/LICENSE
[rename] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/breakpad/OWNERS
[add] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/breakpad/README.chromium
[rename] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/breakpad/linux/breakpad_googletest_includes.h
[rename] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/breakpad/linux/generate-test-dump.cc
[rename] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/breakpad/minidump_fuzzer.cc
[rename] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/breakpad/minidump_fuzzer.dict
[rename] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/breakpad/symupload.exe
[rename] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/breakpad/using_breakpad.vsprops
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/chrome/BUILD.gn
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/chrome/app/DEPS
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/chrome/app/chrome_binaries.vsprops
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/chrome/app/chrome_exe.vsprops
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/chrome/test/BUILD.gn
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/chrome_elf/DEPS
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/chromecast/app/BUILD.gn
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/chromecast/app/android/DEPS
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/chromecast/app/android/crash_handler.cc
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/chromecast/crash/BUILD.gn
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/chromecast/crash/DEPS
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/chromecast/crash/cast_crashdump_uploader.cc
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/chromecast/crash/cast_crashdump_uploader_unittest.cc
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/components/crash/content/DEPS
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/components/crash/content/app/BUILD.gn
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/components/crash/content/app/breakpad_linux.cc
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/components/crash/content/app/breakpad_linux_impl.h
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/components/crash/content/app/breakpad_mac.mm
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/components/crash/content/app/breakpad_win.cc
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/components/crash/content/app/crash_keys_win.cc
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/components/crash/content/app/crash_keys_win_unittest.cc
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/components/crash/content/app/crash_reporter_client.h
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/components/crash/content/browser/BUILD.gn
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/components/crash/content/browser/crash_handler_host_linux.cc
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/components/crash/content/tools/BUILD.gn
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/components/crash/content/tools/crash_service.cc
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/components/nacl/broker/BUILD.gn
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/components/upload_list/crash_upload_list.h
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/content/shell/BUILD.gn
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/docs/linux_crash_dumping.md
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/ios/chrome/app/DEPS
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/ios/chrome/app/application_delegate/BUILD.gn
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/ios/chrome/app/application_delegate/metrics_mediator_unittest.mm
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/ios/chrome/browser/DEPS
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/ios/chrome/browser/crash_report/BUILD.gn
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/ios/chrome/browser/crash_report/breakpad_helper.mm
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/ios/chrome/browser/crash_report/breakpad_helper_unittest.mm
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/ios/chrome/browser/crash_report/crash_report_background_uploader.mm
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/ios/chrome/browser/ui/safe_mode/BUILD.gn
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/ios/chrome/browser/ui/safe_mode/safe_mode_view_controller_unittest.mm
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/ios/chrome/test/DEPS
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/ios/chrome/test/app/BUILD.gn
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/ios/chrome/test/app/chrome_test_util.mm
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/ios/chrome/test/ocmock/BUILD.gn
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/ios/chrome/test/ocmock/OCMockObject+BreakpadControllerTesting.mm
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/ios/clean/chrome/app/DEPS
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/ios/clean/chrome/app/steps/BUILD.gn
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/ios/clean/chrome/app/steps/breakpad_initializer.mm
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/native_client_sdk/src/BUILD.gn
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/remoting/base/BUILD.gn
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/remoting/base/DEPS
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/remoting/base/breakpad_mac.mm
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/remoting/base/breakpad_win.cc
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/remoting/base/breakpad_win_unittest.cc
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/remoting/scripts/mac/dump_product_syms
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/third_party/.gitignore
[delete] https://crrev.com/ee016dd09a090651c3f012525cfb6c1d0c553327/third_party/breakpad/BUILD.gn
[delete] https://crrev.com/ee016dd09a090651c3f012525cfb6c1d0c553327/third_party/breakpad/DEPS
[delete] https://crrev.com/ee016dd09a090651c3f012525cfb6c1d0c553327/third_party/breakpad/README.chromium
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/tools/checklicenses/checklicenses.py
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/tools/msan/blacklist.txt
[modify] https://crrev.com/0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7/tools/perf/chrome_telemetry_build/BUILD.gn

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 25 2017

Labels: merge-merged-3223
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dad5b43492d72251a40775e02460aed61cce8f79

commit dad5b43492d72251a40775e02460aed61cce8f79
Author: Peter Conn <peconn@chromium.org>
Date: Mon Sep 25 16:26:28 2017

Revert "Use the authoritative upstream source for Breakpad, move to third_party"

This reverts commit 5b41612edd88c44f77a686d85f0a8d7cc42ba56e.

Reason for revert: https://crbug.com/768262

Original change's description:
> Use the authoritative upstream source for Breakpad, move to third_party
> 
> Breakpad was being synced from a read-only mirror of a subdirectory
> rather than the authoritative upstream source. This encouraged Chrome
> developers to send patches against the read-only mirror. Those patches
> couldn’t be committed and needed to be duplicated in the correct
> repository. Once, a patch against the read-only mirror accidentally was
> committed, and it broke mirroring.
> 
> This odd setup existed from the time of the git migration. Prior to
> that, Breakpad was hosted in Subversion, and Chrome incidentally pulled
> Breakpad’s src subdirectory rather than the entire trunk directory.
> Because it wasn‘t easy to do the same thing with git, the read-only
> mirror of src was created to avoid having to change lots of paths in
> Chrome. But now I’m changing the paths.
> 
> This also moves Breakpad from the top-level breakpad directory in Chrome
> to third_party/breakpad. It should have been there all along, but
> Breakpad was one of the earliest dependencies added to Chrome, and at
> that time, there was no firm policy on where to put Google-originated
> external code.
> 
> Bug:  766917 
> TBR: pinkerton@chromium.org
> Change-Id: I860a3e92b0327898ba73b8678af258a9020eeaaf
> Reviewed-on: https://chromium-review.googlesource.com/677280
> Commit-Queue: Mark Mentovai <mark@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#503925}

TBR=thestig@chromium.org,pinkerton@chromium.org,mark@chromium.org
NOTREECHECKS=true
NOTRY=true

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  766917 
Change-Id: Ie1590163f53cc7180506101aacf6cf39964e1457
Reviewed-on: https://chromium-review.googlesource.com/681014
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#504018}(cherry picked from commit 0b24f77010b8af4dabc0d3cf37c2e864b29f5ed7)
Reviewed-on: https://chromium-review.googlesource.com/682115
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/branch-heads/3223@{#3}
Cr-Branched-From: 569732c0a96ec8d0c4c5df7f7012188696c7d37c-refs/heads/master@{#503964}
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/.gitignore
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/.gn
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/BUILD.gn
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/DEPS
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/PRESUBMIT.py
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/base/debug/stack_trace_win.cc
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/base/process/launch_mac.cc
[add] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/breakpad/BUILD.gn
[rename] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/breakpad/LICENSE
[rename] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/breakpad/OWNERS
[add] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/breakpad/README.chromium
[rename] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/breakpad/linux/breakpad_googletest_includes.h
[rename] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/breakpad/linux/generate-test-dump.cc
[rename] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/breakpad/minidump_fuzzer.cc
[rename] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/breakpad/minidump_fuzzer.dict
[rename] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/breakpad/symupload.exe
[rename] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/breakpad/using_breakpad.vsprops
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/chrome/BUILD.gn
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/chrome/app/DEPS
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/chrome/app/chrome_binaries.vsprops
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/chrome/app/chrome_exe.vsprops
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/chrome/test/BUILD.gn
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/chrome_elf/DEPS
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/chromecast/app/BUILD.gn
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/chromecast/app/android/DEPS
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/chromecast/app/android/crash_handler.cc
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/chromecast/crash/BUILD.gn
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/chromecast/crash/DEPS
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/chromecast/crash/cast_crashdump_uploader.cc
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/chromecast/crash/cast_crashdump_uploader_unittest.cc
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/components/crash/content/DEPS
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/components/crash/content/app/BUILD.gn
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/components/crash/content/app/breakpad_linux.cc
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/components/crash/content/app/breakpad_linux_impl.h
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/components/crash/content/app/breakpad_mac.mm
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/components/crash/content/app/breakpad_win.cc
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/components/crash/content/app/crash_keys_win.cc
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/components/crash/content/app/crash_keys_win_unittest.cc
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/components/crash/content/app/crash_reporter_client.h
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/components/crash/content/browser/BUILD.gn
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/components/crash/content/browser/crash_handler_host_linux.cc
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/components/crash/content/tools/BUILD.gn
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/components/crash/content/tools/crash_service.cc
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/components/nacl/broker/BUILD.gn
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/components/upload_list/crash_upload_list.h
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/content/shell/BUILD.gn
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/docs/linux_crash_dumping.md
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/ios/chrome/app/DEPS
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/ios/chrome/app/application_delegate/BUILD.gn
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/ios/chrome/app/application_delegate/metrics_mediator_unittest.mm
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/ios/chrome/browser/DEPS
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/ios/chrome/browser/crash_report/BUILD.gn
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/ios/chrome/browser/crash_report/breakpad_helper.mm
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/ios/chrome/browser/crash_report/breakpad_helper_unittest.mm
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/ios/chrome/browser/crash_report/crash_report_background_uploader.mm
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/ios/chrome/browser/ui/safe_mode/BUILD.gn
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/ios/chrome/browser/ui/safe_mode/safe_mode_view_controller_unittest.mm
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/ios/chrome/test/DEPS
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/ios/chrome/test/app/BUILD.gn
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/ios/chrome/test/app/chrome_test_util.mm
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/ios/chrome/test/ocmock/BUILD.gn
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/ios/chrome/test/ocmock/OCMockObject+BreakpadControllerTesting.mm
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/ios/clean/chrome/app/DEPS
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/ios/clean/chrome/app/steps/BUILD.gn
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/ios/clean/chrome/app/steps/breakpad_initializer.mm
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/native_client_sdk/src/BUILD.gn
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/remoting/base/BUILD.gn
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/remoting/base/DEPS
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/remoting/base/breakpad_mac.mm
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/remoting/base/breakpad_win.cc
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/remoting/base/breakpad_win_unittest.cc
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/remoting/scripts/mac/dump_product_syms
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/third_party/.gitignore
[delete] https://crrev.com/e16e400df6e7fa1bced9ad14db810ef7296049e9/third_party/breakpad/BUILD.gn
[delete] https://crrev.com/e16e400df6e7fa1bced9ad14db810ef7296049e9/third_party/breakpad/DEPS
[delete] https://crrev.com/e16e400df6e7fa1bced9ad14db810ef7296049e9/third_party/breakpad/README.chromium
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/tools/checklicenses/checklicenses.py
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/tools/msan/blacklist.txt
[modify] https://crrev.com/dad5b43492d72251a40775e02460aed61cce8f79/tools/perf/chrome_telemetry_build/BUILD.gn

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f

commit ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f
Author: Mark Mentovai <mark@chromium.org>
Date: Mon Sep 25 17:24:41 2017

Use the authoritative upstream source for Breakpad, move to third_party

Relands 5b41612edd88, reverted at 0b24f77010b8.

Breakpad was being synced from a read-only mirror of a subdirectory
rather than the authoritative upstream source. This encouraged Chrome
developers to send patches against the read-only mirror. Those patches
couldn’t be committed and needed to be duplicated in the correct
repository. Once, a patch against the read-only mirror accidentally was
committed, and it broke mirroring.

This odd setup existed from the time of the git migration. Prior to
that, Breakpad was hosted in Subversion, and Chrome incidentally pulled
Breakpad’s src subdirectory rather than the entire trunk directory.
Because it wasn‘t easy to do the same thing with git, the read-only
mirror of src was created to avoid having to change lots of paths in
Chrome. But now I’m changing the paths.

This also moves Breakpad from the top-level breakpad directory in Chrome
to third_party/breakpad. It should have been there all along, but
Breakpad was one of the earliest dependencies added to Chrome, and at
that time, there was no firm policy on where to put Google-originated
external code.

Bug:  766917 
Change-Id: Ia52d459d6ea8dee4157b42a265f3eeb8b15ddc1f
TBR: thestig@chromium.org, pinkerton@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/681838
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504087}
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/.gitignore
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/.gn
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/BUILD.gn
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/DEPS
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/PRESUBMIT.py
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/base/debug/stack_trace_win.cc
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/base/process/launch_mac.cc
[delete] https://crrev.com/98edf5e7f54af5edbc07c1ff9abcff40d60897fb/breakpad/BUILD.gn
[delete] https://crrev.com/98edf5e7f54af5edbc07c1ff9abcff40d60897fb/breakpad/README.chromium
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/chrome/BUILD.gn
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/chrome/app/DEPS
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/chrome/app/chrome_binaries.vsprops
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/chrome/app/chrome_exe.vsprops
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/chrome/test/BUILD.gn
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/chrome_elf/DEPS
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/chromecast/app/BUILD.gn
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/chromecast/app/android/DEPS
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/chromecast/app/android/crash_handler.cc
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/chromecast/crash/BUILD.gn
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/chromecast/crash/DEPS
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/chromecast/crash/cast_crashdump_uploader.cc
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/chromecast/crash/cast_crashdump_uploader_unittest.cc
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/components/crash/content/DEPS
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/components/crash/content/app/BUILD.gn
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/components/crash/content/app/breakpad_linux.cc
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/components/crash/content/app/breakpad_linux_impl.h
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/components/crash/content/app/breakpad_mac.mm
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/components/crash/content/app/breakpad_win.cc
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/components/crash/content/app/crash_keys_win.cc
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/components/crash/content/app/crash_keys_win_unittest.cc
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/components/crash/content/app/crash_reporter_client.h
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/components/crash/content/browser/BUILD.gn
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/components/crash/content/browser/crash_handler_host_linux.cc
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/components/crash/content/tools/BUILD.gn
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/components/crash/content/tools/crash_service.cc
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/components/nacl/broker/BUILD.gn
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/components/upload_list/crash_upload_list.h
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/content/shell/BUILD.gn
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/docs/linux_crash_dumping.md
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/ios/chrome/app/DEPS
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/ios/chrome/app/application_delegate/BUILD.gn
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/ios/chrome/app/application_delegate/metrics_mediator_unittest.mm
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/ios/chrome/browser/DEPS
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/ios/chrome/browser/crash_report/BUILD.gn
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/ios/chrome/browser/crash_report/breakpad_helper.mm
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/ios/chrome/browser/crash_report/breakpad_helper_unittest.mm
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/ios/chrome/browser/crash_report/crash_report_background_uploader.mm
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/ios/chrome/browser/ui/safe_mode/BUILD.gn
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/ios/chrome/browser/ui/safe_mode/safe_mode_view_controller_unittest.mm
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/ios/chrome/test/DEPS
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/ios/chrome/test/app/BUILD.gn
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/ios/chrome/test/app/chrome_test_util.mm
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/ios/chrome/test/ocmock/BUILD.gn
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/ios/chrome/test/ocmock/OCMockObject+BreakpadControllerTesting.mm
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/ios/clean/chrome/app/DEPS
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/ios/clean/chrome/app/steps/BUILD.gn
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/ios/clean/chrome/app/steps/breakpad_initializer.mm
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/native_client_sdk/src/BUILD.gn
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/remoting/base/BUILD.gn
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/remoting/base/DEPS
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/remoting/base/breakpad_mac.mm
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/remoting/base/breakpad_win.cc
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/remoting/base/breakpad_win_unittest.cc
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/remoting/scripts/mac/dump_product_syms
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/third_party/.gitignore
[add] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/third_party/breakpad/BUILD.gn
[add] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/third_party/breakpad/DEPS
[rename] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/third_party/breakpad/LICENSE
[rename] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/third_party/breakpad/OWNERS
[add] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/third_party/breakpad/README.chromium
[rename] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/third_party/breakpad/linux/breakpad_googletest_includes.h
[rename] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/third_party/breakpad/linux/generate-test-dump.cc
[rename] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/third_party/breakpad/minidump_fuzzer.cc
[rename] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/third_party/breakpad/minidump_fuzzer.dict
[rename] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/third_party/breakpad/symupload.exe
[rename] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/third_party/breakpad/using_breakpad.vsprops
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/tools/checklicenses/checklicenses.py
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/tools/msan/blacklist.txt
[modify] https://crrev.com/ebb9ddd665a0a163d9e8a31ff2bf8104c858d67f/tools/perf/chrome_telemetry_build/BUILD.gn

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 25 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/release/scripts/+/44f0e9e8fbffcf785de45004a4d21be03ce858ab

commit 44f0e9e8fbffcf785de45004a4d21be03ce858ab
Author: Mark Mentovai <mark@chromium.org>
Date: Mon Sep 25 17:31:42 2017

Project Member

Comment 8 by bugdroid1@chromium.org, Sep 25 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build/+/7ad6938497dfc0cb299b3466e436186719e5c0eb

commit 7ad6938497dfc0cb299b3466e436186719e5c0eb
Author: Mark Mentovai <mark@chromium.org>
Date: Mon Sep 25 17:32:45 2017

Project Member

Comment 9 by bugdroid1@chromium.org, Sep 25 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/49da7bcb33061c5004800f6e7c1943c78f12b6d0

commit 49da7bcb33061c5004800f6e7c1943c78f12b6d0
Author: Mark Mentovai <mark@chromium.org>
Date: Mon Sep 25 17:48:44 2017

Project Member

Comment 10 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build/+/9352792ed1ebb3604b7f338470b1ba398da5e9af

commit 9352792ed1ebb3604b7f338470b1ba398da5e9af
Author: Ali Tofigh <alito@google.com>
Date: Wed Oct 18 03:25:57 2017

Sign in to add a comment