New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 766915 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

cc/animation - make ElementAnimations use AnimationTicker not AnimationPlayer

Project Member Reported by smcgruer@chromium.org, Sep 20 2017

Issue description

Tracking bug for refactoring cc::ElementAnimations to use cc::AnimationTicker rather than cc::AnimationPlayer. AnimationTicker is the current way to tick sets of animations, and ElementAnimations shouldn't need to know about it.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/419241db11d4b1d1a7e516831f0ebf081960eb89

commit 419241db11d4b1d1a7e516831f0ebf081960eb89
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Wed Oct 04 16:50:17 2017

Refactor cc::ElementAnimations to use AnimationTickers

This is a largely behavior-agnostic change that replaces ElementAnimations
use of AnimationPlayer with AnimationTicker. This allows a lot of pass-through
methods to be removed from AnimationPlayer.

Note that the flow of some method calls has changed, mostly to have AnimationPlayer
APIs called from AnimationTicker rather than calling into it and using the return
value. For example the AnimationPlayer::NotifyAnimationYYY methods are now called
from AnimationTicker.

Bug:  766915 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I688c204f69785030330aa73be0c5707b4e5d3ce0
Reviewed-on: https://chromium-review.googlesource.com/655221
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506416}
[modify] https://crrev.com/419241db11d4b1d1a7e516831f0ebf081960eb89/cc/animation/animation_host.cc
[modify] https://crrev.com/419241db11d4b1d1a7e516831f0ebf081960eb89/cc/animation/animation_player.cc
[modify] https://crrev.com/419241db11d4b1d1a7e516831f0ebf081960eb89/cc/animation/animation_player.h
[modify] https://crrev.com/419241db11d4b1d1a7e516831f0ebf081960eb89/cc/animation/animation_player_unittest.cc
[modify] https://crrev.com/419241db11d4b1d1a7e516831f0ebf081960eb89/cc/animation/animation_ticker.cc
[modify] https://crrev.com/419241db11d4b1d1a7e516831f0ebf081960eb89/cc/animation/animation_ticker.h
[modify] https://crrev.com/419241db11d4b1d1a7e516831f0ebf081960eb89/cc/animation/animation_timeline.cc
[modify] https://crrev.com/419241db11d4b1d1a7e516831f0ebf081960eb89/cc/animation/element_animations.cc
[modify] https://crrev.com/419241db11d4b1d1a7e516831f0ebf081960eb89/cc/animation/element_animations.h
[modify] https://crrev.com/419241db11d4b1d1a7e516831f0ebf081960eb89/cc/animation/element_animations_unittest.cc
[modify] https://crrev.com/419241db11d4b1d1a7e516831f0ebf081960eb89/cc/test/animation_test_common.cc
[modify] https://crrev.com/419241db11d4b1d1a7e516831f0ebf081960eb89/cc/test/animation_test_common.h
[modify] https://crrev.com/419241db11d4b1d1a7e516831f0ebf081960eb89/cc/test/animation_timelines_test_common.cc
[modify] https://crrev.com/419241db11d4b1d1a7e516831f0ebf081960eb89/cc/test/animation_timelines_test_common.h
[modify] https://crrev.com/419241db11d4b1d1a7e516831f0ebf081960eb89/cc/test/layer_tree_test.cc
[modify] https://crrev.com/419241db11d4b1d1a7e516831f0ebf081960eb89/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/419241db11d4b1d1a7e516831f0ebf081960eb89/cc/trees/layer_tree_host_unittest_animation.cc
[modify] https://crrev.com/419241db11d4b1d1a7e516831f0ebf081960eb89/ui/compositor/layer_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment