factory: Toolkit update by Goofy should not call --no_exec. |
|||
Issue descriptionFrom change https://chromium-review.googlesource.com/#/c/chromiumos/platform/factory/+/672264/ . Currently the toolkit update code in Goofy will try to update in its own way, probably because it was done using rsync before. We're now downloading whole installer from Umpire, so the update code should be changed to invoke makeself installer as well. We should move the extra logic of preserving files, if needed, into makeself installer.py, maybe adding a special arg like --upgrade (or change its default behavior).
,
Sep 20 2017
I don't think that's needed. cros_payload maintains toolkit version and that was already checked in IsUpdateAvailable ( https://chromium.googlesource.com/chromiumos/platform/factory/+/master/py/goofy/updater.py#52 ) . The check in https://chromium.googlesource.com/chromiumos/platform/factory/+/master/py/goofy/updater.py#76 is simply a double confirm if the reported version was correct, which I think is not necessary. Or, if you really want, you can run toolkit with --lsm to get version and compare, without extracting whole data.
,
Aug 1
,
Sep 7
this is probably another good first bug |
|||
►
Sign in to add a comment |
|||
Comment 1 by yhong@chromium.org
, Sep 20 2017