New issue
Advanced search Search tips

Issue 766892 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

[CRD iOS] Excessive host list top padding in iOS 11

Project Member Reported by yuweih@chromium.org, Sep 20 2017

Issue description

This starts appearing in iOS 11.

The padding goes away when the SSO drawer is open, and reappears when it is closed.
 
Screen Shot 2017-09-19 at 5.09.01 PM.png
359 KB View Download

Comment 1 by yuweih@chromium.org, Sep 20 2017

There is a bug in material components that adds a 20pt padding to the top of the scroll views.

https://github.com/material-components/material-components-ios/issues/1962

The workaround is to change contentInsetAdjustmentBehavior to Never.
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69e107d5fd3eb4c0dec1cf21b25e0e404b333d8e

commit 69e107d5fd3eb4c0dec1cf21b25e0e404b333d8e
Author: Yuwei Huang <yuweih@chromium.org>
Date: Wed Sep 20 18:23:58 2017

[CRD iOS] Workaround for excessive top padding in the host list

There is a bug in material components that will introduce a 20pt top
padding to the scroll view.

This CL adds a workaround to remove the padding, which should be
removed once the material components bug is fixed.

Bug:  766892 
Change-Id: I69ec4c3ac928363cf10c896f53a5178edf9996e4
Reviewed-on: https://chromium-review.googlesource.com/674446
Reviewed-by: Scott Nichols <nicholss@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503205}
[modify] https://crrev.com/69e107d5fd3eb4c0dec1cf21b25e0e404b333d8e/remoting/ios/app/remoting_view_controller.mm

Comment 3 by yuweih@chromium.org, Sep 20 2017

Currently fixed by a workaround. I'll still keep this bug open until MaterialComponents solve the issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e456c7f612a4b80b28b4a8b63952725ae95c079a

commit e456c7f612a4b80b28b4a8b63952725ae95c079a
Author: Yuwei Huang <yuweih@chromium.org>
Date: Mon Oct 30 20:09:21 2017

[CRD iOS] Remove workaround for excessive host list padding

Given that fixes in both MDC and GoogleKit have already been rolled into
Chromium, the workaround is no longer needed.

Bug:  766892 
Change-Id: I2ba2b09c399bc845f867057c261125cbcc3444ea
Reviewed-on: https://chromium-review.googlesource.com/740879
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512589}
[modify] https://crrev.com/e456c7f612a4b80b28b4a8b63952725ae95c079a/remoting/ios/app/remoting_view_controller.mm

Comment 5 by yuweih@chromium.org, Oct 30 2017

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified Fixed in 34.0.3261.0

Sign in to add a comment