Clean up new -Wnull-pointer-arithmetic Clang warning |
||||||
Issue descriptionThe warning was committed in r313666 Examples from https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinux/builds/9123: FAILED: obj/ppapi/examples/media_stream_video/media_stream_video/media_stream_video.o ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/ppapi/examples/media_stream_video/media_stream_video/media_stream_video.o.d -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=\"313690\" -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DCOMPONENT_BUILD -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -I../.. -Igen -I../../ppapi/lib/gl/include -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -pthread -fcolor-diagnostics -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=1 -m64 -march=x86-64 -Wall -Werror -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -Wno-enum-compare-switch -Wno-tautological-unsigned-zero-compare -O2 -fno-ident -fdata-sections -ffunction-sections -fomit-frame-pointer -g2 -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -std=gnu++14 -fno-rtti -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include --sysroot=../../build/linux/debian_jessie_amd64-sysroot -fno-exceptions -fvisibility-inlines-hidden -c ../../ppapi/examples/media_stream_video/media_stream_video.cc -o obj/ppapi/examples/media_stream_video/media_stream_video/media_stream_video.o ../../ppapi/examples/media_stream_video/media_stream_video.cc:248:30: error: performing pointer arithmetic on a null pointer has undefined behavior if the offset is nonzero [-Werror,-Wnull-pointer-arithmetic] static_cast<float*>(0) + 16); // Skip position coordinates. ~~~~~~~~~~~~~~~~~~~~~~ ^ ../../ppapi/examples/media_stream_video/media_stream_video.cc:267:30: error: performing pointer arithmetic on a null pointer has undefined behavior if the offset is nonzero [-Werror,-Wnull-pointer-arithmetic] static_cast<float*>(0) + 16); // Skip position coordinates. ~~~~~~~~~~~~~~~~~~~~~~ ^ 2 errors generated. [4098/45966] SOLINK ./libppapi_example_cc_stub.so [4099/45965] CXX obj/ppapi/examples/printing/printing/printing.o [4100/45965] SOLINK ./libppapi_example_media_stream_audio.so [4101/45965] CXX obj/ppapi/examples/mouse_lock/mouse_lock/mouse_lock.o [4102/45965] CXX obj/ppapi/examples/threading/threading/threading.o [4103/45965] CXX obj/ppapi/examples/ime/ime/ime.o [4104/45965] CXX obj/ppapi/examples/scripting/scripting/post_message.o [4105/45965] CXX obj/ppapi/examples/url_loader/streaming/stream_to_file.o [4106/45965] CXX obj/ppapi/examples/url_loader/file/streaming.o [4107/45965] CXX obj/ppapi/examples/video_capture/video_capture/video_capture.o FAILED: obj/ppapi/examples/video_capture/video_capture/video_capture.o ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/ppapi/examples/video_capture/video_capture/video_capture.o.d -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=\"313690\" -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DCOMPONENT_BUILD -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -I../.. -Igen -I../../ppapi/lib/gl/include -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -pthread -fcolor-diagnostics -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=1 -m64 -march=x86-64 -Wall -Werror -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -Wno-enum-compare-switch -Wno-tautological-unsigned-zero-compare -O2 -fno-ident -fdata-sections -ffunction-sections -fomit-frame-pointer -g2 -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -std=gnu++14 -fno-rtti -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include --sysroot=../../build/linux/debian_jessie_amd64-sysroot -fno-exceptions -fvisibility-inlines-hidden -c ../../ppapi/examples/video_capture/video_capture.cc -o obj/ppapi/examples/video_capture/video_capture/video_capture.o ../../ppapi/examples/video_capture/video_capture.cc:404:30: error: performing pointer arithmetic on a null pointer has undefined behavior if the offset is nonzero [-Werror,-Wnull-pointer-arithmetic] static_cast<float*>(0) + 8); // Skip position coordinates. ~~~~~~~~~~~~~~~~~~~~~~ ^ 1 error generated. [4108/45965] CXX obj/ppapi/examples/scaling/scaling/scaling.o [4109/45965] CC obj/native_client/src/trusted/validator_ragel/rdfa_validator/validator_x86_64.o [4110/45965] CC obj/native_client/src/trusted/validator_ragel/dfa_validate/validator_x86_64.o [4111/45965] CXX obj/ppapi/examples/video_effects/video_effects/video_effects.o [4112/45965] CXX obj/ppapi/examples/video_decode/stable/video_decode.o FAILED: obj/ppapi/examples/video_decode/stable/video_decode.o ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/ppapi/examples/video_decode/stable/video_decode.o.d -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=\"313690\" -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DCOMPONENT_BUILD -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -I../.. -Igen -I../../ppapi/lib/gl/include -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -pthread -fcolor-diagnostics -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=1 -m64 -march=x86-64 -Wall -Werror -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -Wno-enum-compare-switch -Wno-tautological-unsigned-zero-compare -O2 -fno-ident -fdata-sections -ffunction-sections -fomit-frame-pointer -g2 -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -std=gnu++14 -fno-rtti -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include --sysroot=../../build/linux/debian_jessie_amd64-sysroot -fno-exceptions -fvisibility-inlines-hidden -c ../../ppapi/examples/video_decode/video_decode.cc -o obj/ppapi/examples/video_decode/stable/video_decode.o ../../ppapi/examples/video_decode/video_decode.cc:703:30: error: performing pointer arithmetic on a null pointer has undefined behavior if the offset is nonzero [-Werror,-Wnull-pointer-arithmetic] static_cast<float*>(0) + 8); // Skip position coordinates. ~~~~~~~~~~~~~~~~~~~~~~ ^ 1 error generated. [4113/45965] CXX obj/ppapi/examples/video_decode/dev/video_decode_dev.o FAILED: obj/ppapi/examples/video_decode/dev/video_decode_dev.o ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/ppapi/examples/video_decode/dev/video_decode_dev.o.d -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=\"313690\" -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DCOMPONENT_BUILD -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -I../.. -Igen -I../../ppapi/lib/gl/include -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -pthread -fcolor-diagnostics -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=1 -m64 -march=x86-64 -Wall -Werror -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -Wno-enum-compare-switch -Wno-tautological-unsigned-zero-compare -O2 -fno-ident -fdata-sections -ffunction-sections -fomit-frame-pointer -g2 -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -std=gnu++14 -fno-rtti -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include --sysroot=../../build/linux/debian_jessie_amd64-sysroot -fno-exceptions -fvisibility-inlines-hidden -c ../../ppapi/examples/video_decode/video_decode_dev.cc -o obj/ppapi/examples/video_decode/dev/video_decode_dev.o ../../ppapi/examples/video_decode/video_decode_dev.cc:669:30: error: performing pointer arithmetic on a null pointer has undefined behavior if the offset is nonzero [-Werror,-Wnull-pointer-arithmetic] static_cast<float*>(0) + 8); // Skip position coordinates. ~~~~~~~~~~~~~~~~~~~~~~ ^ 1 error generated.
,
Sep 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a6421c589c9c93d9719787866763c84be80f24e2 commit a6421c589c9c93d9719787866763c84be80f24e2 Author: Hans Wennborg <hans@chromium.org> Date: Wed Sep 20 00:08:01 2017 Clang: Disable new -Wnull-pointer-arithmetic warning TBR=rnk Bug: 766891 Change-Id: I1275ee0d199955d89645248903fdd9451be7f36f Reviewed-on: https://chromium-review.googlesource.com/674038 Reviewed-by: Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#502999} [modify] https://crrev.com/a6421c589c9c93d9719787866763c84be80f24e2/build/config/compiler/BUILD.gn
,
Sep 20 2017
,
Sep 20 2017
,
Feb 15 2018
Don't we want to fix this eventually?
,
Feb 16 2018
Yes, we should. Do we have any master "clean up new warnings" bug I can block this against?
,
Feb 16 2018
I don't think so, but having one sounds like a great idea.
,
Oct 17
The following revision refers to this bug: https://pdfium.googlesource.com/pdfium/+/785a26dc649af80c593f899a606dff4dae7c48fd commit 785a26dc649af80c593f899a606dff4dae7c48fd Author: Takuto Ikuta <tikuta@google.com> Date: Wed Oct 17 17:37:41 2018 Do not do null pointer arithmetic Let me introduce builtin function instead. This is a preparation CL to remove -Wno-null-pointer-arithmetic warning suppression. Bug: chromium:766891 Change-Id: I05434ba0c525fd2fddf916c042d1443b1f25d7d7 Reviewed-on: https://pdfium-review.googlesource.com/c/44191 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> [modify] https://crrev.com/785a26dc649af80c593f899a606dff4dae7c48fd/third_party/base/logging.h
,
Oct 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/076388ee7020a3ba29ac04f41b7e88a95bdfed17 commit 076388ee7020a3ba29ac04f41b7e88a95bdfed17 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Oct 17 19:04:57 2018 Roll src/third_party/pdfium a358d622339d..785a26dc649a (3 commits) https://pdfium.googlesource.com/pdfium.git/+log/a358d622339d..785a26dc649a git log a358d622339d..785a26dc649a --date=short --no-merges --format='%ad %ae %s' 2018-10-17 tikuta@google.com Do not do null pointer arithmetic 2018-10-17 thestig@chromium.org Fix typo in coverage_report.py. 2018-10-17 thestig@chromium.org Fix the static initialization order problem for PartitionAlloc. Created with: gclient setdep -r src/third_party/pdfium@785a26dc649a The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG= chromium:766891 ,chromium:896117 TBR=dsinclair@chromium.org Change-Id: Idbbb57b832cfcdef43607893a607abbce9f23ee6 Reviewed-on: https://chromium-review.googlesource.com/c/1286750 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600506} [modify] https://crrev.com/076388ee7020a3ba29ac04f41b7e88a95bdfed17/DEPS
,
Dec 24
,
Dec 25
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/7f6b3674978d1852e06263821c99403e3259d397 commit 7f6b3674978d1852e06263821c99403e3259d397 Author: Raul Tambre <raul@tambre.ee> Date: Tue Dec 25 16:18:02 2018 Disable null pointer arithmetic warnings for GLES1 conformance tests Required for the rest of Chromium to compile with the warning enabled. Bug: chromium:766891 Change-Id: Ie319df01599434011dc953532a30ad68d6a7c9a3 Reviewed-on: https://chromium-review.googlesource.com/c/1390659 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> [modify] https://crrev.com/7f6b3674978d1852e06263821c99403e3259d397/src/tests/BUILD.gn
,
Dec 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c1ca41f8b57cfed15f739620170b7df3e5bf321 commit 5c1ca41f8b57cfed15f739620170b7df3e5bf321 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Dec 25 18:00:39 2018 Roll src/third_party/angle 844128609315..7f6b3674978d (1 commits) https://chromium.googlesource.com/angle/angle.git/+log/844128609315..7f6b3674978d git log 844128609315..7f6b3674978d --date=short --no-merges --format='%ad %ae %s' 2018-12-25 raul@tambre.ee Disable null pointer arithmetic warnings for GLES1 conformance tests Created with: gclient setdep -r src/third_party/angle@7f6b3674978d The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:766891 TBR=ynovikov@chromium.org Change-Id: I1e2612ce807e3b5487608d24afeb74f50c5d5e64 Reviewed-on: https://chromium-review.googlesource.com/c/1390821 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#618864} [modify] https://crrev.com/5c1ca41f8b57cfed15f739620170b7df3e5bf321/DEPS
,
Jan 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2fcaf0a1e55b010353bcdee64e14911a03010b68 commit 2fcaf0a1e55b010353bcdee64e14911a03010b68 Author: Raul Tambre <raul@tambre.ee> Date: Thu Jan 03 20:14:28 2019 Fix null pointer arithmetic, re-enable -Wnull-pointer-arithmetic Bug: 766891 Change-Id: Ib8cf38fb63d9494f21462ab55ce361775b107322 Reviewed-on: https://chromium-review.googlesource.com/c/1390003 Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Bill Budge <bbudge@chromium.org> Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#619731} [modify] https://crrev.com/2fcaf0a1e55b010353bcdee64e14911a03010b68/build/config/compiler/BUILD.gn [modify] https://crrev.com/2fcaf0a1e55b010353bcdee64e14911a03010b68/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h [modify] https://crrev.com/2fcaf0a1e55b010353bcdee64e14911a03010b68/gpu/command_buffer/service/raster_decoder_unittest_base.h [modify] https://crrev.com/2fcaf0a1e55b010353bcdee64e14911a03010b68/ppapi/examples/media_stream_video/media_stream_video.cc [modify] https://crrev.com/2fcaf0a1e55b010353bcdee64e14911a03010b68/ppapi/examples/video_capture/video_capture.cc [modify] https://crrev.com/2fcaf0a1e55b010353bcdee64e14911a03010b68/ppapi/examples/video_decode/video_decode.cc [modify] https://crrev.com/2fcaf0a1e55b010353bcdee64e14911a03010b68/ppapi/examples/video_decode/video_decode_dev.cc [modify] https://crrev.com/2fcaf0a1e55b010353bcdee64e14911a03010b68/remoting/client/display/gl_canvas.cc [modify] https://crrev.com/2fcaf0a1e55b010353bcdee64e14911a03010b68/remoting/client/plugin/pepper_video_renderer_3d.cc
,
Jan 3
Thanks! |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by h...@chromium.org
, Sep 19 2017