New issue
Advanced search Search tips

Issue 766890 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Decide how to deal with nested janky clients

Project Member Reported by sky@chromium.org, Sep 19 2017

Issue description

If mus detects a client is janky the window-manger is informed. The code in WindowTreeClient that is called in this case can only deal with clients embedded in top-level windows (for example, ash embeds chrome and chrome is janky). The same thing happens if the creator of a top-level window embeds another client (say an OOPIF child frame). Problem is, when this happens WindowTreeClient can't determine the windows because it's supplied a client id it knows nothing about (the window manager only knows the client ids of clients it created to level windows for).

Probably the right thing to do in this case is to change the delegate notification to give the client id of the janky client *and* the client id associated with the top-level and let the WindowManager decide what to do.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26758d923912b7958a4e424f7b597a5b01eaa99b

commit 26758d923912b7958a4e424f7b597a5b01eaa99b
Author: Scott Violet <sky@chromium.org>
Date: Wed Sep 20 01:02:33 2017

chromeos: Make WindowTreeClient::WmClientJankinessChanged() early out

If given a client id it doesn't know about. This scenario happens when
the WM embeds a client and the client embeds another client that is
janky. The fix is slightly tricky and not terribly important now, so
for the time being I'm adding the early out with a bug filed.

BUG=766890
TEST=none

Change-Id: I9a9e1b4822923036e3ecc59d2b7b87845b80491d
Reviewed-on: https://chromium-review.googlesource.com/674037
Reviewed-by: Elliot Glaysher <erg@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503014}
[modify] https://crrev.com/26758d923912b7958a4e424f7b597a5b01eaa99b/ui/aura/mus/window_tree_client.cc

Components: Internals>Services>Ash
Labels: -Proj-Mustash-Mus

Sign in to add a comment