New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 766884 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

headless_browsertests's DisableResourceSchedulerTest.RunAsyncTest failing with VS 2017

Project Member Reported by brucedaw...@chromium.org, Sep 19 2017

Issue description

This test:

headless_browsertests.exe --gtest_filter=DisableResourceSchedulerTest.RunAsyncTest

Fails when built with VS 2017 saying:
../../headless/lib/headless_web_contents_browsertest.cc(1003): error: Value of: http_handler()->urls_requested()
Expected: has 13 elements where
element #0 is equal to "http://foo.com/index.html",
element #1 is equal to "http://foo.com/img0",
element #2 is equal to "http://foo.com/img1",
element #3 is equal to "http://foo.com/img2",
element #4 is equal to "http://foo.com/img3",
element #5 is equal to "http://foo.com/img4",
element #6 is equal to "http://foo.com/img5",
element #7 is equal to "http://foo.com/img6",
element #8 is equal to "http://foo.com/script7",
element #9 is equal to "http://foo.com/img10",
element #10 is equal to "http://foo.com/img11",
element #11 is equal to "http://foo.com/xhr8",
element #12 is equal to "http://foo.com/frame9"
  Actual: { "http://foo.com/index.html", "http://foo.com/img0", "http://foo.com/img1", "http://foo.com/img2", "http://foo.com/img3", "http://foo.com/img4", "http://foo.com/img5", "http://foo.com/xhr8", "http://foo.com/frame9", "http://foo.com/img11", "http://foo.com/img6", "http://foo.com/img10", "http://foo.com/script7" }, whose element #7 doesn't match

It's not immediately obvious but the two lists are identical, just in different orders.

The same failure also hits renderer_side_navigation_headless_browsertests.

 
Blocking: -683729
Labels: -Pri-3 Pri-1
Owner: alexclarke@chromium.org
Status: Assigned (was: Started)
This failure and some other failures started happening on this build (when VS 2017 became the default):
https://build.chromium.org/p/chromium.win/builders/Win10%20Tests%20x64/builds/15967
and stopped happening on this build (when the revert landed):
https://build.chromium.org/p/chromium.win/builders/Win10%20Tests%20x64/builds/16015

However, examination of the history of this test's failures shows that the failures are unrelated to VS 2017:

https://build.chromium.org/p/chromium.win/builders/Win10%20Tests%20x64?numbuilds=200

The test fails more often when VS 2017 is the compiler, but it also failed here when VS 2017 was not the compiler:

https://build.chromium.org/p/chromium.win/builders/Win10%20Tests%20x64/builds/16072

and the test succeeded most of the time when VS 2017 was the compiler.

It looks like the order of requests is not entirely well defined so the assumption of a particular order of resource requests is unjustified. VS 2017 somehow made this more apparent. Investigating this is important because otherwise it will become a fire drill when we do switch to VS 2017.

Reassigning and removing the blocking-683729 tag (although this is still soft-blocking the compiler upgrade).

I'll just disable this test for now.
Okay. Note that two variants of the test were failing - one in headless_browsertests and the other in renderer_side_navigation_headless_browsertests. I didn't check whether it was the same code.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4173db1fba23e252d1972347dd0eb5e5a0c1d63a

commit 4173db1fba23e252d1972347dd0eb5e5a0c1d63a
Author: Alex Clarke <alexclarke@chromium.org>
Date: Thu Sep 21 08:14:19 2017

Disable DisableResourceSchedulerTest which is flaky

Bug:  766884 
Change-Id: I188c3107ff3e626364bc57330971f759eb7b4e74
Reviewed-on: https://chromium-review.googlesource.com/675367
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503385}
[modify] https://crrev.com/4173db1fba23e252d1972347dd0eb5e5a0c1d63a/headless/lib/headless_web_contents_browsertest.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea4ffdbbaf7bb8d64247e0b143ba81e00b2c7d07

commit ea4ffdbbaf7bb8d64247e0b143ba81e00b2c7d07
Author: Alex Clarke <alexclarke@chromium.org>
Date: Fri Nov 03 09:46:13 2017

Fix ResourceDispatcherHostImpl::delegate_ data race

Bug:  776976 ,  766884 
Change-Id: Ia5aaf992a2a3f5d1b6e5c00cdb5ea10452b782f4
Reviewed-on: https://chromium-review.googlesource.com/733094
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513730}
[modify] https://crrev.com/ea4ffdbbaf7bb8d64247e0b143ba81e00b2c7d07/content/browser/browser_main_loop.cc
[modify] https://crrev.com/ea4ffdbbaf7bb8d64247e0b143ba81e00b2c7d07/content/browser/loader/navigation_url_loader_unittest.cc
[modify] https://crrev.com/ea4ffdbbaf7bb8d64247e0b143ba81e00b2c7d07/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/ea4ffdbbaf7bb8d64247e0b143ba81e00b2c7d07/content/browser/loader/resource_dispatcher_host_impl.h
[modify] https://crrev.com/ea4ffdbbaf7bb8d64247e0b143ba81e00b2c7d07/content/browser/loader/resource_dispatcher_host_unittest.cc
[modify] https://crrev.com/ea4ffdbbaf7bb8d64247e0b143ba81e00b2c7d07/content/public/browser/resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/ea4ffdbbaf7bb8d64247e0b143ba81e00b2c7d07/content/public/browser/resource_dispatcher_host_delegate.h
[modify] https://crrev.com/ea4ffdbbaf7bb8d64247e0b143ba81e00b2c7d07/content/public/common/content_switches.cc
[modify] https://crrev.com/ea4ffdbbaf7bb8d64247e0b143ba81e00b2c7d07/content/public/common/content_switches.h
[modify] https://crrev.com/ea4ffdbbaf7bb8d64247e0b143ba81e00b2c7d07/headless/lib/browser/headless_content_browser_client.cc
[modify] https://crrev.com/ea4ffdbbaf7bb8d64247e0b143ba81e00b2c7d07/headless/lib/browser/headless_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/ea4ffdbbaf7bb8d64247e0b143ba81e00b2c7d07/headless/lib/browser/headless_resource_dispatcher_host_delegate.h
[modify] https://crrev.com/ea4ffdbbaf7bb8d64247e0b143ba81e00b2c7d07/headless/lib/headless_content_main_delegate.cc
[modify] https://crrev.com/ea4ffdbbaf7bb8d64247e0b143ba81e00b2c7d07/headless/lib/headless_web_contents_browsertest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment