New issue
Advanced search Search tips

Issue 766878 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task



Sign in to add a comment

Roll FFmpeg for M63

Project Member Reported by chcunningham@chromium.org, Sep 19 2017

Issue description

Tracking bug for FFmpeg roll.
 
Labels: FFmpeg-Roll
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 9 2017

Labels: merge-merged-merge-m63
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/third_party/ffmpeg/+/8220b499df7d880964f978692731bd3640dd60ac

commit 8220b499df7d880964f978692731bd3640dd60ac
Author: Chris Cunningham <chcunningham@chromium.org>
Date: Mon Oct 09 01:05:24 2017

Updating FFmpeg build scripts/configs for M63 roll

Upstream configure introduced a new flag: --disable-autodetect

This flag is now used in build_ffmpeg.py in place of our one-off
disabling of autodetected features.

This makes the merge review a little simpler. Merge's should not show
new CONFIG_* features enabled due to autodetect. Instead, the roller
(me) should audit any new autodected features since the last roll and
explicitly enable any that are desried.

New autodetects for this roll were as follows. None are desired/enabled.
 ALSA support
 Apple AppKit framework
 Apple AVFoundation framework
 Apple CoreImage framework
 libjack support
 sndio support

A diff of configure defines is here:
http://chcunningham-linux.sea.corp.google.com/m63_ffmpeg_config_flag_changes.txt

A few 1's became 0 due to disabled autodetect. None are used in
production:
 CONFIG_AUDIOTOOLBOX
 CONFIG_LIBXCB*

BUG= 766878 

Change-Id: I4bcad267d00849d0b530b62e32b3b28d8be9840b
Reviewed-on: https://chromium-review.googlesource.com/688394
Reviewed-by: John Rummell <jrummell@chromium.org>

[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chrome/linux/mipsel/libavutil/ffversion.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chromium/mac/x64/config.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chrome/linux/arm64/libavutil/ffversion.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chromium/linux/arm/config.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/ChromeOS/linux/arm-neon/libavutil/ffversion.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chromium/linux/ia32/config.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chromium/win/ia32/libavutil/ffversion.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chrome/android/mipsel/config.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chromium/win/ia32/config.asm
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chrome/android/mipsel/libavutil/ffversion.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chromium/mac/x64/libavutil/ffversion.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chrome/win/x64/config.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chrome/linux/x64/config.asm
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/ChromeOS/linux-noasm/x64/config.h
[add] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/libavcodec/autorename_libavcodec_mdct15.c
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/scripts/build_ffmpeg.py
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chrome/win/x64/libavutil/ffversion.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chromium/linux/arm-neon/config.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/ChromeOS/linux/mipsel/libavutil/ffversion.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/ChromeOS/linux/x64/libavutil/ffversion.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chromium/android/x64/libavutil/ffversion.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chrome/linux/arm/libavutil/ffversion.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/ChromeOS/linux/ia32/config.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chrome/linux/x64/config.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chrome/android/mips64el/libavutil/ffversion.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chrome/win/x64/config.asm
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chrome/linux/arm64/config.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chromium/linux/mipsel/config.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/ChromeOS/linux/x64/config.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/ChromeOS/linux/arm/libavutil/ffversion.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chrome/android/x64/config.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/ChromeOS/linux/mipsel/config.h
[add] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/libavcodec/aarch64/autorename_libavcodec_aarch64_sbrdsp_neon.S
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chrome/android/x64/config.asm
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chrome/linux/mipsel/config.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chrome/win/ia32/config.asm
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chrome/android/arm-neon/libavutil/ffversion.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/ChromeOS/linux/x64/config.asm
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chromium/win/ia32/config.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chromium/linux/x64/config.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/ChromeOS/linux/ia32/config.asm
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chrome/android/ia32/libavutil/ffversion.h
[add] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/libavcodec/mips/autorename_libavcodec_mips_videodsp_init.c
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chrome/linux-noasm/x64/libavutil/ffversion.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chrome/android/ia32/config.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/ChromeOS/linux/arm64/config.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chrome/android/arm64/libavutil/ffversion.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chrome/android/arm-neon/config.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chromium/linux/ia32/config.asm
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chromium/linux/x64/config.asm
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chrome/linux/x64/libavutil/ffversion.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chromium/android/ia32/config.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chromium/android/arm64/config.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chrome/linux/ia32/libavutil/ffversion.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chrome/linux-noasm/x64/config.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chromium/android/arm64/libavutil/ffversion.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chromium/win/x64/config.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chromium/linux/x64/libavutil/ffversion.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chromium/linux/arm64/config.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chrome/linux/arm-neon/config.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chromium/linux/mipsel/libavutil/ffversion.h
[add] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/libavcodec/aarch64/autorename_libavcodec_aarch64_aacpsdsp_neon.S
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chrome/mac/x64/libavutil/ffversion.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/ChromeOS/linux/arm-neon/config.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chrome/android/mips64el/config.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/ChromeOS/linux/arm64/libavutil/ffversion.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chromium/linux-noasm/x64/libavutil/ffversion.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/ffmpeg_generated.gni
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chrome/linux/arm/config.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chrome/mac/x64/config.asm
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chromium/linux-noasm/x64/config.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chromium/android/mips64el/config.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chromium/android/ia32/libavutil/ffversion.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chromium/linux/ia32/libavutil/ffversion.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chromium/android/mips64el/libavutil/ffversion.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chrome/win/ia32/libavutil/ffversion.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chromium/win/x64/libavutil/ffversion.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/ChromeOS/linux/ia32/libavutil/ffversion.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chromium/android/mipsel/config.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chromium/win/x64/config.asm
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chromium/android/mipsel/libavutil/ffversion.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/ChromeOS/linux-noasm/x64/libavutil/ffversion.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chrome/mac/x64/config.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chromium/android/x64/config.asm
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chrome/android/arm64/config.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chrome/win/ia32/config.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chrome/linux/arm-neon/libavutil/ffversion.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chromium/android/x64/config.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chromium/linux/arm/libavutil/ffversion.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chrome/linux/ia32/config.asm
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chromium/mac/x64/config.asm
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chromium/android/arm-neon/libavutil/ffversion.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chromium/linux/arm64/libavutil/ffversion.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chrome/linux/ia32/config.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chrome/android/x64/libavutil/ffversion.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/ChromeOS/linux/arm/config.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chromium/linux/arm-neon/libavutil/ffversion.h
[modify] https://crrev.com/8220b499df7d880964f978692731bd3640dd60ac/chromium/config/Chromium/android/arm-neon/config.h

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49e240c638f34c4a456fc2c80697161aeb23548c

commit 49e240c638f34c4a456fc2c80697161aeb23548c
Author: Chris Cunningham <chcunningham@chromium.org>
Date: Wed Oct 11 01:57:28 2017

Roll third_party/ffmpeg and update tests.

Roll takes latest from upstream FFmpeg.

ffmpeg_regression_tests:
- updates pipeline status expectations

pipeline_integration_tests:
- adds kFFmpegRegression pipeline integration test "type" to relax
  duration callback expectaitons
- modify OnBufferingStateChange to allow for underflow/preroll between
  run_loop.Quit() and scoped_task_environment.RunUntilIdle()
- update expected duration for aac test (now more accurate)

BUG= 766878 

Change-Id: I387d9ec695a01489e84651475114ba617b3fb1c5
Reviewed-on: https://chromium-review.googlesource.com/707335
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507861}
[modify] https://crrev.com/49e240c638f34c4a456fc2c80697161aeb23548c/DEPS
[modify] https://crrev.com/49e240c638f34c4a456fc2c80697161aeb23548c/media/ffmpeg/ffmpeg_regression_tests.cc
[modify] https://crrev.com/49e240c638f34c4a456fc2c80697161aeb23548c/media/test/pipeline_integration_test.cc
[modify] https://crrev.com/49e240c638f34c4a456fc2c80697161aeb23548c/media/test/pipeline_integration_test_base.cc
[modify] https://crrev.com/49e240c638f34c4a456fc2c80697161aeb23548c/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-freq-data.html

Status: Verified (was: Started)

Sign in to add a comment