New issue
Advanced search Search tips

Issue 766869 link

Starred by 1 user
Status: Verified
Owner:
yuweih@chromium.org
Closed: Sep 2017
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

[UX review] Sending Ctrl+Alt+Delete should close the settings menu

Project Member Reported by yuweih@chromium.org, Sep 19 2017 
Right now there is no signal that the function worked and users won't be able to see it without manually closing the options menu. Let's do that automatically for them.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c31cebd197d9303a5d39a95005e049e8b92afe96

commit c31cebd197d9303a5d39a95005e049e8b92afe96
Author: Yuwei Huang <yuweih@chromium.org>
Date: Fri Sep 22 19:37:46 2017

[CRD iOS] Close settings menu when keys are injected

This CL closes the settings menu immediately after a key combination is
sent to the host so that the user can immediately see the effect.

Bug:  766869 
Change-Id: I93c6e8aa416baabeba714bddc13bc20ba80defbe
Reviewed-on: https://chromium-review.googlesource.com/674127
Reviewed-by: Scott Nichols <nicholss@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503823}
[modify] https://crrev.com/c31cebd197d9303a5d39a95005e049e8b92afe96/remoting/ios/app/settings/remoting_settings_view_controller.mm

Comment 2 by yuweih@chromium.org, Sep 22 2017

Status: Fixed (was: Assigned)

Comment 3 by ajnolley@chromium.org, Nov 9 2017 

Verified Fixed in 34.0.3261.0

Comment 4 by ajnolley@chromium.org, Nov 15 2017

Status: Verified (was: Fixed)
►

Sign in to add a comment