“Copied Link” text is cut off in “Show less” mode. |
|||
Issue descriptionApp Version: 63.0.3219.0 Canary iOS Version: iOS 11.0 ONLY Device: iPad Pro 12’5 Precondition: Add Chrome-Suggested sites and Chrome Quick Actions to Today’s view. Steps to reproduce: 1.Launch app, go to any website and long tap copy the url 2.Swipe down today’s view Observed results: “Copied Link” text is cut off, when in “Show Less” mode. Expected results: “Copied Link” text should be shown completely in “Show Less” mode. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android:NA Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): M61- New Feature Bug reproducible on the current beta channel build (App Version, iOS Version):M62- Yes 2/5 times only M63- 5/5 consistently Screenshot: https://drive.google.com/a/google.com/file/d/0B6GVWQnhaMClSWs3MTNfb0NvY28/view?usp=sharing https://drive.google.com/a/google.com/file/d/0B6GVWQnhaMClQ0NKNFVKdmFrRk0/view?usp=sharing
,
Oct 3 2017
I've identified this as an issue with -viewWillTransitionToSize:withTransitionCoordinator: not getting called on ios 11 after setting preferredContentSize in -widgetActiveDisplayModeDidChange:withMaximumSize: , when the widget is already at the correct size. I suppose it makes sense (the view isn't in fact transitioning sizes). This wouldn't be a problem if the mode could be set correctly on initialisation, but I've just realised -widgetActiveDisplayMode in extensionContext just returns nil, which gets cast to compact. I'm investigating 1) why widgetActiveDisplayMode returns nil (apple bug?) 2) how to force setting the correct mode on the first call to -widgetActiveDisplayModeDidChange:withMaximumSize: .
,
Oct 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/43bfb92934703fc50e144971a76c9f5610d2dba8 commit 43bfb92934703fc50e144971a76c9f5610d2dba8 Author: Elodie Banel <lod@google.com> Date: Tue Oct 10 09:04:33 2017 Fix setting of widget height constraint In ios 11, |widgetActiveDisplayMode| isn't correctly set in viewDidLoad. Therefore, instead of passing in the initial state on init, set it in viewWillAppear when the property is correct. There is no animation impact to this CL. Bug: 766868 Change-Id: Ieb31d1930c25f464b6dc610c79b936cc8e485967 Reviewed-on: https://chromium-review.googlesource.com/707152 Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Elodie Banel <lod@chromium.org> Cr-Commit-Position: refs/heads/master@{#507622} [modify] https://crrev.com/43bfb92934703fc50e144971a76c9f5610d2dba8/ios/chrome/content_widget_extension/content_widget_view.h [modify] https://crrev.com/43bfb92934703fc50e144971a76c9f5610d2dba8/ios/chrome/content_widget_extension/content_widget_view.mm [modify] https://crrev.com/43bfb92934703fc50e144971a76c9f5610d2dba8/ios/chrome/content_widget_extension/content_widget_view_controller.mm [modify] https://crrev.com/43bfb92934703fc50e144971a76c9f5610d2dba8/ios/chrome/search_widget_extension/search_widget_view.h [modify] https://crrev.com/43bfb92934703fc50e144971a76c9f5610d2dba8/ios/chrome/search_widget_extension/search_widget_view.mm [modify] https://crrev.com/43bfb92934703fc50e144971a76c9f5610d2dba8/ios/chrome/search_widget_extension/search_widget_view_controller.mm
,
Oct 10 2017
,
Oct 17 2017
Verified on iPad Pro 12'5 iOS 11.1 beta on 64.0.3242.0 canary. |
|||
►
Sign in to add a comment |
|||
Comment 1 by linds...@chromium.org
, Sep 20 2017Owner: lod@chromium.org
Status: Assigned (was: Untriaged)