New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 766851 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 767895
issue 774703
issue 776951



Sign in to add a comment

[Findit] Refactor Findit pipelines to use new base pipeline.

Project Member Reported by chanli@chromium.org, Sep 19 2017

Issue description

Refactor Findit pipelines to use new base pipeline.

 

Comment 1 by chanli@chromium.org, Sep 23 2017

Blocking: 767895

Comment 2 by wylieb@chromium.org, Sep 25 2017

Blocking: -767895

Comment 3 by wylieb@chromium.org, Sep 25 2017

Blocking: 767895

Comment 4 by chanli@chromium.org, Oct 14 2017

Blocking: 774703
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/bf186fb938a013e4ad5f173a8f53be9e3677ccf1

commit bf186fb938a013e4ad5f173a8f53be9e3677ccf1
Author: Chan <chanli@chromium.org>
Date: Thu Oct 19 23:15:11 2017

[Findit] Refactor create_revert_cl_pipeline to use new basepipeline.

This is a refactoring change.

Bug:  766851 
Change-Id: Icb2d8d701d88f78ecf517d83d67e9254a9b1fdf1
Reviewed-on: https://chromium-review.googlesource.com/723677
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/bf186fb938a013e4ad5f173a8f53be9e3677ccf1/appengine/findit/waterfall/create_revert_cl_pipeline.py
[modify] https://crrev.com/bf186fb938a013e4ad5f173a8f53be9e3677ccf1/appengine/findit/services/revert.py
[modify] https://crrev.com/bf186fb938a013e4ad5f173a8f53be9e3677ccf1/appengine/findit/pipelines/compile_failure/revert_and_notify_compile_culprit_pipeline.py
[modify] https://crrev.com/bf186fb938a013e4ad5f173a8f53be9e3677ccf1/appengine/findit/pipelines/compile_failure/test/revert_and_notify_compile_culprit_pipeline_test.py
[add] https://crrev.com/bf186fb938a013e4ad5f173a8f53be9e3677ccf1/appengine/findit/pipelines/pipeline_inputs_and_outputs.py
[modify] https://crrev.com/bf186fb938a013e4ad5f173a8f53be9e3677ccf1/appengine/findit/waterfall/test/create_revert_cl_pipeline_test.py
[modify] https://crrev.com/bf186fb938a013e4ad5f173a8f53be9e3677ccf1/appengine/findit/services/test/revert_test.py
[modify] https://crrev.com/bf186fb938a013e4ad5f173a8f53be9e3677ccf1/appengine/findit/waterfall/test/revert_and_notify_culprit_pipeline_test.py
[modify] https://crrev.com/bf186fb938a013e4ad5f173a8f53be9e3677ccf1/appengine/findit/waterfall/revert_and_notify_culprit_pipeline.py

Comment 6 by chanli@chromium.org, Oct 20 2017

Blocking: 776951
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 2 2017

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/2f462c2279eabc5819d9d17f04dd0e1761089323

commit 2f462c2279eabc5819d9d17f04dd0e1761089323
Author: Chan <chanli@chromium.org>
Date: Thu Nov 02 23:47:49 2017

[Findit] refactor send_notification_to_irc_pipeline to use new BasePipeline.

And also separate logic to services/irc.py.

This is a refactoring CL.

Bug:  766851 
Change-Id: I591a08621ad503d8917223f731f0b17ce21f3745
Reviewed-on: https://chromium-review.googlesource.com/729468
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>

[add] https://crrev.com/2f462c2279eabc5819d9d17f04dd0e1761089323/appengine/findit/services/irc.py
[modify] https://crrev.com/2f462c2279eabc5819d9d17f04dd0e1761089323/appengine/findit/waterfall/test/send_notification_to_irc_pipeline_test.py
[modify] https://crrev.com/2f462c2279eabc5819d9d17f04dd0e1761089323/appengine/findit/waterfall/send_notification_to_irc_pipeline.py
[modify] https://crrev.com/2f462c2279eabc5819d9d17f04dd0e1761089323/appengine/findit/pipelines/compile_failure/revert_and_notify_compile_culprit_pipeline.py
[modify] https://crrev.com/2f462c2279eabc5819d9d17f04dd0e1761089323/appengine/findit/pipelines/compile_failure/test/revert_and_notify_compile_culprit_pipeline_test.py
[modify] https://crrev.com/2f462c2279eabc5819d9d17f04dd0e1761089323/appengine/findit/pipelines/pipeline_inputs_and_outputs.py
[add] https://crrev.com/2f462c2279eabc5819d9d17f04dd0e1761089323/appengine/findit/services/test/irc_test.py

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/af44996552da72380e4702d2cd32ff71d3ca4f9a

commit af44996552da72380e4702d2cd32ff71d3ca4f9a
Author: Chan <chanli@chromium.org>
Date: Fri Nov 03 01:06:04 2017

[Findit] Refactor send_notification_for_culprit_pipeline to use new BasePipeline.

And also:

1. fully use the separated pipelines for the wrapper pipeline of reverting and sending notifications.
2. Separate logic of sending notifications to services/gerrit.py (originally was revert.py)

This is a refactoring CL.

Bug:  766851 
Change-Id: I776314d64a8a24283be2ee7a0572252dd05bc867
Reviewed-on: https://chromium-review.googlesource.com/730571
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/af44996552da72380e4702d2cd32ff71d3ca4f9a/appengine/findit/waterfall/create_revert_cl_pipeline.py
[modify] https://crrev.com/af44996552da72380e4702d2cd32ff71d3ca4f9a/appengine/findit/services/irc.py
[modify] https://crrev.com/af44996552da72380e4702d2cd32ff71d3ca4f9a/appengine/findit/waterfall/test/send_notification_to_irc_pipeline_test.py
[modify] https://crrev.com/af44996552da72380e4702d2cd32ff71d3ca4f9a/appengine/findit/waterfall/test/submit_revert_cl_pipeline_test.py
[modify] https://crrev.com/af44996552da72380e4702d2cd32ff71d3ca4f9a/appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py
[modify] https://crrev.com/af44996552da72380e4702d2cd32ff71d3ca4f9a/appengine/findit/pipelines/test_failure/test/revert_and_notify_test_culprit_pipeline_test.py
[delete] https://crrev.com/2b54e247a6455e79d2df5166d543ad119fb8d807/appengine/findit/waterfall/test/revert_and_notify_culprit_pipeline_test.py
[modify] https://crrev.com/af44996552da72380e4702d2cd32ff71d3ca4f9a/appengine/findit/pipelines/compile_failure/revert_and_notify_compile_culprit_pipeline.py
[modify] https://crrev.com/af44996552da72380e4702d2cd32ff71d3ca4f9a/appengine/findit/waterfall/test/send_notification_for_culprit_pipeline_test.py
[modify] https://crrev.com/af44996552da72380e4702d2cd32ff71d3ca4f9a/appengine/findit/waterfall/send_notification_for_culprit_pipeline.py
[modify] https://crrev.com/af44996552da72380e4702d2cd32ff71d3ca4f9a/appengine/findit/pipelines/compile_failure/test/revert_and_notify_compile_culprit_pipeline_test.py
[modify] https://crrev.com/af44996552da72380e4702d2cd32ff71d3ca4f9a/appengine/findit/waterfall/identify_try_job_culprit_pipeline.py
[modify] https://crrev.com/af44996552da72380e4702d2cd32ff71d3ca4f9a/appengine/findit/pipelines/pipeline_inputs_and_outputs.py
[modify] https://crrev.com/af44996552da72380e4702d2cd32ff71d3ca4f9a/appengine/findit/waterfall/test/create_revert_cl_pipeline_test.py
[rename] https://crrev.com/af44996552da72380e4702d2cd32ff71d3ca4f9a/appengine/findit/services/test/gerrit_test.py
[modify] https://crrev.com/af44996552da72380e4702d2cd32ff71d3ca4f9a/appengine/findit/pipelines/test_failure/revert_and_notify_test_culprit_pipeline.py
[rename] https://crrev.com/af44996552da72380e4702d2cd32ff71d3ca4f9a/appengine/findit/services/gerrit.py
[modify] https://crrev.com/af44996552da72380e4702d2cd32ff71d3ca4f9a/appengine/findit/waterfall/submit_revert_cl_pipeline.py
[delete] https://crrev.com/2b54e247a6455e79d2df5166d543ad119fb8d807/appengine/findit/waterfall/revert_and_notify_culprit_pipeline.py
[modify] https://crrev.com/af44996552da72380e4702d2cd32ff71d3ca4f9a/appengine/findit/services/test/irc_test.py

Project Member

Comment 10 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/94fdd3cf0401f60385171647ec399145f89df013

commit 94fdd3cf0401f60385171647ec399145f89df013
Author: Chan <chanli@chromium.org>
Date: Thu Nov 09 19:03:48 2017

[Findit] Refactor revert_and_notify_compile_culprit_pipeline to use New BasePipeline.

Also changed structured_object to properly handle ToSerializable for situation like a dict of StructuredObjects or a list of StructuredObjects.
Also moved some functions to more appropriate module.

Bug:  766851 
Change-Id: Ie4e215a8d5b2bdb86dde7d9a5f356bbbd62a6f7a
Reviewed-on: https://chromium-review.googlesource.com/734280
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/94fdd3cf0401f60385171647ec399145f89df013/appengine/findit/libs/structured_object.py
[modify] https://crrev.com/94fdd3cf0401f60385171647ec399145f89df013/appengine/findit/pipelines/compile_failure/test/revert_and_notify_compile_culprit_pipeline_test.py
[add] https://crrev.com/94fdd3cf0401f60385171647ec399145f89df013/appengine/findit/services/test/git_test.py
[modify] https://crrev.com/94fdd3cf0401f60385171647ec399145f89df013/appengine/findit/services/build_failure_analysis.py
[modify] https://crrev.com/94fdd3cf0401f60385171647ec399145f89df013/appengine/findit/pipelines/compile_failure/test/identify_compile_try_job_culprit_pipeline_test.py
[modify] https://crrev.com/94fdd3cf0401f60385171647ec399145f89df013/appengine/findit/services/test/try_job_test.py
[modify] https://crrev.com/94fdd3cf0401f60385171647ec399145f89df013/appengine/findit/pipelines/compile_failure/revert_and_notify_compile_culprit_pipeline.py
[add] https://crrev.com/94fdd3cf0401f60385171647ec399145f89df013/appengine/findit/services/git.py
[modify] https://crrev.com/94fdd3cf0401f60385171647ec399145f89df013/appengine/findit/services/test/build_failure_analysis_test.py
[modify] https://crrev.com/94fdd3cf0401f60385171647ec399145f89df013/appengine/findit/libs/test/structured_object_test.py
[modify] https://crrev.com/94fdd3cf0401f60385171647ec399145f89df013/appengine/findit/pipelines/pipeline_inputs_and_outputs.py
[modify] https://crrev.com/94fdd3cf0401f60385171647ec399145f89df013/appengine/findit/services/test/gerrit_test.py
[modify] https://crrev.com/94fdd3cf0401f60385171647ec399145f89df013/appengine/findit/pipelines/compile_failure/identify_compile_try_job_culprit_pipeline.py
[modify] https://crrev.com/94fdd3cf0401f60385171647ec399145f89df013/appengine/findit/services/try_job.py

Project Member

Comment 13 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/1f10693f2b722cb73622ab7b45be8f6dd2ee182d

commit 1f10693f2b722cb73622ab7b45be8f6dd2ee182d
Author: Chan <chanli@chromium.org>
Date: Tue Nov 14 23:04:53 2017

[Findit] Refactor pipelines to schedule try jobs (part 1/2)

1. Move logics to coresponding service modules
2. Remove scheduleTryJobPipeline

Bug:  766851 
Change-Id: If3a9cb324d42c3839abe2311d3548b32a50493dd
Reviewed-on: https://chromium-review.googlesource.com/759175
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Brandon Wylie <wylieb@chromium.org>

[modify] https://crrev.com/1f10693f2b722cb73622ab7b45be8f6dd2ee182d/appengine/findit/services/test/try_job_test.py
[modify] https://crrev.com/1f10693f2b722cb73622ab7b45be8f6dd2ee182d/appengine/findit/services/compile_failure/compile_try_job.py
[modify] https://crrev.com/1f10693f2b722cb73622ab7b45be8f6dd2ee182d/appengine/findit/waterfall/flake/process_flake_try_job_result_pipeline.py
[modify] https://crrev.com/1f10693f2b722cb73622ab7b45be8f6dd2ee182d/appengine/findit/waterfall/flake/test/process_flake_try_job_result_pipeline_test.py
[modify] https://crrev.com/1f10693f2b722cb73622ab7b45be8f6dd2ee182d/appengine/findit/pipelines/compile_failure/start_compile_try_job_pipeline.py
[modify] https://crrev.com/1f10693f2b722cb73622ab7b45be8f6dd2ee182d/appengine/findit/waterfall/test/schedule_test_try_job_pipeline_test.py
[add] https://crrev.com/1f10693f2b722cb73622ab7b45be8f6dd2ee182d/appengine/findit/services/monitoring.py
[modify] https://crrev.com/1f10693f2b722cb73622ab7b45be8f6dd2ee182d/appengine/findit/waterfall/flake/test/recursive_flake_try_job_pipeline_test.py
[modify] https://crrev.com/1f10693f2b722cb73622ab7b45be8f6dd2ee182d/appengine/findit/services/compile_failure/test/compile_try_job_test.py
[modify] https://crrev.com/1f10693f2b722cb73622ab7b45be8f6dd2ee182d/appengine/findit/waterfall/flake/test/schedule_flake_try_job_pipeline_test.py
[modify] https://crrev.com/1f10693f2b722cb73622ab7b45be8f6dd2ee182d/appengine/findit/pipelines/test_failure/start_test_try_job_pipeline.py
[modify] https://crrev.com/1f10693f2b722cb73622ab7b45be8f6dd2ee182d/appengine/findit/waterfall/flake/recursive_flake_try_job_pipeline.py
[modify] https://crrev.com/1f10693f2b722cb73622ab7b45be8f6dd2ee182d/appengine/findit/waterfall/rerun_tryjob_pipeline.py
[modify] https://crrev.com/1f10693f2b722cb73622ab7b45be8f6dd2ee182d/appengine/findit/waterfall/test/schedule_compile_try_job_pipeline_test.py
[add] https://crrev.com/1f10693f2b722cb73622ab7b45be8f6dd2ee182d/appengine/findit/services/test/monitoring_test.py
[delete] https://crrev.com/44a4189fab8c9bc039a6b736aab70981f611c097/appengine/findit/waterfall/test/schedule_try_job_pipeline_test.py
[delete] https://crrev.com/44a4189fab8c9bc039a6b736aab70981f611c097/appengine/findit/waterfall/schedule_try_job_pipeline.py
[modify] https://crrev.com/1f10693f2b722cb73622ab7b45be8f6dd2ee182d/appengine/findit/services/try_job.py
[modify] https://crrev.com/1f10693f2b722cb73622ab7b45be8f6dd2ee182d/appengine/findit/services/test_failure/test_try_job.py
[rename] https://crrev.com/1f10693f2b722cb73622ab7b45be8f6dd2ee182d/appengine/findit/services/flake_failure/flake_try_job.py
[modify] https://crrev.com/1f10693f2b722cb73622ab7b45be8f6dd2ee182d/appengine/findit/waterfall/test/rerun_tryjob_pipeline_test.py
[rename] https://crrev.com/1f10693f2b722cb73622ab7b45be8f6dd2ee182d/appengine/findit/services/flake_failure/test/flake_try_job_test.py
[modify] https://crrev.com/1f10693f2b722cb73622ab7b45be8f6dd2ee182d/appengine/findit/pipelines/compile_failure/test/start_compile_try_job_pipeline_test.py
[modify] https://crrev.com/1f10693f2b722cb73622ab7b45be8f6dd2ee182d/appengine/findit/pipelines/test_failure/test/start_test_try_job_pipeline_test.py
[modify] https://crrev.com/1f10693f2b722cb73622ab7b45be8f6dd2ee182d/appengine/findit/waterfall/flake/schedule_flake_try_job_pipeline.py
[modify] https://crrev.com/1f10693f2b722cb73622ab7b45be8f6dd2ee182d/appengine/findit/waterfall/schedule_compile_try_job_pipeline.py
[modify] https://crrev.com/1f10693f2b722cb73622ab7b45be8f6dd2ee182d/appengine/findit/waterfall/schedule_test_try_job_pipeline.py
[modify] https://crrev.com/1f10693f2b722cb73622ab7b45be8f6dd2ee182d/appengine/findit/services/test_failure/test/test_try_job_test.py

Project Member

Comment 14 by bugdroid1@chromium.org, Nov 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/9362ae533121cbcb8a15477e3955a457aef41f36

commit 9362ae533121cbcb8a15477e3955a457aef41f36
Author: Chan <chanli@chromium.org>
Date: Thu Nov 16 22:58:40 2017

[Findit] Refactor schedule try job pipelines to use new BasePipeline. (2/2)

1. Move schedule_compile_try_job_pipeline and schedule_test_try_job_pipeline to each pipeline directory.
2. Make both pipelines to use new BasePipeline.

Bug:766851
Change-Id: I49ea004046b906614e573c753878460d41006379
Reviewed-on: https://chromium-review.googlesource.com/769677
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/9362ae533121cbcb8a15477e3955a457aef41f36/appengine/findit/services/test/try_job_test.py
[modify] https://crrev.com/9362ae533121cbcb8a15477e3955a457aef41f36/appengine/findit/services/compile_failure/compile_try_job.py
[modify] https://crrev.com/9362ae533121cbcb8a15477e3955a457aef41f36/appengine/findit/pipelines/compile_failure/start_compile_try_job_pipeline.py
[delete] https://crrev.com/600f4e13d34078a51e410e1f2193b34547289e82/appengine/findit/waterfall/test/schedule_test_try_job_pipeline_test.py
[modify] https://crrev.com/9362ae533121cbcb8a15477e3955a457aef41f36/appengine/findit/services/compile_failure/test/compile_try_job_test.py
[modify] https://crrev.com/9362ae533121cbcb8a15477e3955a457aef41f36/appengine/findit/pipelines/test_failure/start_test_try_job_pipeline.py
[modify] https://crrev.com/9362ae533121cbcb8a15477e3955a457aef41f36/appengine/findit/pipelines/test_failure/test/revert_and_notify_test_culprit_pipeline_test.py
[delete] https://crrev.com/600f4e13d34078a51e410e1f2193b34547289e82/appengine/findit/waterfall/test/schedule_compile_try_job_pipeline_test.py
[add] https://crrev.com/9362ae533121cbcb8a15477e3955a457aef41f36/appengine/findit/pipelines/test_failure/schedule_test_try_job_pipeline.py
[add] https://crrev.com/9362ae533121cbcb8a15477e3955a457aef41f36/appengine/findit/services/test/parameters_test.py
[modify] https://crrev.com/9362ae533121cbcb8a15477e3955a457aef41f36/appengine/findit/common/exceptions.py
[modify] https://crrev.com/9362ae533121cbcb8a15477e3955a457aef41f36/appengine/findit/services/try_job.py
[add] https://crrev.com/9362ae533121cbcb8a15477e3955a457aef41f36/appengine/findit/pipelines/compile_failure/test/schedule_compile_try_job_pipeline_test.py
[modify] https://crrev.com/9362ae533121cbcb8a15477e3955a457aef41f36/appengine/findit/services/test_failure/test_try_job.py
[add] https://crrev.com/9362ae533121cbcb8a15477e3955a457aef41f36/appengine/findit/pipelines/test_failure/test/schedule_test_try_job_pipeline_test.py
[modify] https://crrev.com/9362ae533121cbcb8a15477e3955a457aef41f36/appengine/findit/waterfall/test/rerun_tryjob_pipeline_test.py
[modify] https://crrev.com/9362ae533121cbcb8a15477e3955a457aef41f36/appengine/findit/services/parameters.py
[modify] https://crrev.com/9362ae533121cbcb8a15477e3955a457aef41f36/appengine/findit/pipelines/compile_failure/test/start_compile_try_job_pipeline_test.py
[add] https://crrev.com/9362ae533121cbcb8a15477e3955a457aef41f36/appengine/findit/pipelines/compile_failure/schedule_compile_try_job_pipeline.py
[modify] https://crrev.com/9362ae533121cbcb8a15477e3955a457aef41f36/appengine/findit/pipelines/test_failure/test/start_test_try_job_pipeline_test.py
[modify] https://crrev.com/9362ae533121cbcb8a15477e3955a457aef41f36/appengine/findit/waterfall/rerun_tryjob_pipeline.py
[delete] https://crrev.com/600f4e13d34078a51e410e1f2193b34547289e82/appengine/findit/waterfall/schedule_compile_try_job_pipeline.py
[delete] https://crrev.com/600f4e13d34078a51e410e1f2193b34547289e82/appengine/findit/waterfall/schedule_test_try_job_pipeline.py
[modify] https://crrev.com/9362ae533121cbcb8a15477e3955a457aef41f36/appengine/findit/services/test_failure/test/test_try_job_test.py

Project Member

Comment 15 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/68ec397c6303c023a17107471eceef545826c4c5

commit 68ec397c6303c023a17107471eceef545826c4c5
Author: Chan <chanli@chromium.org>
Date: Tue Nov 28 19:23:20 2017

[Findit] Merge scheduling and monitoring compile try job pipelines.

1. Merge scheduling and monitoring compile try job pipelines into run_compile_try_job_pipeline
2. Make the new pipeline to inherite from new AsynchronousPipeline

Bug:  788002 ,  766851 
Change-Id: If50a05d837a7188356f37dd8a18f5103d3917b0a
Reviewed-on: https://chromium-review.googlesource.com/791490
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/68ec397c6303c023a17107471eceef545826c4c5/appengine/findit/model/base_try_job_data.py
[modify] https://crrev.com/68ec397c6303c023a17107471eceef545826c4c5/appengine/findit/waterfall/test/rerun_tryjob_pipeline_test.py
[modify] https://crrev.com/68ec397c6303c023a17107471eceef545826c4c5/appengine/findit/pipelines/compile_failure/test/identify_compile_try_job_culprit_pipeline_test.py
[modify] https://crrev.com/68ec397c6303c023a17107471eceef545826c4c5/appengine/findit/services/test/try_job_test.py
[modify] https://crrev.com/68ec397c6303c023a17107471eceef545826c4c5/appengine/findit/services/compile_failure/compile_try_job.py
[modify] https://crrev.com/68ec397c6303c023a17107471eceef545826c4c5/appengine/findit/services/parameters.py
[add] https://crrev.com/68ec397c6303c023a17107471eceef545826c4c5/appengine/findit/pipelines/compile_failure/run_compile_try_job_pipeline.py
[modify] https://crrev.com/68ec397c6303c023a17107471eceef545826c4c5/appengine/findit/pipelines/compile_failure/test/start_compile_try_job_pipeline_test.py
[delete] https://crrev.com/2b4642d0ad9c835dd8c403e8271aab040919870e/appengine/findit/pipelines/compile_failure/schedule_compile_try_job_pipeline.py
[add] https://crrev.com/68ec397c6303c023a17107471eceef545826c4c5/appengine/findit/pipelines/compile_failure/test/run_compile_try_job_pipeline_test.py
[modify] https://crrev.com/68ec397c6303c023a17107471eceef545826c4c5/appengine/findit/pipelines/compile_failure/start_compile_try_job_pipeline.py
[modify] https://crrev.com/68ec397c6303c023a17107471eceef545826c4c5/appengine/findit/waterfall/rerun_tryjob_pipeline.py
[modify] https://crrev.com/68ec397c6303c023a17107471eceef545826c4c5/appengine/findit/gae_libs/pipelines.py
[modify] https://crrev.com/68ec397c6303c023a17107471eceef545826c4c5/appengine/findit/pipelines/compile_failure/identify_compile_try_job_culprit_pipeline.py
[modify] https://crrev.com/68ec397c6303c023a17107471eceef545826c4c5/appengine/findit/services/try_job.py
[delete] https://crrev.com/2b4642d0ad9c835dd8c403e8271aab040919870e/appengine/findit/pipelines/compile_failure/test/schedule_compile_try_job_pipeline_test.py

Project Member

Comment 16 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/e4840fe3bfc644059b39eede24c02729883d013f

commit e4840fe3bfc644059b39eede24c02729883d013f
Author: Chan <chanli@chromium.org>
Date: Tue Nov 28 20:30:03 2017

[Findit] Refactor identify_compile_try_job_culprit_pipeline to use new BasePipeline.

Bug:  766851 
Change-Id: I2deaa0532f0d0c78f33cea721df84ac250a30ce2
Reviewed-on: https://chromium-review.googlesource.com/777466
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/e4840fe3bfc644059b39eede24c02729883d013f/appengine/findit/libs/structured_object.py
[modify] https://crrev.com/e4840fe3bfc644059b39eede24c02729883d013f/appengine/findit/services/compile_failure/test/compile_try_job_test.py
[modify] https://crrev.com/e4840fe3bfc644059b39eede24c02729883d013f/appengine/findit/services/build_failure_analysis.py
[modify] https://crrev.com/e4840fe3bfc644059b39eede24c02729883d013f/appengine/findit/pipelines/compile_failure/test/identify_compile_try_job_culprit_pipeline_test.py
[modify] https://crrev.com/e4840fe3bfc644059b39eede24c02729883d013f/appengine/findit/services/compile_failure/compile_try_job.py
[modify] https://crrev.com/e4840fe3bfc644059b39eede24c02729883d013f/appengine/findit/services/parameters.py
[delete] https://crrev.com/cad0bc77c68e44f39a3ed15c8e11f70b536f9a74/appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py
[modify] https://crrev.com/e4840fe3bfc644059b39eede24c02729883d013f/appengine/findit/pipelines/compile_failure/run_compile_try_job_pipeline.py
[modify] https://crrev.com/e4840fe3bfc644059b39eede24c02729883d013f/appengine/findit/pipelines/compile_failure/test/start_compile_try_job_pipeline_test.py
[modify] https://crrev.com/e4840fe3bfc644059b39eede24c02729883d013f/appengine/findit/libs/test/structured_object_test.py
[modify] https://crrev.com/e4840fe3bfc644059b39eede24c02729883d013f/appengine/findit/pipelines/compile_failure/test/run_compile_try_job_pipeline_test.py
[delete] https://crrev.com/cad0bc77c68e44f39a3ed15c8e11f70b536f9a74/appengine/findit/waterfall/identify_try_job_culprit_pipeline.py
[modify] https://crrev.com/e4840fe3bfc644059b39eede24c02729883d013f/appengine/findit/pipelines/compile_failure/start_compile_try_job_pipeline.py
[modify] https://crrev.com/e4840fe3bfc644059b39eede24c02729883d013f/appengine/findit/services/test/build_failure_analysis_test.py
[modify] https://crrev.com/e4840fe3bfc644059b39eede24c02729883d013f/appengine/findit/gae_libs/pipelines.py
[modify] https://crrev.com/e4840fe3bfc644059b39eede24c02729883d013f/appengine/findit/pipelines/compile_failure/identify_compile_try_job_culprit_pipeline.py
[modify] https://crrev.com/e4840fe3bfc644059b39eede24c02729883d013f/appengine/findit/services/try_job.py
[modify] https://crrev.com/e4840fe3bfc644059b39eede24c02729883d013f/appengine/findit/services/test_failure/test_try_job.py

Project Member

Comment 17 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/b864c5a49e6c287ed0e7afb1d1f4449cf71aa360

commit b864c5a49e6c287ed0e7afb1d1f4449cf71aa360
Author: Chan <chanli@chromium.org>
Date: Tue Nov 28 23:23:13 2017

[Findit] Merge scheduling and monitoring test try job pipelines.

1. Merge scheduling and monitoring test try job pipelines into run_test_try_job_pipeline
2. Make the new pipeline to inherite from new AsynchronousPipeline

Bug:  788002 ,  766851 
Change-Id: Iee05b1c031b2fcfdcd7adcbb10fe46be9fcc7cb4
Reviewed-on: https://chromium-review.googlesource.com/792012
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/b864c5a49e6c287ed0e7afb1d1f4449cf71aa360/appengine/findit/waterfall/test/rerun_tryjob_pipeline_test.py
[delete] https://crrev.com/18f03641b841e47103cc03707586e740882872d0/appengine/findit/pipelines/test_failure/test/schedule_test_try_job_pipeline_test.py
[add] https://crrev.com/b864c5a49e6c287ed0e7afb1d1f4449cf71aa360/appengine/findit/pipelines/test_failure/run_test_try_job_pipeline.py
[delete] https://crrev.com/18f03641b841e47103cc03707586e740882872d0/appengine/findit/pipelines/test_failure/schedule_test_try_job_pipeline.py
[modify] https://crrev.com/b864c5a49e6c287ed0e7afb1d1f4449cf71aa360/appengine/findit/pipelines/test_failure/identify_test_try_job_culprit_pipeline.py
[modify] https://crrev.com/b864c5a49e6c287ed0e7afb1d1f4449cf71aa360/appengine/findit/services/parameters.py
[add] https://crrev.com/b864c5a49e6c287ed0e7afb1d1f4449cf71aa360/appengine/findit/pipelines/test_failure/test/run_test_try_job_pipeline_test.py
[modify] https://crrev.com/b864c5a49e6c287ed0e7afb1d1f4449cf71aa360/appengine/findit/pipelines/test_failure/start_test_try_job_pipeline.py
[modify] https://crrev.com/b864c5a49e6c287ed0e7afb1d1f4449cf71aa360/appengine/findit/pipelines/compile_failure/test/run_compile_try_job_pipeline_test.py
[modify] https://crrev.com/b864c5a49e6c287ed0e7afb1d1f4449cf71aa360/appengine/findit/pipelines/test_failure/test/start_test_try_job_pipeline_test.py
[modify] https://crrev.com/b864c5a49e6c287ed0e7afb1d1f4449cf71aa360/appengine/findit/waterfall/rerun_tryjob_pipeline.py
[modify] https://crrev.com/b864c5a49e6c287ed0e7afb1d1f4449cf71aa360/appengine/findit/services/test_failure/test/test_try_job_test.py
[modify] https://crrev.com/b864c5a49e6c287ed0e7afb1d1f4449cf71aa360/appengine/findit/pipelines/test_failure/test/identify_test_try_job_culprit_pipeline_test.py
[modify] https://crrev.com/b864c5a49e6c287ed0e7afb1d1f4449cf71aa360/appengine/findit/services/test_failure/test_try_job.py

Project Member

Comment 18 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/6ce4d0da83f31ad32a2c9d0a01b7bdb4560b6699

commit 6ce4d0da83f31ad32a2c9d0a01b7bdb4560b6699
Author: Chan <chanli@chromium.org>
Date: Tue Nov 28 23:51:03 2017

[Findit] Refactor identify_test_try_job_culprit_pipeline to use new BasePipeline.

Bug:  766851 
Change-Id: Ie42b16be719de67f574dba4bfcf7a04d28f72b99
Reviewed-on: https://chromium-review.googlesource.com/792540
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/6ce4d0da83f31ad32a2c9d0a01b7bdb4560b6699/appengine/findit/pipelines/test_failure/test/run_test_try_job_pipeline_test.py
[modify] https://crrev.com/6ce4d0da83f31ad32a2c9d0a01b7bdb4560b6699/appengine/findit/services/test/try_job_test.py
[modify] https://crrev.com/6ce4d0da83f31ad32a2c9d0a01b7bdb4560b6699/appengine/findit/pipelines/test_failure/identify_test_try_job_culprit_pipeline.py
[modify] https://crrev.com/6ce4d0da83f31ad32a2c9d0a01b7bdb4560b6699/appengine/findit/services/parameters.py
[modify] https://crrev.com/6ce4d0da83f31ad32a2c9d0a01b7bdb4560b6699/appengine/findit/pipelines/test_failure/start_test_try_job_pipeline.py
[modify] https://crrev.com/6ce4d0da83f31ad32a2c9d0a01b7bdb4560b6699/appengine/findit/services/git.py
[modify] https://crrev.com/6ce4d0da83f31ad32a2c9d0a01b7bdb4560b6699/appengine/findit/pipelines/test_failure/test/start_test_try_job_pipeline_test.py
[modify] https://crrev.com/6ce4d0da83f31ad32a2c9d0a01b7bdb4560b6699/appengine/findit/services/test_failure/test/test_try_job_test.py
[modify] https://crrev.com/6ce4d0da83f31ad32a2c9d0a01b7bdb4560b6699/appengine/findit/services/try_job.py
[modify] https://crrev.com/6ce4d0da83f31ad32a2c9d0a01b7bdb4560b6699/appengine/findit/pipelines/test_failure/test/identify_test_try_job_culprit_pipeline_test.py
[modify] https://crrev.com/6ce4d0da83f31ad32a2c9d0a01b7bdb4560b6699/appengine/findit/services/test_failure/test_try_job.py

Project Member

Comment 19 by bugdroid1@chromium.org, Dec 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/07700732c4187a25b3e300f99469608eb36a24df

commit 07700732c4187a25b3e300f99469608eb36a24df
Author: Chan <chanli@chromium.org>
Date: Mon Dec 04 17:03:54 2017

[Findit] Make HeuristicAnalysisForCompilePipeline inherit from new BasePipeline.

Bug:  766851 
Change-Id: Id0f49b5d668a9e09f613c1c103d8e8496195dcc3
Reviewed-on: https://chromium-review.googlesource.com/798750
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/07700732c4187a25b3e300f99469608eb36a24df/appengine/findit/libs/structured_object.py
[modify] https://crrev.com/07700732c4187a25b3e300f99469608eb36a24df/appengine/findit/services/compile_failure/compile_failure_analysis.py
[modify] https://crrev.com/07700732c4187a25b3e300f99469608eb36a24df/appengine/findit/pipelines/compile_failure/test/analyze_compile_failure_pipeline_test.py
[modify] https://crrev.com/07700732c4187a25b3e300f99469608eb36a24df/appengine/findit/services/build_failure_analysis.py
[modify] https://crrev.com/07700732c4187a25b3e300f99469608eb36a24df/appengine/findit/services/deps.py
[modify] https://crrev.com/07700732c4187a25b3e300f99469608eb36a24df/appengine/findit/services/compile_failure/test/extract_compile_signal_test.py
[modify] https://crrev.com/07700732c4187a25b3e300f99469608eb36a24df/appengine/findit/pipelines/compile_failure/test/heuristic_analysis_for_compile_pipeline_test.py
[modify] https://crrev.com/07700732c4187a25b3e300f99469608eb36a24df/appengine/findit/services/git.py
[modify] https://crrev.com/07700732c4187a25b3e300f99469608eb36a24df/appengine/findit/services/test/build_failure_analysis_test.py
[modify] https://crrev.com/07700732c4187a25b3e300f99469608eb36a24df/appengine/findit/libs/test/structured_object_test.py
[modify] https://crrev.com/07700732c4187a25b3e300f99469608eb36a24df/appengine/findit/services/ci_failure.py
[modify] https://crrev.com/07700732c4187a25b3e300f99469608eb36a24df/appengine/findit/services/compile_failure/test/compile_failure_analysis_test.py
[modify] https://crrev.com/07700732c4187a25b3e300f99469608eb36a24df/appengine/findit/services/test/ci_failure_test.py
[modify] https://crrev.com/07700732c4187a25b3e300f99469608eb36a24df/appengine/findit/pipelines/compile_failure/heuristic_analysis_for_compile_pipeline.py
[modify] https://crrev.com/07700732c4187a25b3e300f99469608eb36a24df/appengine/findit/services/compile_failure/extract_compile_signal.py
[modify] https://crrev.com/07700732c4187a25b3e300f99469608eb36a24df/appengine/findit/services/test/deps_test.py
[modify] https://crrev.com/07700732c4187a25b3e300f99469608eb36a24df/appengine/findit/services/test/git_test.py
[modify] https://crrev.com/07700732c4187a25b3e300f99469608eb36a24df/appengine/findit/services/parameters.py
[modify] https://crrev.com/07700732c4187a25b3e300f99469608eb36a24df/appengine/findit/pipelines/compile_failure/analyze_compile_failure_pipeline.py

Project Member

Comment 20 by bugdroid1@chromium.org, Dec 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/34007b88a1e9ebfef758d6dcf3a2c496c75e616d

commit 34007b88a1e9ebfef758d6dcf3a2c496c75e616d
Author: Chan <chanli@chromium.org>
Date: Mon Dec 04 17:18:14 2017

[Fndit] Make HeuristicAnalysisForTestPipeline inherit from new BasePipeline.

Bug:  766851 
Change-Id: I4750c6ec133b086ee493e0056b1e65883f64f5d8
Reviewed-on: https://chromium-review.googlesource.com/804998
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/34007b88a1e9ebfef758d6dcf3a2c496c75e616d/appengine/findit/libs/structured_object.py
[modify] https://crrev.com/34007b88a1e9ebfef758d6dcf3a2c496c75e616d/appengine/findit/services/test_failure/test/test_failure_analysis_test.py
[modify] https://crrev.com/34007b88a1e9ebfef758d6dcf3a2c496c75e616d/appengine/findit/services/compile_failure/compile_failure_analysis.py
[modify] https://crrev.com/34007b88a1e9ebfef758d6dcf3a2c496c75e616d/appengine/findit/pipelines/test_failure/analyze_test_failure_pipeline.py
[modify] https://crrev.com/34007b88a1e9ebfef758d6dcf3a2c496c75e616d/appengine/findit/services/build_failure_analysis.py
[modify] https://crrev.com/34007b88a1e9ebfef758d6dcf3a2c496c75e616d/appengine/findit/pipelines/test_failure/test/heuristic_analysis_for_test_pipeline_test.py
[modify] https://crrev.com/34007b88a1e9ebfef758d6dcf3a2c496c75e616d/appengine/findit/services/parameters.py
[modify] https://crrev.com/34007b88a1e9ebfef758d6dcf3a2c496c75e616d/appengine/findit/services/test_failure/test_failure_analysis.py
[modify] https://crrev.com/34007b88a1e9ebfef758d6dcf3a2c496c75e616d/appengine/findit/services/test_failure/extract_test_signal.py
[modify] https://crrev.com/34007b88a1e9ebfef758d6dcf3a2c496c75e616d/appengine/findit/services/test/build_failure_analysis_test.py
[modify] https://crrev.com/34007b88a1e9ebfef758d6dcf3a2c496c75e616d/appengine/findit/libs/test/structured_object_test.py
[modify] https://crrev.com/34007b88a1e9ebfef758d6dcf3a2c496c75e616d/appengine/findit/services/test_failure/test/extract_test_signal_test.py
[modify] https://crrev.com/34007b88a1e9ebfef758d6dcf3a2c496c75e616d/appengine/findit/pipelines/compile_failure/heuristic_analysis_for_compile_pipeline.py
[modify] https://crrev.com/34007b88a1e9ebfef758d6dcf3a2c496c75e616d/appengine/findit/pipelines/test_failure/test/analyze_test_failure_pipeline_test.py
[modify] https://crrev.com/34007b88a1e9ebfef758d6dcf3a2c496c75e616d/appengine/findit/services/test/deps_test.py
[modify] https://crrev.com/34007b88a1e9ebfef758d6dcf3a2c496c75e616d/appengine/findit/pipelines/test_failure/heuristic_analysis_for_test_pipeline.py

Project Member

Comment 21 by bugdroid1@chromium.org, Dec 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/3620b313a6bcb6f11adb1d14c4e68e9794d8fcba

commit 3620b313a6bcb6f11adb1d14c4e68e9794d8fcba
Author: Shuotao Gao <stgao@chromium.org>
Date: Wed Dec 06 23:52:02 2017

Revert "[Findit] Make HeuristicAnalysisForCompilePipeline inherit from new BasePipeline."

This reverts commit 07700732c4187a25b3e300f99469608eb36a24df.

Reason for revert: The HeuristicAnalysisForTestPipeline was reverted, and this one depends on some change there.
Revert/merge conflict are resolved.

Original change's description:
> [Findit] Make HeuristicAnalysisForCompilePipeline inherit from new BasePipeline.
>
> Bug:  766851 
> Change-Id: Id0f49b5d668a9e09f613c1c103d8e8496195dcc3
> Reviewed-on: https://chromium-review.googlesource.com/798750
> Commit-Queue: Chan Li <chanli@chromium.org>
> Reviewed-by: Shuotao Gao <stgao@chromium.org>
> Reviewed-by: Roberto Carrillo <robertocn@chromium.org>

TBR=stgao@chromium.org,robertocn@chromium.org,chanli@chromium.org

Bug:  766851 
Change-Id: I41f30d001424abbc50a35f0ada922c159b6d6c49
Reviewed-on: https://chromium-review.googlesource.com/812451
Commit-Queue: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/3620b313a6bcb6f11adb1d14c4e68e9794d8fcba/appengine/findit/libs/structured_object.py
[modify] https://crrev.com/3620b313a6bcb6f11adb1d14c4e68e9794d8fcba/appengine/findit/services/compile_failure/compile_failure_analysis.py
[modify] https://crrev.com/3620b313a6bcb6f11adb1d14c4e68e9794d8fcba/appengine/findit/pipelines/compile_failure/test/analyze_compile_failure_pipeline_test.py
[modify] https://crrev.com/3620b313a6bcb6f11adb1d14c4e68e9794d8fcba/appengine/findit/services/build_failure_analysis.py
[modify] https://crrev.com/3620b313a6bcb6f11adb1d14c4e68e9794d8fcba/appengine/findit/services/deps.py
[modify] https://crrev.com/3620b313a6bcb6f11adb1d14c4e68e9794d8fcba/appengine/findit/services/compile_failure/test/extract_compile_signal_test.py
[modify] https://crrev.com/3620b313a6bcb6f11adb1d14c4e68e9794d8fcba/appengine/findit/pipelines/compile_failure/test/heuristic_analysis_for_compile_pipeline_test.py
[modify] https://crrev.com/3620b313a6bcb6f11adb1d14c4e68e9794d8fcba/appengine/findit/services/git.py
[modify] https://crrev.com/3620b313a6bcb6f11adb1d14c4e68e9794d8fcba/appengine/findit/services/test/build_failure_analysis_test.py
[modify] https://crrev.com/3620b313a6bcb6f11adb1d14c4e68e9794d8fcba/appengine/findit/libs/test/structured_object_test.py
[modify] https://crrev.com/3620b313a6bcb6f11adb1d14c4e68e9794d8fcba/appengine/findit/services/ci_failure.py
[modify] https://crrev.com/3620b313a6bcb6f11adb1d14c4e68e9794d8fcba/appengine/findit/services/compile_failure/test/compile_failure_analysis_test.py
[modify] https://crrev.com/3620b313a6bcb6f11adb1d14c4e68e9794d8fcba/appengine/findit/services/test/ci_failure_test.py
[modify] https://crrev.com/3620b313a6bcb6f11adb1d14c4e68e9794d8fcba/appengine/findit/pipelines/compile_failure/heuristic_analysis_for_compile_pipeline.py
[modify] https://crrev.com/3620b313a6bcb6f11adb1d14c4e68e9794d8fcba/appengine/findit/services/compile_failure/extract_compile_signal.py
[modify] https://crrev.com/3620b313a6bcb6f11adb1d14c4e68e9794d8fcba/appengine/findit/services/test/deps_test.py
[modify] https://crrev.com/3620b313a6bcb6f11adb1d14c4e68e9794d8fcba/appengine/findit/services/test/git_test.py
[modify] https://crrev.com/3620b313a6bcb6f11adb1d14c4e68e9794d8fcba/appengine/findit/services/parameters.py
[modify] https://crrev.com/3620b313a6bcb6f11adb1d14c4e68e9794d8fcba/appengine/findit/pipelines/compile_failure/analyze_compile_failure_pipeline.py

Project Member

Comment 22 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/93e26a3d30bed57e60cdd259179073f655564970

commit 93e26a3d30bed57e60cdd259179073f655564970
Author: Chan <chanli@chromium.org>
Date: Tue Jan 09 21:21:45 2018

Reland:[Findit] Make HeuristicAnalysisForCompilePipeline inherit from new BasePipeline.

This CL will reland changes in https://chromium-review.googlesource.com/c/infra/infra/+/798750.

Bug:766851
Change-Id: I52330e6e3a49db87f54274e06e3daa4dd4afdc65
Reviewed-on: https://chromium-review.googlesource.com/855499
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/93e26a3d30bed57e60cdd259179073f655564970/appengine/findit/libs/structured_object.py
[modify] https://crrev.com/93e26a3d30bed57e60cdd259179073f655564970/appengine/findit/services/compile_failure/compile_failure_analysis.py
[modify] https://crrev.com/93e26a3d30bed57e60cdd259179073f655564970/appengine/findit/pipelines/compile_failure/test/analyze_compile_failure_pipeline_test.py
[modify] https://crrev.com/93e26a3d30bed57e60cdd259179073f655564970/appengine/findit/services/build_failure_analysis.py
[modify] https://crrev.com/93e26a3d30bed57e60cdd259179073f655564970/appengine/findit/services/deps.py
[modify] https://crrev.com/93e26a3d30bed57e60cdd259179073f655564970/appengine/findit/services/compile_failure/test/extract_compile_signal_test.py
[modify] https://crrev.com/93e26a3d30bed57e60cdd259179073f655564970/appengine/findit/pipelines/compile_failure/test/heuristic_analysis_for_compile_pipeline_test.py
[modify] https://crrev.com/93e26a3d30bed57e60cdd259179073f655564970/appengine/findit/services/git.py
[modify] https://crrev.com/93e26a3d30bed57e60cdd259179073f655564970/appengine/findit/services/test/build_failure_analysis_test.py
[modify] https://crrev.com/93e26a3d30bed57e60cdd259179073f655564970/appengine/findit/libs/test/structured_object_test.py
[modify] https://crrev.com/93e26a3d30bed57e60cdd259179073f655564970/appengine/findit/services/ci_failure.py
[modify] https://crrev.com/93e26a3d30bed57e60cdd259179073f655564970/appengine/findit/services/compile_failure/test/compile_failure_analysis_test.py
[modify] https://crrev.com/93e26a3d30bed57e60cdd259179073f655564970/appengine/findit/services/test/ci_failure_test.py
[modify] https://crrev.com/93e26a3d30bed57e60cdd259179073f655564970/appengine/findit/pipelines/compile_failure/heuristic_analysis_for_compile_pipeline.py
[modify] https://crrev.com/93e26a3d30bed57e60cdd259179073f655564970/appengine/findit/services/compile_failure/extract_compile_signal.py
[modify] https://crrev.com/93e26a3d30bed57e60cdd259179073f655564970/appengine/findit/services/test/deps_test.py
[modify] https://crrev.com/93e26a3d30bed57e60cdd259179073f655564970/appengine/findit/services/test/git_test.py
[modify] https://crrev.com/93e26a3d30bed57e60cdd259179073f655564970/appengine/findit/services/parameters.py
[modify] https://crrev.com/93e26a3d30bed57e60cdd259179073f655564970/appengine/findit/pipelines/compile_failure/analyze_compile_failure_pipeline.py

Project Member

Comment 23 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/010187d1bb57a9f087c0d80587a32580e2af03b2

commit 010187d1bb57a9f087c0d80587a32580e2af03b2
Author: Chan <chanli@chromium.org>
Date: Wed Jan 10 00:10:33 2018

Reland: [Findit] Make HeuristicAnalysisForTestPipeline inherit from new BasePipeline.

This is a reland of CL https://chromium-review.googlesource.com/c/infra/infra/+/804998

Bug:  766851 
Change-Id: I3d2bf9fae91324ce6660b52adacbb97506aea4b3
Reviewed-on: https://chromium-review.googlesource.com/855513
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/010187d1bb57a9f087c0d80587a32580e2af03b2/appengine/findit/services/test_failure/test/test_failure_analysis_test.py
[modify] https://crrev.com/010187d1bb57a9f087c0d80587a32580e2af03b2/appengine/findit/services/compile_failure/compile_failure_analysis.py
[modify] https://crrev.com/010187d1bb57a9f087c0d80587a32580e2af03b2/appengine/findit/pipelines/test_failure/analyze_test_failure_pipeline.py
[modify] https://crrev.com/010187d1bb57a9f087c0d80587a32580e2af03b2/appengine/findit/services/build_failure_analysis.py
[delete] https://crrev.com/38fae909e791bef4fb775a1901421b64972f1ee2/appengine/findit/waterfall/test/data/sample_swarming_build_abctest_tasks.json
[modify] https://crrev.com/010187d1bb57a9f087c0d80587a32580e2af03b2/appengine/findit/pipelines/test_failure/test/heuristic_analysis_for_test_pipeline_test.py
[delete] https://crrev.com/38fae909e791bef4fb775a1901421b64972f1ee2/appengine/findit/waterfall/test/data/sample_swarming_build_tasks.json
[modify] https://crrev.com/010187d1bb57a9f087c0d80587a32580e2af03b2/appengine/findit/services/parameters.py
[modify] https://crrev.com/010187d1bb57a9f087c0d80587a32580e2af03b2/appengine/findit/services/test_failure/test_failure_analysis.py
[modify] https://crrev.com/010187d1bb57a9f087c0d80587a32580e2af03b2/appengine/findit/services/test_failure/extract_test_signal.py
[modify] https://crrev.com/010187d1bb57a9f087c0d80587a32580e2af03b2/appengine/findit/services/test/build_failure_analysis_test.py
[modify] https://crrev.com/010187d1bb57a9f087c0d80587a32580e2af03b2/appengine/findit/waterfall/test/swarming_util_test.py
[modify] https://crrev.com/010187d1bb57a9f087c0d80587a32580e2af03b2/appengine/findit/services/ci_failure.py
[modify] https://crrev.com/010187d1bb57a9f087c0d80587a32580e2af03b2/appengine/findit/services/test_failure/test/extract_test_signal_test.py
[modify] https://crrev.com/010187d1bb57a9f087c0d80587a32580e2af03b2/appengine/findit/pipelines/compile_failure/heuristic_analysis_for_compile_pipeline.py
[modify] https://crrev.com/010187d1bb57a9f087c0d80587a32580e2af03b2/appengine/findit/pipelines/test_failure/test/analyze_test_failure_pipeline_test.py
[modify] https://crrev.com/010187d1bb57a9f087c0d80587a32580e2af03b2/appengine/findit/services/test/deps_test.py
[modify] https://crrev.com/010187d1bb57a9f087c0d80587a32580e2af03b2/appengine/findit/waterfall/swarming_util.py
[modify] https://crrev.com/010187d1bb57a9f087c0d80587a32580e2af03b2/appengine/findit/services/test_failure/test/ci_test_failure_test.py
[modify] https://crrev.com/010187d1bb57a9f087c0d80587a32580e2af03b2/appengine/findit/services/test_failure/ci_test_failure.py
[modify] https://crrev.com/010187d1bb57a9f087c0d80587a32580e2af03b2/appengine/findit/pipelines/test_failure/heuristic_analysis_for_test_pipeline.py

Status: Fixed (was: Assigned)

Sign in to add a comment