New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 766849 link

Starred by 1 user
Status: Fixed
Owner:
█ kateso...@chromium.org
Last visit > 30 days ago
Closed: Sep 2017
Cc:
mbarbe...@chromium.org
infe...@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 765834



Sign in to add a comment

[Predator] Investigate whey Predator didn't find Test>Layout component.

Project Member Reported by kateso...@chromium.org, Sep 19 2017 
[Predator] Investigate whey Predator didn't find Test>Layout component.

Investigate this case
https://findit-for-me.googleplex.com/clusterfuzz/result-feedback?key=ahpzfmdvb2dsZS5jb206ZmluZGl0LWZvci1tZXJBCxITQ2x1c3RlcmZ1enpBbmFseXNpcyIoY2I0OGJmNTgwOWQzZmM3ZmQ5OWE0OWI3NDE0NDAzYzBhZmIwZmJhMgw

We should've found the component below:
{
    "component": "Test>Layout",
    "dirs": [
        "src/content/shell/test_runner"
    ]
}
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/b97e8a5567b92f5176e5ccf420df10596736be34

commit b97e8a5567b92f5176e5ccf420df10596736be34
Author: Sharu Jiang <katesonia@google.com>
Date: Wed Sep 20 19:42:17 2017

[Predator] Fix a bug of dep_path normalization.

The bug is because in parse_util, we do:
normalized_path = normalized_path[len(current_dep_path + '/'):]

This won't work for a path like this:
/b/c/b/Mac_ASAN_Release_Media/src/content/shell/test_runner/web_view_test_proxy.h
which after normalization, the dep_path should be "src", file_path should be "content/shell/test_runner/web_view_test_proxy.h"

We should use:
normalized_path.split(current_dep_path + '/', 1)[1]

Bug:  766849 
Change-Id: I3d0b5ae04a3bf9d7d2686e48b67a0068aa7b4f54
Reviewed-on: https://chromium-review.googlesource.com/674024
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Sharu Jiang <katesonia@chromium.org>

[modify] https://crrev.com/b97e8a5567b92f5176e5ccf420df10596736be34/appengine/predator/analysis/test/parse_util_test.py
[modify] https://crrev.com/b97e8a5567b92f5176e5ccf420df10596736be34/appengine/predator/analysis/test/stacktrace_test.py
[modify] https://crrev.com/b97e8a5567b92f5176e5ccf420df10596736be34/appengine/predator/analysis/test/clusterfuzz_parser_test.py
[modify] https://crrev.com/b97e8a5567b92f5176e5ccf420df10596736be34/appengine/predator/analysis/test/chromecrash_parser_test.py
[modify] https://crrev.com/b97e8a5567b92f5176e5ccf420df10596736be34/appengine/predator/analysis/test/uma_sampling_profiler_parser_test.py
[modify] https://crrev.com/b97e8a5567b92f5176e5ccf420df10596736be34/appengine/predator/analysis/parse_util.py

Comment 2 by kateso...@chromium.org, Sep 20 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment