Cros Splitview - Minor issue with divider placement. |
||||
Issue descriptionPretty hard to see with the naked eye, but broke a test. Easier to see if you set the divider size to bigger like 70px & 120px. 1) Snap two windows so the divider shows up. 2) click the divider, and then release Expected: Nothing happens Actual: Divider shifts to the right, by divider width / 2 pixels
,
Oct 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4497ce78db1f11796b837b3f415c08951a9bd003 commit 4497ce78db1f11796b837b3f415c08951a9bd003 Author: Sammie Quon <sammiequon@google.com> Date: Wed Oct 18 04:40:04 2017 splitview: Splitview divider not centered. Fixed in this cl: 1) Snap two windows, and then tap the divider but do not drag. Divider shifts. 2) Drag divider to one third, then to two thirds. Left window in first scenario is larger than right window in second scenario. 3) Replace some instances of CreateTestWindowWithBounds with CreateTestWindow. Test: manual, ash_unittests SplitViewControllerTest.* Bug: 766845 Change-Id: I37ae535bd1aa881898b723359cfbdb1f3b77d845 Reviewed-on: https://chromium-review.googlesource.com/673905 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#509683} [modify] https://crrev.com/4497ce78db1f11796b837b3f415c08951a9bd003/ash/wm/overview/window_selector_unittest.cc [modify] https://crrev.com/4497ce78db1f11796b837b3f415c08951a9bd003/ash/wm/splitview/split_view_controller.cc [modify] https://crrev.com/4497ce78db1f11796b837b3f415c08951a9bd003/ash/wm/splitview/split_view_controller.h [modify] https://crrev.com/4497ce78db1f11796b837b3f415c08951a9bd003/ash/wm/splitview/split_view_controller_unittest.cc
,
Oct 18 2017
,
Jan 22 2018
,
Jan 23 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by sammiequon@chromium.org
, Sep 19 2017