Issue metadata
Sign in to add a comment
|
Chromebox: 'Battery' item listed under settings UI |
||||||||||||||||||||||
Issue descriptionGoogle Chrome: 62.0.3202.28 dev build Platform : 9901.21.0 dev-channel on Chromebox (Beltino- mccloud) What steps will reproduce the problem? (1) Check Settings page> Power What is the expected result? Settings should not show Battery option in it. What happens instead? There is 'Battery' item listed under settings page. Refer the attachment
,
Sep 19 2017
,
Sep 19 2017
N
,
Sep 19 2017
This presumably regressed with my work for issue 633455 : we used to only show the power subpage on devices with dual-role USB Type-C ports (thus ruling out Chromeboxes), but I made us show it unconditionally (because the new idle setting is always applicable). I think we should hide the top section (id "powerSourceRow") when ash::PowerStatus::IsBatteryPresent() is false. Probably too late to fix for M61, unfortunately.
,
Sep 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0461649f907fb15bcccea6c14cc4ba156ec2be77 commit 0461649f907fb15bcccea6c14cc4ba156ec2be77 Author: Daniel Erat <derat@chromium.org> Date: Thu Sep 21 16:56:53 2017 chromeos: Hide status from power settings when no battery. Hide the battery status row from the power device settings subpage when no battery is present (e.g. on a Chromebox). We used to handle this by hiding the entire subpage when a dual-role Type-C port wasn't present, but that behavior went away when power settings were added. Bug: 766828 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia176bf4ea318db050b41c0b62e539d2fb704648a Reviewed-on: https://chromium-review.googlesource.com/674023 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#503475} [modify] https://crrev.com/0461649f907fb15bcccea6c14cc4ba156ec2be77/chrome/browser/resources/settings/device_page/device_page_browser_proxy.js [modify] https://crrev.com/0461649f907fb15bcccea6c14cc4ba156ec2be77/chrome/browser/resources/settings/device_page/power.html [modify] https://crrev.com/0461649f907fb15bcccea6c14cc4ba156ec2be77/chrome/browser/resources/settings/device_page/power.js [modify] https://crrev.com/0461649f907fb15bcccea6c14cc4ba156ec2be77/chrome/browser/ui/webui/settings/chromeos/device_power_handler.cc [modify] https://crrev.com/0461649f907fb15bcccea6c14cc4ba156ec2be77/chrome/test/data/webui/settings/device_page_tests.js
,
Sep 21 2017
,
Sep 21 2017
Approved for 62.
,
Sep 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/86470e5e90e6ba830dbe9824c74ffd045df720a1 commit 86470e5e90e6ba830dbe9824c74ffd045df720a1 Author: Daniel Erat <derat@chromium.org> Date: Thu Sep 21 17:37:36 2017 chromeos: Hide status from power settings when no battery. Hide the battery status row from the power device settings subpage when no battery is present (e.g. on a Chromebox). We used to handle this by hiding the entire subpage when a dual-role Type-C port wasn't present, but that behavior went away when power settings were added. Bug: 766828 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia176bf4ea318db050b41c0b62e539d2fb704648a Reviewed-on: https://chromium-review.googlesource.com/674023 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Dan Erat <derat@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#503475}(cherry picked from commit 0461649f907fb15bcccea6c14cc4ba156ec2be77) Reviewed-on: https://chromium-review.googlesource.com/677071 Reviewed-by: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#379} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/86470e5e90e6ba830dbe9824c74ffd045df720a1/chrome/browser/resources/settings/device_page/device_page_browser_proxy.js [modify] https://crrev.com/86470e5e90e6ba830dbe9824c74ffd045df720a1/chrome/browser/resources/settings/device_page/power.html [modify] https://crrev.com/86470e5e90e6ba830dbe9824c74ffd045df720a1/chrome/browser/resources/settings/device_page/power.js [modify] https://crrev.com/86470e5e90e6ba830dbe9824c74ffd045df720a1/chrome/browser/ui/webui/settings/chromeos/device_power_handler.cc [modify] https://crrev.com/86470e5e90e6ba830dbe9824c74ffd045df720a1/chrome/test/data/webui/settings/device_page_tests.js
,
Sep 21 2017
,
Oct 24 2017
Chrome OS 10032.14.0, 63.0.3239.17 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by mkarkada@chromium.org
, Sep 19 20171.4 MB
1.4 MB View Download