New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 766809 link

Starred by 1 user
Status: Fixed
Owner:
█ xunji...@chromium.org
Last visit > 30 days ago
Closed: Sep 2017
Cc:
nedngu...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove unused pagesets json files

Project Member Reported by xunji...@chromium.org, Sep 19 2017 
I looked over page sets that still reference .wpr archives. There are a few left.

https://cs.chromium.org/search/?q=file:json$+.wpr%5C%22&sq=package:chromium&type=cs

Some seem to be unused:

e.g.
tools/perf/page_sets/data/2012Q3.json
tools/perf/page_sets/data/inbox_data.json
tools/perf/page_sets/data/android_acceptance.json


Should we remove those?

Comment 1 by nedngu...@google.com, Sep 19 2017 

Yup, we should remove those.

Comment 3 by xunji...@chromium.org, Sep 21 2017

Owner: xunji...@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef98cc51ab0a807bada83b564a6b9bd5362033b9

commit ef98cc51ab0a807bada83b564a6b9bd5362033b9
Author: Helen Li <xunjieli@chromium.org>
Date: Thu Sep 21 17:25:39 2017

Remove a few wpr.sha1 that are not used anywhere

These few wpr.sha1 are not used in any page sets.

R=nednguyen@google.com

Bug:  766809 
Change-Id: If2ba3bf065b1a9392f5e129b51b12d168af23861
Reviewed-on: https://chromium-review.googlesource.com/677308
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503490}
[delete] https://crrev.com/c63b7083cae36ce7f16fb3829d819d2f65db3e01/tools/perf/page_sets/data/doyouevenbench_000.wpr.sha1
[delete] https://crrev.com/c63b7083cae36ce7f16fb3829d819d2f65db3e01/tools/perf/page_sets/data/octane_000.wpr.sha1
[delete] https://crrev.com/c63b7083cae36ce7f16fb3829d819d2f65db3e01/tools/perf/page_sets/data/polymer_000.wpr.sha1
[delete] https://crrev.com/c63b7083cae36ce7f16fb3829d819d2f65db3e01/tools/perf/page_sets/data/service_worker_037.wpr.sha1
[delete] https://crrev.com/c63b7083cae36ce7f16fb3829d819d2f65db3e01/tools/perf/page_sets/data/service_worker_039.wpr.sha1
[delete] https://crrev.com/c63b7083cae36ce7f16fb3829d819d2f65db3e01/tools/perf/page_sets/data/top_1000_mobile_0_000.wpr.sha1
[delete] https://crrev.com/c63b7083cae36ce7f16fb3829d819d2f65db3e01/tools/perf/page_sets/data/top_1000_mobile_1_000.wpr.sha1
[delete] https://crrev.com/c63b7083cae36ce7f16fb3829d819d2f65db3e01/tools/perf/page_sets/data/top_1000_mobile_2_000.wpr.sha1
[delete] https://crrev.com/c63b7083cae36ce7f16fb3829d819d2f65db3e01/tools/perf/page_sets/data/top_1000_mobile_3_000.wpr.sha1
[delete] https://crrev.com/c63b7083cae36ce7f16fb3829d819d2f65db3e01/tools/perf/page_sets/data/top_1000_mobile_4_000.wpr.sha1
[delete] https://crrev.com/c63b7083cae36ce7f16fb3829d819d2f65db3e01/tools/perf/page_sets/data/top_1000_mobile_5_000.wpr.sha1
[delete] https://crrev.com/c63b7083cae36ce7f16fb3829d819d2f65db3e01/tools/perf/page_sets/data/top_1000_mobile_6_000.wpr.sha1
[delete] https://crrev.com/c63b7083cae36ce7f16fb3829d819d2f65db3e01/tools/perf/page_sets/data/top_1000_mobile_7_000.wpr.sha1
[delete] https://crrev.com/c63b7083cae36ce7f16fb3829d819d2f65db3e01/tools/perf/page_sets/data/top_1000_mobile_8_000.wpr.sha1
[delete] https://crrev.com/c63b7083cae36ce7f16fb3829d819d2f65db3e01/tools/perf/page_sets/data/top_1000_mobile_9_000.wpr.sha1
[delete] https://crrev.com/c63b7083cae36ce7f16fb3829d819d2f65db3e01/tools/perf/page_sets/data/top_10_mobile_000.wpr.sha1
[delete] https://crrev.com/c63b7083cae36ce7f16fb3829d819d2f65db3e01/tools/perf/page_sets/data/top_10_mobile_002.wpr.sha1
[delete] https://crrev.com/c63b7083cae36ce7f16fb3829d819d2f65db3e01/tools/perf/page_sets/data/top_10_mobile_003.wpr.sha1
[delete] https://crrev.com/c63b7083cae36ce7f16fb3829d819d2f65db3e01/tools/perf/page_sets/data/top_10_mobile_004.wpr.sha1
[delete] https://crrev.com/c63b7083cae36ce7f16fb3829d819d2f65db3e01/tools/perf/page_sets/data/tough_ad_cases_007.wpr.sha1
[delete] https://crrev.com/c63b7083cae36ce7f16fb3829d819d2f65db3e01/tools/perf/page_sets/data/tough_ad_cases_008.wpr.sha1
[delete] https://crrev.com/c63b7083cae36ce7f16fb3829d819d2f65db3e01/tools/perf/page_sets/data/tough_filters_cases_000.wpr.sha1
[delete] https://crrev.com/c63b7083cae36ce7f16fb3829d819d2f65db3e01/tools/perf/page_sets/data/typical_25_000.wpr.sha1
[delete] https://crrev.com/c63b7083cae36ce7f16fb3829d819d2f65db3e01/tools/perf/page_sets/data/typical_25_001.wpr.sha1
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdbdfb6c33ff22390a1bc063d20302f154381487

commit fdbdfb6c33ff22390a1bc063d20302f154381487
Author: Helen Li <xunjieli@chromium.org>
Date: Thu Sep 21 20:29:05 2017

Remove a few PageSet jsons and wpr.sha1 files that aren't used

Bug:  766809 
Change-Id: I18c670791e002139256abaf71dcc5c6312f2ba5d
Reviewed-on: https://chromium-review.googlesource.com/677229
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#503548}
[delete] https://crrev.com/57c1b83a591417f6b8c0cb1144252a20bb8356f0/tools/perf/page_sets/data/gmail_refresh.json
[delete] https://crrev.com/57c1b83a591417f6b8c0cb1144252a20bb8356f0/tools/perf/page_sets/data/gmail_refresh_001.wpr.sha1
[delete] https://crrev.com/57c1b83a591417f6b8c0cb1144252a20bb8356f0/tools/perf/page_sets/data/idle_multi_tab_cases.json
[delete] https://crrev.com/57c1b83a591417f6b8c0cb1144252a20bb8356f0/tools/perf/page_sets/data/idle_multi_tab_cases_000.wpr.sha1
[delete] https://crrev.com/57c1b83a591417f6b8c0cb1144252a20bb8356f0/tools/perf/page_sets/data/key_desktop_sites.json
[delete] https://crrev.com/57c1b83a591417f6b8c0cb1144252a20bb8356f0/tools/perf/page_sets/data/key_desktop_sites_001.wpr.sha1
[delete] https://crrev.com/57c1b83a591417f6b8c0cb1144252a20bb8356f0/tools/perf/page_sets/data/key_search_mobile.json
[delete] https://crrev.com/57c1b83a591417f6b8c0cb1144252a20bb8356f0/tools/perf/page_sets/data/key_search_mobile_000.wpr.sha1
[delete] https://crrev.com/57c1b83a591417f6b8c0cb1144252a20bb8356f0/tools/perf/page_sets/data/robohornet_pro.json
[delete] https://crrev.com/57c1b83a591417f6b8c0cb1144252a20bb8356f0/tools/perf/page_sets/data/robohornet_pro_000.wpr.sha1
[delete] https://crrev.com/57c1b83a591417f6b8c0cb1144252a20bb8356f0/tools/perf/page_sets/data/service_worker_micro_benchmark_001.wpr.sha1
[delete] https://crrev.com/57c1b83a591417f6b8c0cb1144252a20bb8356f0/tools/perf/page_sets/data/service_worker_micro_benchmark_002.wpr.sha1
[delete] https://crrev.com/57c1b83a591417f6b8c0cb1144252a20bb8356f0/tools/perf/page_sets/data/top_25_005.wpr.sha1
[delete] https://crrev.com/57c1b83a591417f6b8c0cb1144252a20bb8356f0/tools/perf/page_sets/data/top_7_stress.json
[delete] https://crrev.com/57c1b83a591417f6b8c0cb1144252a20bb8356f0/tools/perf/page_sets/data/top_7_stress_000.wpr.sha1
[delete] https://crrev.com/57c1b83a591417f6b8c0cb1144252a20bb8356f0/tools/perf/page_sets/data/top_7_stress_001.wpr.sha1
[delete] https://crrev.com/57c1b83a591417f6b8c0cb1144252a20bb8356f0/tools/perf/page_sets/data/top_7_stress_002.wpr.sha1
[delete] https://crrev.com/57c1b83a591417f6b8c0cb1144252a20bb8356f0/tools/perf/page_sets/data/top_7_stress_004.wpr.sha1
[delete] https://crrev.com/57c1b83a591417f6b8c0cb1144252a20bb8356f0/tools/perf/page_sets/data/tough_energy_cases_004.wpr.sha1
[delete] https://crrev.com/57c1b83a591417f6b8c0cb1144252a20bb8356f0/tools/perf/page_sets/data/tough_webgl_cases_004.wpr.sha1

Comment 7 by xunji...@chromium.org, Sep 21 2017

Status: Fixed (was: Started)
Ned has CLs to address the rest :)
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/046ff779ae19472dd01b85770a7b2998dff8a6a2

commit 046ff779ae19472dd01b85770a7b2998dff8a6a2
Author: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Date: Fri Sep 22 12:17:23 2017

Revert "Remove a few wpr.sha1 that are not used anywhere"

This reverts commit ef98cc51ab0a807bada83b564a6b9bd5362033b9.

Reason for revert: seems to break the generate orderfile step

Bug: 767836

Original change's description:
> Remove a few wpr.sha1 that are not used anywhere
> 
> These few wpr.sha1 are not used in any page sets.
> 
> R=​nednguyen@google.com
> 
> Bug:  766809 
> Change-Id: If2ba3bf065b1a9392f5e129b51b12d168af23861
> Reviewed-on: https://chromium-review.googlesource.com/677308
> Reviewed-by: Ned Nguyen <nednguyen@google.com>
> Commit-Queue: Helen Li <xunjieli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#503490}

TBR=xunjieli@chromium.org,nednguyen@google.com

Change-Id: Idb18bd4ae8414a9f870bef53d99ca4608b4f2ed1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  766809 
Reviewed-on: https://chromium-review.googlesource.com/678774
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503719}
[add] https://crrev.com/046ff779ae19472dd01b85770a7b2998dff8a6a2/tools/perf/page_sets/data/doyouevenbench_000.wpr.sha1
[add] https://crrev.com/046ff779ae19472dd01b85770a7b2998dff8a6a2/tools/perf/page_sets/data/octane_000.wpr.sha1
[add] https://crrev.com/046ff779ae19472dd01b85770a7b2998dff8a6a2/tools/perf/page_sets/data/polymer_000.wpr.sha1
[add] https://crrev.com/046ff779ae19472dd01b85770a7b2998dff8a6a2/tools/perf/page_sets/data/service_worker_037.wpr.sha1
[add] https://crrev.com/046ff779ae19472dd01b85770a7b2998dff8a6a2/tools/perf/page_sets/data/service_worker_039.wpr.sha1
[add] https://crrev.com/046ff779ae19472dd01b85770a7b2998dff8a6a2/tools/perf/page_sets/data/top_1000_mobile_0_000.wpr.sha1
[add] https://crrev.com/046ff779ae19472dd01b85770a7b2998dff8a6a2/tools/perf/page_sets/data/top_1000_mobile_1_000.wpr.sha1
[add] https://crrev.com/046ff779ae19472dd01b85770a7b2998dff8a6a2/tools/perf/page_sets/data/top_1000_mobile_2_000.wpr.sha1
[add] https://crrev.com/046ff779ae19472dd01b85770a7b2998dff8a6a2/tools/perf/page_sets/data/top_1000_mobile_3_000.wpr.sha1
[add] https://crrev.com/046ff779ae19472dd01b85770a7b2998dff8a6a2/tools/perf/page_sets/data/top_1000_mobile_4_000.wpr.sha1
[add] https://crrev.com/046ff779ae19472dd01b85770a7b2998dff8a6a2/tools/perf/page_sets/data/top_1000_mobile_5_000.wpr.sha1
[add] https://crrev.com/046ff779ae19472dd01b85770a7b2998dff8a6a2/tools/perf/page_sets/data/top_1000_mobile_6_000.wpr.sha1
[add] https://crrev.com/046ff779ae19472dd01b85770a7b2998dff8a6a2/tools/perf/page_sets/data/top_1000_mobile_7_000.wpr.sha1
[add] https://crrev.com/046ff779ae19472dd01b85770a7b2998dff8a6a2/tools/perf/page_sets/data/top_1000_mobile_8_000.wpr.sha1
[add] https://crrev.com/046ff779ae19472dd01b85770a7b2998dff8a6a2/tools/perf/page_sets/data/top_1000_mobile_9_000.wpr.sha1
[add] https://crrev.com/046ff779ae19472dd01b85770a7b2998dff8a6a2/tools/perf/page_sets/data/top_10_mobile_000.wpr.sha1
[add] https://crrev.com/046ff779ae19472dd01b85770a7b2998dff8a6a2/tools/perf/page_sets/data/top_10_mobile_002.wpr.sha1
[add] https://crrev.com/046ff779ae19472dd01b85770a7b2998dff8a6a2/tools/perf/page_sets/data/top_10_mobile_003.wpr.sha1
[add] https://crrev.com/046ff779ae19472dd01b85770a7b2998dff8a6a2/tools/perf/page_sets/data/top_10_mobile_004.wpr.sha1
[add] https://crrev.com/046ff779ae19472dd01b85770a7b2998dff8a6a2/tools/perf/page_sets/data/tough_ad_cases_007.wpr.sha1
[add] https://crrev.com/046ff779ae19472dd01b85770a7b2998dff8a6a2/tools/perf/page_sets/data/tough_ad_cases_008.wpr.sha1
[add] https://crrev.com/046ff779ae19472dd01b85770a7b2998dff8a6a2/tools/perf/page_sets/data/tough_filters_cases_000.wpr.sha1
[add] https://crrev.com/046ff779ae19472dd01b85770a7b2998dff8a6a2/tools/perf/page_sets/data/typical_25_000.wpr.sha1
[add] https://crrev.com/046ff779ae19472dd01b85770a7b2998dff8a6a2/tools/perf/page_sets/data/typical_25_001.wpr.sha1
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7ca90b8c7c6eb93aeae885e6a297a3f446e9780

commit c7ca90b8c7c6eb93aeae885e6a297a3f446e9780
Author: Helen Li <xunjieli@chromium.org>
Date: Fri Sep 22 13:11:17 2017

Revert "Revert "Remove a few wpr.sha1 that are not used anywhere""

This reverts commit 046ff779ae19472dd01b85770a7b2998dff8a6a2.

Reason for revert: <Ned landed a fix>

Original change's description:
> Revert "Remove a few wpr.sha1 that are not used anywhere"
> 
> This reverts commit ef98cc51ab0a807bada83b564a6b9bd5362033b9.
> 
> Reason for revert: seems to break the generate orderfile step
> 
> Bug: 767836
> 
> Original change's description:
> > Remove a few wpr.sha1 that are not used anywhere
> > 
> > These few wpr.sha1 are not used in any page sets.
> > 
> > R=​nednguyen@google.com
> > 
> > Bug:  766809 
> > Change-Id: If2ba3bf065b1a9392f5e129b51b12d168af23861
> > Reviewed-on: https://chromium-review.googlesource.com/677308
> > Reviewed-by: Ned Nguyen <nednguyen@google.com>
> > Commit-Queue: Helen Li <xunjieli@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#503490}
> 
> TBR=xunjieli@chromium.org,nednguyen@google.com
> 
> Change-Id: Idb18bd4ae8414a9f870bef53d99ca4608b4f2ed1
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  766809 
> Reviewed-on: https://chromium-review.googlesource.com/678774
> Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#503719}

TBR=mvanouwerkerk@chromium.org,xunjieli@chromium.org,nednguyen@google.com

Change-Id: I323438bfb4fd6406a0798e2c69cde7f4d27d7f4f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 767836,  766809 
Reviewed-on: https://chromium-review.googlesource.com/678834
Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#503726}
[delete] https://crrev.com/c7e9cd45705c5e0dbc1f6993823c3e5fe357e196/tools/perf/page_sets/data/doyouevenbench_000.wpr.sha1
[delete] https://crrev.com/c7e9cd45705c5e0dbc1f6993823c3e5fe357e196/tools/perf/page_sets/data/octane_000.wpr.sha1
[delete] https://crrev.com/c7e9cd45705c5e0dbc1f6993823c3e5fe357e196/tools/perf/page_sets/data/polymer_000.wpr.sha1
[delete] https://crrev.com/c7e9cd45705c5e0dbc1f6993823c3e5fe357e196/tools/perf/page_sets/data/service_worker_037.wpr.sha1
[delete] https://crrev.com/c7e9cd45705c5e0dbc1f6993823c3e5fe357e196/tools/perf/page_sets/data/service_worker_039.wpr.sha1
[delete] https://crrev.com/c7e9cd45705c5e0dbc1f6993823c3e5fe357e196/tools/perf/page_sets/data/top_1000_mobile_0_000.wpr.sha1
[delete] https://crrev.com/c7e9cd45705c5e0dbc1f6993823c3e5fe357e196/tools/perf/page_sets/data/top_1000_mobile_1_000.wpr.sha1
[delete] https://crrev.com/c7e9cd45705c5e0dbc1f6993823c3e5fe357e196/tools/perf/page_sets/data/top_1000_mobile_2_000.wpr.sha1
[delete] https://crrev.com/c7e9cd45705c5e0dbc1f6993823c3e5fe357e196/tools/perf/page_sets/data/top_1000_mobile_3_000.wpr.sha1
[delete] https://crrev.com/c7e9cd45705c5e0dbc1f6993823c3e5fe357e196/tools/perf/page_sets/data/top_1000_mobile_4_000.wpr.sha1
[delete] https://crrev.com/c7e9cd45705c5e0dbc1f6993823c3e5fe357e196/tools/perf/page_sets/data/top_1000_mobile_5_000.wpr.sha1
[delete] https://crrev.com/c7e9cd45705c5e0dbc1f6993823c3e5fe357e196/tools/perf/page_sets/data/top_1000_mobile_6_000.wpr.sha1
[delete] https://crrev.com/c7e9cd45705c5e0dbc1f6993823c3e5fe357e196/tools/perf/page_sets/data/top_1000_mobile_7_000.wpr.sha1
[delete] https://crrev.com/c7e9cd45705c5e0dbc1f6993823c3e5fe357e196/tools/perf/page_sets/data/top_1000_mobile_8_000.wpr.sha1
[delete] https://crrev.com/c7e9cd45705c5e0dbc1f6993823c3e5fe357e196/tools/perf/page_sets/data/top_1000_mobile_9_000.wpr.sha1
[delete] https://crrev.com/c7e9cd45705c5e0dbc1f6993823c3e5fe357e196/tools/perf/page_sets/data/top_10_mobile_000.wpr.sha1
[delete] https://crrev.com/c7e9cd45705c5e0dbc1f6993823c3e5fe357e196/tools/perf/page_sets/data/top_10_mobile_002.wpr.sha1
[delete] https://crrev.com/c7e9cd45705c5e0dbc1f6993823c3e5fe357e196/tools/perf/page_sets/data/top_10_mobile_003.wpr.sha1
[delete] https://crrev.com/c7e9cd45705c5e0dbc1f6993823c3e5fe357e196/tools/perf/page_sets/data/top_10_mobile_004.wpr.sha1
[delete] https://crrev.com/c7e9cd45705c5e0dbc1f6993823c3e5fe357e196/tools/perf/page_sets/data/tough_ad_cases_007.wpr.sha1
[delete] https://crrev.com/c7e9cd45705c5e0dbc1f6993823c3e5fe357e196/tools/perf/page_sets/data/tough_ad_cases_008.wpr.sha1
[delete] https://crrev.com/c7e9cd45705c5e0dbc1f6993823c3e5fe357e196/tools/perf/page_sets/data/tough_filters_cases_000.wpr.sha1
[delete] https://crrev.com/c7e9cd45705c5e0dbc1f6993823c3e5fe357e196/tools/perf/page_sets/data/typical_25_000.wpr.sha1
[delete] https://crrev.com/c7e9cd45705c5e0dbc1f6993823c3e5fe357e196/tools/perf/page_sets/data/typical_25_001.wpr.sha1
►

Sign in to add a comment