New issue
Advanced search Search tips

Issue 766808 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 700018



Sign in to add a comment

"Generate Password" option should not be shown when password field is readonly

Project Member Reported by elawrence@chromium.org, Sep 19 2017

Issue description

Chrome Version: 63.3219

What steps will reproduce the problem?
(1) Visit chrome://settings/passwords
(2) Right-click on the dots of an obscured password

Observe: A "Generate Password" command is present in the context menu.

Expect: No command, because the field is readonly.

We should probably check to see if the field is readonly before adding the menu item inside RenderViewContextMenu::AppendPasswordItems [1].

It's also not clear to me whether we should offer the Generate Password command on chrome:// pages.

[1] https://cs.chromium.org/chromium/src/chrome/browser/renderer_context_menu/render_view_context_menu.cc?l=1519&rcl=e494fc874f455309c9b025727b40a837bf713971
 

Comment 1 by vabr@chromium.org, Oct 18 2017

Labels: Hotlist-Polish
Status: Available (was: Untriaged)
I'm also surprised by password manager doing stuff on chrome:// pages.

Seems like we should review what ChromePasswordManagerClient::IsPasswordManagementEnabledForCurrentPage should do about non-web schemes.

Comment 2 by kolos@chromium.org, Jan 26 2018

Blocking: 700018

Sign in to add a comment