New issue
Advanced search Search tips

Issue 766785 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 765701
Owner:
Closed: Sep 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Replace get_model_conf_value et al in cros-unibuild

Project Member Reported by sjg@chromium.org, Sep 19 2017

Issue description

All of these functions in the ebuild should use the new cros_config_host, so that fdtget is not used anywhere.

 

Comment 1 by sjg@chromium.org, Sep 27 2017

Mergedinto: 765701
Status: Duplicate (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 31 2017

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/8c5d14177ab95eb6fc8e2d729dcd2a87ed34ee97

commit 8c5d14177ab95eb6fc8e2d729dcd2a87ed34ee97
Author: Simon Glass <sjg@chromium.org>
Date: Wed Nov 01 18:26:02 2017

depthcharge: Use cros_config_host for build targets

We should use the official tool to obtain the build targets rather than
reading directly from the master configuration.

BUG= chromium:766785 
TEST=emerge-reef-uni depthcharge

Change-Id: Ieb389566981165927fab3b11c36f00b485d5fe2c
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/742379
Reviewed-by: Jason Clinton <jclinton@chromium.org>

[modify] https://crrev.com/8c5d14177ab95eb6fc8e2d729dcd2a87ed34ee97/sys-boot/depthcharge/depthcharge-9999.ebuild

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/1b09b7a3aef39923e8ee18f5d48a337746920e5f

commit 1b09b7a3aef39923e8ee18f5d48a337746920e5f
Author: Simon Glass <sjg@chromium.org>
Date: Fri Nov 03 03:47:10 2017

chromeos-bootimage: Use cros_config_host for build targets

We should use the official tool to obtain the build targets rather than
reading directly from the master configuration.

BUG= chromium:766785 
TEST=emerge-reef-uni chromeos-bootimage

Change-Id: I8baad663c05a091067ef5d40d1c5b06311fbaf94
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/742470
Reviewed-by: Jason Clinton <jclinton@chromium.org>

[modify] https://crrev.com/1b09b7a3aef39923e8ee18f5d48a337746920e5f/sys-boot/chromeos-bootimage/chromeos-bootimage-0.0.3.ebuild
[rename] https://crrev.com/1b09b7a3aef39923e8ee18f5d48a337746920e5f/sys-boot/chromeos-bootimage/chromeos-bootimage-0.0.3-r12.ebuild

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/a48466274a7136e9f1937b2ab3bd2e20a0bfb434

commit a48466274a7136e9f1937b2ab3bd2e20a0bfb434
Author: Simon Glass <sjg@chromium.org>
Date: Wed Nov 08 11:12:37 2017

cros-unibuild: Drop old cros_config functions

We don't use these functions anymore, because:

- the firmware packer can access CrosConfig itself
- we have proper cros_config_host commands for obtaining the information
     needed by cros-unibuild, so don't need to read sets, etc.

We want to avoid using the low-level program and use cros_config
instead. Now that all ebuilds have been converted, we can drop these old
functions.

BUG= chromium:766785 
TEST=trybot

Change-Id: I8edb381fabc09c93feaf12d7f7c9191ba139727b
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/743184
Reviewed-by: Jason Clinton <jclinton@chromium.org>

[modify] https://crrev.com/a48466274a7136e9f1937b2ab3bd2e20a0bfb434/eclass/cros-unibuild.eclass
[modify] https://crrev.com/a48466274a7136e9f1937b2ab3bd2e20a0bfb434/eclass/cros-firmware.eclass

Sign in to add a comment