mash: shelf item selection on device with shelf model synchronization |
|||||||
Issue descriptionmash: ARC++ shelf item selection with shelf model synchronization Build chrome ToT (+ http://crrev.com/c/673366) for an ARC++ device. (1) Run Chrome (2) Enable about:flags "Enable Shelf Model Synchronization" (3) "Restart Now" (4) Open the app list. (5) Pin "Play Store (beta)" (or any ARC++ app, eg. "CrossyRoad") to the shelf. (6) Click or tap (or right click or long tap) on the shelf item. Expected: The app launches or a context menu is shown. Actual: Nothing happens (ink drop might be stuck triggered by clicking). This is a blocker for enabling shelf model synchronization by default.
,
Sep 19 2017
,
Sep 19 2017
Hmmm, it seems that this only reproduces after touching a running arc shelf item. Once it starts happening, it won't stop until I sign out and sign back in... Perhaps related to dropping a mojo callback or something? I'll look more soon.
,
Sep 20 2017
,
Sep 20 2017
The first touch breaks the shelf because we try to send ET_GESTURE_TAP over mojo. This is blocked on mojo gestures (Issue 767087), and maybe on Issue 571688 . (Clicking the trackpad sends ET_MOUSE_RELEASED, converted to ET_POINTER_UP/18) 18329:18329:0920/093056.547104:ERROR:shelf_view.cc(476)] MSW ShelfView::ButtonPressed [18329:18329:0920/093056.547297:ERROR:remote_shelf_item_delegate.cc(30)] MSW RemoteShelfItemDelegate::ItemSelected 18 1881264395124736 0 1 [18329:18329:0920/093056.547590:ERROR:app_shortcut_launcher_item_controller.cc(80)] AppShortcutLauncherItemController::ItemSelected [18329:18329:0920/093056.547826:ERROR:chrome_launcher_controller.cc(417)] ChromeLauncherController::LaunchApp A (Touching the screen sends ET_GESTURE_TAP/27, not supported by mojo) [18329:18329:0920/093111.232332:ERROR:shelf_view.cc(476)] MSW ShelfView::ButtonPressed [18329:18329:0920/093111.232513:ERROR:remote_shelf_item_delegate.cc(30)] MSW RemoteShelfItemDelegate::ItemSelected 27 1881264395124736 0 1 [18329:18329:0920/093111.233111:ERROR:validation_errors.cc(87)] Invalid message: VALIDATION_ERROR_DESERIALIZATION_FAILED (subsequent messages are dropped, so no further ash->chrome shelf interaction works correctly)
,
Sep 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6715a07436e4d17126c3d5d3c9775d53d025a8ba commit 6715a07436e4d17126c3d5d3c9775d53d025a8ba Author: Mike Wasserman <msw@chromium.org> Date: Thu Sep 21 18:20:25 2017 mash: Support shelf item selection via ET_GESTURE_TAP. Add basic Mojo struct traits support & test for tap gestures. (this is the minimum needed for tapping on shelf items) Warn and bail on sending unsupported event types. (otherwise it's tough to track these problems down) Bug: 766783 , 767087 Test: Chrome OS shelf items launch via touch w/ about:flags Enable shelf model synchronization" Change-Id: I2aa813be94ce321897838c2e62de5d3097ac04ca Reviewed-on: https://chromium-review.googlesource.com/675581 Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#503514} [modify] https://crrev.com/6715a07436e4d17126c3d5d3c9775d53d025a8ba/ui/events/mojo/event.mojom [modify] https://crrev.com/6715a07436e4d17126c3d5d3c9775d53d025a8ba/ui/events/mojo/event_constants.mojom [modify] https://crrev.com/6715a07436e4d17126c3d5d3c9775d53d025a8ba/ui/events/mojo/event_struct_traits.cc [modify] https://crrev.com/6715a07436e4d17126c3d5d3c9775d53d025a8ba/ui/events/mojo/event_struct_traits.h [modify] https://crrev.com/6715a07436e4d17126c3d5d3c9775d53d025a8ba/ui/events/mojo/struct_traits_unittest.cc
,
Sep 21 2017
,
Jan 22 2018
,
Jan 23 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by msw@chromium.org
, Sep 19 2017