New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 766780 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Team-Security-UX



Sign in to add a comment

Switch SSLErrorAssistant component to be "bundled component"

Project Member Reported by mea...@chromium.org, Sep 19 2017

Issue description

This is same as  bug 654037 , but for SSLErrorAssistant.

 
If you wanted to do both at the same time, that'd be most efficient. :-)

Comment 2 by mea...@chromium.org, Sep 19 2017

Cc: waff...@chromium.org
After reading waffles' comments and the doc, it's still not clear to me how to add a bundled component. The docs say the generated file should go to DIR_MODULE, but it sounds like it'll require modifying the installer.

waffles: Is that right? Is any of the existing components a bundled component?
No modification of the installer is necessary - you should only have to modify some BUILD scripts and FILES.cfg. WidevineCDM is an example, see https://cs.chromium.org/chromium/src/third_party/widevine/cdm/BUILD.gn?type=cs&q=cdm.dll&l=155 .

Also worth looking at are
https://codereview.chromium.org/2000513002
https://codereview.chromium.org/2027373002

Hope that helps!

Comment 4 by mea...@chromium.org, Sep 19 2017

waffles: Thanks! Indeed, dropping the manifest and the proto under SSLErrorHandler/ seems to work.

Before I go further with this idea, I'm wondering if there are any guarantees about when the bundled component becomes available with ComponentReady(). In my case, the data from the component is used for SSL errors. If Chrome is launched pointing a URL with an SSL error, is it possible ComponentReady() to be called after the navigation to that URL?
In that example I think it is a race: IIUC we do not block the browser startup on reading the component data from disk. You could test this locally by inserting a sleep or an infinite loop into component_updater::DefaultComponentInstaller::FindPreinstallation() and then trying out such a launch.

Comment 6 by mea...@chromium.org, Sep 20 2017

Thanks, there is indeed a race when I insert the delay. I was worried that there would be some sort of scheduling that could delay the registration of components for several minutes, but that doesn't seem to be the case and the registration is done on browser startup. It seems we might be able to live with this.

Comment 7 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt

Comment 8 by est...@chromium.org, Feb 18 2018

Labels: -Hotlist-EnamelAndFriendsFixIt

Sign in to add a comment