New issue
Advanced search Search tips

Issue 766773 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

gclient sync reports success when steps have failed

Project Member Reported by danakj@chromium.org, Sep 19 2017

Issue description

1. Try to gclient sync in a checkout with android
2. Your gsutil credentials are not set up.

Expected:

A failure message at the end.

Actual:

"Success!" is reported.

If you scroll up you can find the credential errors above. Example:
________ running '/usr/bin/python src/build/android/update_deps/update_third_party_deps.py download -b chromium-robolectric -l third_party/xstream' in '/usr/local/google/home/danakj/s/c'
Failed to fetch file gs://chromium-robolectric/520d90f30f36a0d6ba2dc929d980831631ad6a92 for /usr/local/google/home/danakj/s/c/src/third_party/xstream/lib/xstream-1.4.8.jar. [Err: Your credentials are invalid. For more help, see "gsutil help creds", or re-run the gsutil config command (see "gsutil help config").
]


 
Components: -Infra>SDK Infra>Client>Android
Status: Available (was: Untriaged)
If a hook fails and yet still returns 0, that can't be picked up by gclient as a failure. That udpate_third_party_deps.py script needs to be updated to make sure it returns a non-zero error code when it runs into a problem like that.
Owner: jbudorick@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f806d496435126ab581701f098eb92a293932469

commit f806d496435126ab581701f098eb92a293932469
Author: John Budorick <jbudorick@chromium.org>
Date: Fri Nov 03 23:42:51 2017

[android] Propagate exit codes from update_third_party_deps.

Bug:  766773 
Change-Id: I4f1ea649f4b2904fb0c30793c840afc63d5ec177
Reviewed-on: https://chromium-review.googlesource.com/753129
Reviewed-by: Benjamin Pastene <bpastene@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513960}
[modify] https://crrev.com/f806d496435126ab581701f098eb92a293932469/build/android/update_deps/update_third_party_deps.py

Status: Fixed (was: Started)

Sign in to add a comment