Unable to open PPDs that have spaces in filename. |
||||
Issue descriptionWhen trying to add a printer manually, if the PPD file provided by the user contains a space then the add will fail. This is because the code which tries to open the file currently does not un-escape the filename provided from the WebUI. For example, given the file: .../Downloads/my ppd.ppd The file attempted to be opened would be something like: ../Downloads/my%20ppd.ppd Which obviously does not exist.
,
Sep 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a87bdc2222369e5eee11b0f541a5dfb2f359c64 commit 7a87bdc2222369e5eee11b0f541a5dfb2f359c64 Author: David Valleau <valleau@chromium.org> Date: Tue Sep 26 00:55:02 2017 Added PPD_TOO_LARGE to ppd_provider.h CallBackResultCode. Using this new enum code the correct error will be displayed to the user when then try to manually add a PPD which is too large. Before the reported error was that the PPD was unable to be retrieved by the server. R=skau@chromium.org Bug: 766767 , 765481 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I281d92f89c7baff5ce5530924d06c76ea1480791 Reviewed-on: https://chromium-review.googlesource.com/673551 Commit-Queue: David Valleau <valleau@chromium.org> Reviewed-by: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#504244} [modify] https://crrev.com/7a87bdc2222369e5eee11b0f541a5dfb2f359c64/chrome/browser/chromeos/printing/printer_configurer.cc [modify] https://crrev.com/7a87bdc2222369e5eee11b0f541a5dfb2f359c64/chromeos/printing/ppd_provider.cc [modify] https://crrev.com/7a87bdc2222369e5eee11b0f541a5dfb2f359c64/chromeos/printing/ppd_provider.h
,
Oct 5 2017
,
Jan 22 2018
,
Jan 23 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by valleau@chromium.org
, Sep 19 2017