[WebView autofill] Shouldn't set form name in classname |
|||||||
Issue descriptionAs discussed in http://b/65751159 , framework already set classname as android.webkit.WebView , WebView shouldn't overwrite it by form name, instead form name should be set in htmlInfo.
,
Sep 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b5d45302bb6473d68f399f98aaac917a55b909b4 commit b5d45302bb6473d68f399f98aaac917a55b909b4 Author: Tao Bai <michaelbai@chromium.org> Date: Wed Sep 20 01:31:03 2017 [WebView autofill] Test of not set class name Test of https://chromium-review.googlesource.com/c/chromium/src/+/673134 Separate test from above patch because the AwAutofillTest isn't in M62. Bug: 766761 Change-Id: I5073e609aefc457aef023e98c33b1122ffdf6c48 Reviewed-on: https://chromium-review.googlesource.com/673140 Reviewed-by: Changwan Ryu <changwan@chromium.org> Reviewed-by: Selim Gurun <sgurun@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#503022} [modify] https://crrev.com/b5d45302bb6473d68f399f98aaac917a55b909b4/android_webview/javatests/src/org/chromium/android_webview/test/AwAutofillTest.java
,
Sep 20 2017
,
Sep 20 2017
This bug requires manual review: M62 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 21 2017
This fix needs to be in OC-MR1 right?
,
Sep 21 2017
Right, it should be MR1 ideally, will we kick off another M61 release?
,
Sep 21 2017
Is this issue currently in M61 Stable? How bad is it?
,
Sep 21 2017
just now talked to michaelbai@, there is no manual steps to verify this fix, code side changes.
,
Sep 21 2017
Merge approved upon verification of the fix on trunk and branch 3202.
,
Sep 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5619a9c488752907c1da5834afe0aa86e21ed4af commit 5619a9c488752907c1da5834afe0aa86e21ed4af Author: Tao Bai <michaelbai@chromium.org> Date: Fri Sep 22 00:34:48 2017 [WebView Autofill] Not set class name Not set class name in WebView, framework already set it. Uses HtmlInfo for form name. Bug: 766761 Change-Id: I92daad8dcc31368b53ad54feac25ac0e8b20732a Reviewed-on: https://chromium-review.googlesource.com/673134 Reviewed-by: Changwan Ryu <changwan@chromium.org> Reviewed-by: Selim Gurun <sgurun@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#503002}(cherry picked from commit fb4fd1ace14f9fc4747c7c459a3317c3d7398c3c) Reviewed-on: https://chromium-review.googlesource.com/677716 Reviewed-by: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#387} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/5619a9c488752907c1da5834afe0aa86e21ed4af/android_webview/java/src/org/chromium/android_webview/AwAutofillProvider.java
,
Sep 25 2017
,
Oct 23 2017
this is code side changes, talk to michaelbai@ earlier, the code side changes has been already implemented (no maunally way to verify this issues) Marking Verfied/Fixed |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Sep 20 2017