New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 766756 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Build-Toolchain



Sign in to add a comment

Applying AutoFDO to kernel with profiles from CWP

Project Member Reported by laszio@chromium.org, Sep 19 2017

Issue description

Basically, it is similar to AFDOUpdateEbuildStage, which modifies Chrome ebuilds.

Steps:
1. Refactor AFDOUpdateEbuildStage into AFDOUpdateChromeEbuildStage and so on. Factor the common parts out.
2. Implement AFDOUpdateKernelEbuildStage.
3. Unittests.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/f73374fafdc5bb5153205797ca1bd097aed146e9

commit f73374fafdc5bb5153205797ca1bd097aed146e9
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Tue Sep 26 23:14:11 2017

AutoFDO: Refactoring to accommodate the update-kernel-ebuild stage

BUG= chromium:766756 
TEST=Tested UpdateManifest and CommitIfChanged locally

Change-Id: Ibf748af58a5732b179d87f2ffadc7e755053a73a
Reviewed-on: https://chromium-review.googlesource.com/682514
Commit-Ready: Ting-Yuan Huang <laszio@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/f73374fafdc5bb5153205797ca1bd097aed146e9/cbuildbot/afdo.py
[modify] https://crrev.com/f73374fafdc5bb5153205797ca1bd097aed146e9/cbuildbot/stages/afdo_stages.py
[modify] https://crrev.com/f73374fafdc5bb5153205797ca1bd097aed146e9/cbuildbot/builders/simple_builders.py

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/504bdb5df9833471b08bc5e73947e2a4df3df80c

commit 504bdb5df9833471b08bc5e73947e2a4df3df80c
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Tue Oct 03 03:25:49 2017

AutoFDO: change profile source and naming convention

from: gs://chromeos-localmirror/distfiles/autofdo-chromeos-kernel-4_4-1.2.3.afdo.xz
to:   gs://chromeos-prebuilt/afdo-job/cwp/kernel/4.4/R61-1.2-3.gcov.xz

BUG= chromium:766756 
TEST=USE=kernel_afdo emerge-quawks chromeos-kernel-4_4

Change-Id: I1e842b37421ed063f3e11d9e7a31d0b45a6567a8
Reviewed-on: https://chromium-review.googlesource.com/685400
Commit-Ready: Ting-Yuan Huang <laszio@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Luis Lozano <llozano@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/504bdb5df9833471b08bc5e73947e2a4df3df80c/sys-kernel/chromeos-kernel-4_4/Manifest
[modify] https://crrev.com/504bdb5df9833471b08bc5e73947e2a4df3df80c/sys-kernel/chromeos-kernel-4_4/chromeos-kernel-4_4-9999.ebuild
[modify] https://crrev.com/504bdb5df9833471b08bc5e73947e2a4df3df80c/sys-kernel/chromeos-kernel-3_8/Manifest
[modify] https://crrev.com/504bdb5df9833471b08bc5e73947e2a4df3df80c/eclass/cros-kernel2.eclass
[modify] https://crrev.com/504bdb5df9833471b08bc5e73947e2a4df3df80c/sys-kernel/chromeos-kernel-3_8/chromeos-kernel-3_8-9999.ebuild

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/9af0cc18a700f5fe48da815768112fd8be4ca693

commit 9af0cc18a700f5fe48da815768112fd8be4ca693
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Wed Oct 04 10:58:41 2017

Enable AutoFDO when building kernels for selected boards

Enabled USE=kernel_afdo on minnie, daisy, cave, cand and elm.

BUG= chromium:766756 
TEST=emerge-* chromeos-kernel-*
CQ-DEPEND=CL:695749

Change-Id: Ic88db809cb4d402e01ef5af6a4d4d5643b7bb763
Reviewed-on: https://chromium-review.googlesource.com/698965
Commit-Ready: Ting-Yuan Huang <laszio@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/9af0cc18a700f5fe48da815768112fd8be4ca693/overlay-elm/profiles/base/make.defaults
[modify] https://crrev.com/9af0cc18a700f5fe48da815768112fd8be4ca693/overlay-cave/profiles/base/make.defaults
[modify] https://crrev.com/9af0cc18a700f5fe48da815768112fd8be4ca693/overlay-candy/make.conf
[modify] https://crrev.com/9af0cc18a700f5fe48da815768112fd8be4ca693/overlay-daisy/make.conf
[modify] https://crrev.com/9af0cc18a700f5fe48da815768112fd8be4ca693/overlay-variant-veyron-minnie/make.conf

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/356b71411632980b7d33362578e0f331013f23a4

commit 356b71411632980b7d33362578e0f331013f23a4
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Thu Oct 05 01:47:11 2017

afdo: update kernel ebuilds

This CL tries to find new profiles in gs and patches the kernel ebuilds
with the latest profiles.

BUG= chromium:766756 
TEST=tryjob on master-chromium-pfq, afdo_unittest
CQ-DEPEND=CL:685400

Change-Id: I8391636f1c981d323f06f85afa509478d1bc8870
Reviewed-on: https://chromium-review.googlesource.com/685599
Commit-Ready: Ting-Yuan Huang <laszio@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Luis Lozano <llozano@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/356b71411632980b7d33362578e0f331013f23a4/cbuildbot/stages/afdo_stages.py
[modify] https://crrev.com/356b71411632980b7d33362578e0f331013f23a4/cbuildbot/afdo.py
[add] https://crrev.com/356b71411632980b7d33362578e0f331013f23a4/cbuildbot/afdo_unittest.py
[add] https://crrev.com/356b71411632980b7d33362578e0f331013f23a4/cbuildbot/afdo_unittest
[modify] https://crrev.com/356b71411632980b7d33362578e0f331013f23a4/cbuildbot/builders/simple_builders.py

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/dc24d40a08e2976b1f339b19c76b9b05a5fcfa7c

commit dc24d40a08e2976b1f339b19c76b9b05a5fcfa7c
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Fri Oct 06 10:57:50 2017

kernel: support building with llvm + autofdo

BUG= chromium:766756 
TEST=USE=kernel_afdo emerge-{swanky,kevin,quawks} chromeos-kernel-4_4

Change-Id: Iea81fa11dc5e6cd2028791edfee59bd898cd03bd
Reviewed-on: https://chromium-review.googlesource.com/702648
Commit-Ready: Ting-Yuan Huang <laszio@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Ting-Yuan Huang <laszio@chromium.org>

[modify] https://crrev.com/dc24d40a08e2976b1f339b19c76b9b05a5fcfa7c/sys-kernel/chromeos-kernel-3_8/chromeos-kernel-3_8-9999.ebuild
[modify] https://crrev.com/dc24d40a08e2976b1f339b19c76b9b05a5fcfa7c/sys-kernel/chromeos-kernel-4_4/chromeos-kernel-4_4-9999.ebuild
[modify] https://crrev.com/dc24d40a08e2976b1f339b19c76b9b05a5fcfa7c/sys-kernel/chromeos-kernel-3_18/chromeos-kernel-3_18-9999.ebuild
[modify] https://crrev.com/dc24d40a08e2976b1f339b19c76b9b05a5fcfa7c/eclass/cros-kernel2.eclass
[modify] https://crrev.com/dc24d40a08e2976b1f339b19c76b9b05a5fcfa7c/sys-kernel/chromeos-kernel-3_14/chromeos-kernel-3_14-9999.ebuild
[modify] https://crrev.com/dc24d40a08e2976b1f339b19c76b9b05a5fcfa7c/sys-kernel/chromeos-kernel-4_12/chromeos-kernel-4_12-9999.ebuild
[modify] https://crrev.com/dc24d40a08e2976b1f339b19c76b9b05a5fcfa7c/sys-kernel/chromeos-kernel-3_10/chromeos-kernel-3_10-9999.ebuild

Cc: llozano@chromium.org gmx@chromium.org diand...@chromium.org
I'm going to disable kernel_afdo on daisy because of this:
https://bugs.chromium.org/p/chromium/issues/detail?id=772450

We are pretty unlucky because we just disabled it two weeks ago and re-enabled it on Oct. 4. My guess is that compiler inlined slightly more aggressively due to the new profiles.

Unfortunately, it seems that we don't have other armv7 boards other than 3.8 or 3.10 or rk3288.
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/9b80e10e2e56984f70f3480c56249b1341279859

commit 9b80e10e2e56984f70f3480c56249b1341279859
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Fri Nov 17 12:02:03 2017

kernel-4_4: enable kernel_afdo

We are gradually rolling out kernel_afdo to most kernel versions.

Kernels built with AutoFDO: 4.4
Kernels built w.o. AutoFDO: 3.8, 3.10, 3.14, 3.18, 4.12

BUG= chromium:766756 
TEST=cros tryjob --hwtest {kevin,snappy,kip,eve}-release-tryjob

Change-Id: I31c061deff6170086f2c54f37836c78d87806579
Reviewed-on: https://chromium-review.googlesource.com/770321
Commit-Ready: Ting-Yuan Huang <laszio@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Sonny Rao <sonnyrao@chromium.org>

[modify] https://crrev.com/9b80e10e2e56984f70f3480c56249b1341279859/profiles/default/linux/package.use

Project Member

Comment 9 by bugdroid1@chromium.org, Dec 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/22bc75c19986b7ffccbe2a0d0dcff690a639d8c5

commit 22bc75c19986b7ffccbe2a0d0dcff690a639d8c5
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Wed Dec 06 02:00:39 2017

kernel-3_18: enable kernel_afdo

We are gradually rolling out kernel_afdo to most kernel versions.

Kernels built with AutoFDO: 3.18, 4.4
Kernels built w.o. AutoFDO: 3.8, 3.10, 3.14, 4.12

BUG= chromium:766756 
TEST=cros tryjob --hwtest {cyan,hana,sentry}-release-tryjob

Change-Id: I206e346a23cd5ae67c9eb335a6cbd5380177f2b3
Reviewed-on: https://chromium-review.googlesource.com/770322
Commit-Ready: Ting-Yuan Huang <laszio@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/22bc75c19986b7ffccbe2a0d0dcff690a639d8c5/profiles/default/linux/package.use

Project Member

Comment 10 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/e6ef1ff7e60dac4ab3052b2d4bbd434516dcc9e0

commit e6ef1ff7e60dac4ab3052b2d4bbd434516dcc9e0
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Thu Jan 18 22:44:44 2018

kernel-3_8: enable kernel_afdo

We are gradually rolling out kernel_afdo to most kernel versions.

Kernels built with AutoFDO: 3.8, 3.14, 3.18, 4.4
Kernels built w.o. AutoFDO: 3.10, 4.12

BUG= chromium:766756 
TEST=cros tryjob --hwtest {peach-pi,wolf}-release-tryjob

Change-Id: I36c41ec8af3429d3e3ba7d4a3b84a3204ac49dc3
Reviewed-on: https://chromium-review.googlesource.com/770324
Commit-Ready: Ting-Yuan Huang <laszio@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/e6ef1ff7e60dac4ab3052b2d4bbd434516dcc9e0/profiles/default/linux/package.use

Components: Tools>ChromeOS-Toolchain
Status: Fixed (was: Started)

Sign in to add a comment