New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 766754 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[cr-audit-commits] Fix audit failure issue template

Project Member Reported by robert...@chromium.org, Sep 19 2017

Issue description

There are some issues with the template for audit failure, see for example: https://bugs.chromium.org/p/chromium/issues/detail?id=766748

There is an error with the first line of the template.

In the list of rules, display the failures first.

Indent the rules, and pad the rule names.
 

Comment 1 by st...@chromium.org, Sep 19 2017

Per discussion offline, let's go with a separator like ":" first before adding indent/padding.
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/422c432ae8cf98e68b148eca4bd55b396260ee8c

commit 422c432ae8cf98e68b148eca4bd55b396260ee8c
Author: Roberto Carrillo <robertocn@google.com>
Date: Wed Sep 20 22:19:43 2017

[cr-audit-commits] Fix issue template.

Show failures first, fix templating problem.

R=stgao,chanli
BUG= 766754 

Change-Id: I2f82d5989178860539c0006ea94ffc1ee63d0c9d
Reviewed-on: https://chromium-review.googlesource.com/673703
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/422c432ae8cf98e68b148eca4bd55b396260ee8c/go/src/infra/appengine/cr-audit-commits/app/utils.go

Status: Fixed (was: Started)

Sign in to add a comment